From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id D44AC37AF for ; Sun, 9 Jul 2017 10:37:41 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id 77so17633996wrb.3 for ; Sun, 09 Jul 2017 01:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9cgRhGCjSBU3/IcT2ue7p/tAOdNzhq6hqIKPtUc8lBY=; b=SoLiy5fGEkf3DW6OKhKignGs4G4ER4GORUD9JRGAY+tPpZsJi0sIhsA+BlKYZQmD8g QDf/r+VNt0QVl0ocPYUHQNxaNAG/tDG3pra0Wy46MtRkw3nSg7JbzrrfPAzxbx9CkuTn 8TYpJM8hoMAEdOpUe76XfPUUrMdE0I7TRhCOTfsSpMSb9OiFKCGzcFP0xf0SdjT8F85j 6uN3ndEjQ5A88+DEnwav8ZiIEgbkeRqe8lJmwas501oNgiwq0SEKiies5yvvM8yUFWSF 70iI+gvljci7OLK/xvIjdeptI64dYSuG/8Hl6OoHU+GKbbuy78uacvPdbhoJPjxvA2kb 6fgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9cgRhGCjSBU3/IcT2ue7p/tAOdNzhq6hqIKPtUc8lBY=; b=DjOOxLamNa0qncIhd6DlQzdTlORzeIUVaSg+39b3Q5ghcc7vXvrWrwOhHFiRZ6h5YT 1XFozuRCHpyDBLEsT7IzsZcR8D0O/4LlyQptH2sI4diE/bzCivAOuF2+F86xbMeXQjG3 7Sla/nN8VgjREfjkXM8Gk86+awbrOf0zbMy4M7l3XSJWVCcmqVITU5iK6QGTZpRfHQKB vQAYaglDJYwAjnjVKxtX67M360OoOI2ZZ1G9SnFLnmN1F64jeiYTIrfOzkAzieVS625h zZ8cSCTrhTocUxn9gXMmT/mBE5unWtQDDEM2B7Qx9lJQfEyCZWcjAAodvSWt5978ORt9 EP0A== X-Gm-Message-State: AIVw1139gd5QRgiWqH+3N+7MVGBczk0/BbjxRrR4XCIQ9+1IebTgfkpg WIodyb+8oLotgtQj8jQfWRnvRBMI9A== X-Received: by 10.28.64.85 with SMTP id n82mr4102205wma.54.1499589461463; Sun, 09 Jul 2017 01:37:41 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Sun, 9 Jul 2017 01:37:40 -0700 (PDT) In-Reply-To: <3893726.oUZ9cfT8R6@xps> References: <3893726.oUZ9cfT8R6@xps> From: Jan Blunck Date: Sun, 9 Jul 2017 04:37:40 -0400 X-Google-Sender-Auth: cxn_QXcD-0ssWYNy5ssHv0L3MW8 Message-ID: To: Thomas Monjalon Cc: Gaetan Rivet , dev , Stephen Hemminger , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 08:37:42 -0000 On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon wrote: > 07/07/2017 02:04, Gaetan Rivet: >> In this patchset, the representation of devices in rte_devargs is made generic >> to remove some dependencies of the EAL on specific buses implementations. >> Following the device types being characterized by their bus, the DEVTYPE >> flags are updated not to reference virtual / PCI devices anymore. > [...] >> Gaetan Rivet (16): >> net/bonding: properly reference PCI header >> net/bnxt: properly reference PCI header >> net/mlx5: properly reference PCI header >> net/e1000: properly reference PCI header >> net/ixgbe: properly reference PCI header >> net/sfc: properly reference PCI header >> app/testpmd: properly reference PCI header >> test: properly reference PCI header >> dev: device kernel module is a device attribute >> bus: introduce bus scan policies >> devargs: parse bus policies >> devargs: generic device representation >> net/virtio: do not reference device type >> devargs: generic device types >> devargs: introduce cleaner parsing helper >> eal: change whitelist / blacklist command line doc >> >> Thomas Monjalon (1): >> examples/ethtool: properly reference PCI header > > Series applied, except last patch (17), as explained before. Thanks > I wonder why you complain about not having enough reviewers if you anyway ignoring their feedback! I pointed out multiple times that parsing a device name to deduce the bus is not the right thing to do. This series also tightly couples rte_devargs to rte_bus. It adds hidden functionality to have blacklist/whitelist mode for all busses and even sticks that functionality on the wrong object (devargs).