From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 4F77439EA for ; Tue, 28 Feb 2017 09:34:28 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id u63so1114310wmu.2 for ; Tue, 28 Feb 2017 00:34:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lFJgd6GCDG2VZWvJ4Rc50Y9ETAStOTv/HyZAfD7cAvk=; b=H1EHedpW+q4PAbDOqw0VeUkEinEasBPLtlM/45UynpAlopvRG7vID1iFXK55xCTRUC yypetmER8w9JJ7Q9l97UZXmWbcQdFo5UVI44IKUWj3QsqNYu62QaWjFeXpjLEDmLSY8r SqcHSg++E+la3WiECYUZbaOP/siuMR7EF0wcfXud0Etr47v3oD76KaUHtzAV8xvXJyRL PyTcgYmQatgDIziS519QoSsK0TtX6PnWeoIzPxUanx120ffPsb2PzoXzdujrrAeDs4Zm qJi5A23L8uwO04uLkd+c3Gq0ePmw3STS4YIMaimpfk22lFlXXymFLU1QYfLH/9lhGF5R 2wOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lFJgd6GCDG2VZWvJ4Rc50Y9ETAStOTv/HyZAfD7cAvk=; b=JUjPd8gFZeAjEfjXUTW4yZQMyx9HtJVj3BvrboCnXLKwIe7ttRxJpkyKcErIwcamw+ RyV3rYKmsmgzLJg5HGns4KiK5d6vDRshkkfsE3pIREwktDiLuSS173uvom525S6red1/ ui1ZwmWvMroBIBIFHQxoVr/yPDB7ie4J7OKbs9oZW9YFPMtEIAOx4x4D8zsngzCZeIUN nqN1NIQVNzxQw4Z8zn3ILdeTqx/hrCrZKXd7ImXNxwib+BogWYatAw0NTjhMdOQRA9Mm Ztx7q2LkM4WcK1NUFaFljOUcio37fZBHVoQXWAgQasQ6/XwJJ4C3/4yOx+IZT24g/2pg MRgA== X-Gm-Message-State: AMke39ll4tuqDuyUHyUdLrP/Bk1cCWPZnNmZJcHp+BFfQCacrCTIK4BtOdANK8nFgRdwBRIOuwoZaem3uvu9dg== X-Received: by 10.28.183.4 with SMTP id h4mr4593707wmf.140.1488270868010; Tue, 28 Feb 2017 00:34:28 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.211.20 with HTTP; Tue, 28 Feb 2017 00:34:27 -0800 (PST) In-Reply-To: <1487769892-17042-1-git-send-email-christian.ehrhardt@canonical.com> References: <1487769892-17042-1-git-send-email-christian.ehrhardt@canonical.com> From: Jan Blunck Date: Tue, 28 Feb 2017 09:34:27 +0100 X-Google-Sender-Auth: KeHS4cRBm1_bCz6BeGxp8SoboUc Message-ID: To: Christian Ehrhardt Cc: dev , "cjcollier @ linuxfoundation . org" , ricardo.salveti@linaro.org, Luca Boccassi Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] mk: Provide option to set Major ABI version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:34:28 -0000 On Wed, Feb 22, 2017 at 2:24 PM, Christian Ehrhardt wrote: > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -40,6 +40,12 @@ EXTLIB_BUILD ?= n > # VPATH contains at least SRCDIR > VPATH += $(SRCDIR) > > +ifneq ($(CONFIG_RTE_MAJOR_ABI),) > +ifneq ($(LIBABIVER),) > +LIBABIVER := $(CONFIG_RTE_MAJOR_ABI) > +endif > +endif > + > ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > LIB := $(patsubst %.a,%.so.$(LIBABIVER),$(LIB)) > ifeq ($(EXTLIB_BUILD),n) > @@ -156,11 +162,7 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB) > @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib > $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib > ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > -ifeq ($(CONFIG_RTE_NEXT_ABI)$(EXTLIB_BUILD),yn) > - $(Q)ln -s -f $< $(basename $(basename $@)) > -else > - $(Q)ln -s -f $< $(basename $@) > -endif > + $(Q)ln -s -f $< $(shell echo $@ | sed 's/\.so.*/.so/') > endif > In case CONFIG_RTE_NEXT_ABI=y is set this is actually generating shared objects with suffix: .so.$(CONFIG_RTE_MAJOR_ABI).1 I don't think that this is the intention.