From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id B05E47CA9 for ; Sun, 9 Jul 2017 12:46:50 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id z45so18249001wrb.2 for ; Sun, 09 Jul 2017 03:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=K65OFI2gHAU4aWnv12Zq/OIK9/2axa/fxe7ysoJrG5w=; b=S7Eyjf9Ao6N27qKVLgfY6F4B0CR+I4qOWMKcnF6fu/H90odjQT0tgu3RJj9eHLPPAJ hM6WGG048vqPeqnTTnnbFydzc/WvqpA2TSU5E71ROYx8RmjOZiYcXQTUVwZZA9mOvfHm tmyhtgTjiA4bvgAD6ihlP+TM6oZ/slmD0MrMeuWFAoGaMmskCP8/6lGktq7+kqIQe1S5 gjSKGOk9dQMYKG719Ta7/tzjDenKoqJqIeMxIK9RYWsP6/apjIfzwqAfwjim6Xdt1+Ar Kffx9ILs3h4Qb3lAlJwfiaQHP1V77ITc2aawbLp7xjFslvvbnDmbNJpRUuoBSq3dCc2r nwTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=K65OFI2gHAU4aWnv12Zq/OIK9/2axa/fxe7ysoJrG5w=; b=VFYLBkiu7dnDxgWXT265ACQNqlLCimqCh3GA9N/ZN1hY3Pc0Jmf91/TeIevIia9MUN aNS0lFuZbh2VZTjKDyKzXAP6qZcMA2VB0Ct5r2qorEdIe7hpts7FZ7RoxBxh39J5zmHq 1k6EPU4Cpc+tGi9A7kx4QS0/R6T1efVvnzHlU9rlMC4uBSbRKWw9I85+2JLcSymoqaSL ukdycfIZ3nJvnIeUJKJXcZxPiAH9kOlXtDCVPeijv6tqxHgg+rRqs7otJAncEwlrZTxE mKYmPW7GsZKl1YEe1x8djRJtqQvcmCKBxPPZ+ohr6KKzD05M+a7RDj3B5XaGKxr5tdRY 8Gog== X-Gm-Message-State: AIVw113moDNzaSDcLF5mrc0QbaP+xi5xSb11GmTOiI/7hz+m4VyPTmz5 JYTtzgOGxBAiLlqnWELb3uSph9HMjA== X-Received: by 10.223.142.143 with SMTP id q15mr4608412wrb.180.1499597210484; Sun, 09 Jul 2017 03:46:50 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Sun, 9 Jul 2017 03:46:49 -0700 (PDT) In-Reply-To: <12210751.V8za9RMinW@xps> References: <20170709092847.13339-1-jblunck@infradead.org> <20170709092847.13339-2-jblunck@infradead.org> <12210751.V8za9RMinW@xps> From: Jan Blunck Date: Sun, 9 Jul 2017 06:46:49 -0400 X-Google-Sender-Auth: gUVr53IiqBGyX3j2wO0iK9nVXZk Message-ID: To: Thomas Monjalon Cc: dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 10:46:50 -0000 On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon wrote: > 09/07/2017 11:28, Jan Blunck: >> This is going to get cleaned up in future releases so lets not expose >> this API unnecessarily. >> >> Signed-off-by: Jan Blunck >> --- >> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >> @@ -211,7 +211,6 @@ DPDK_17.08 { >> EXPERIMENTAL { >> global: >> >> - rte_eal_devargs_parse; >> rte_eal_hotplug_add; >> rte_eal_hotplug_remove; > > We need to expose it temporarily as experimental in order to let > the failsafe driver calling it. > When reworked in 17.11, this function or an equivalent should allow > failsafe (and maybe bonding) to parse slave declaration. There is no need for the failsafe PMD to parse it to a rte_devargs because it can just pass the string to the hotplug API.