From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id EEBF97CA9 for ; Sun, 9 Jul 2017 13:16:46 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id r103so102437117wrb.0 for ; Sun, 09 Jul 2017 04:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=moXmS2N3nO+2bmIdmp/pzle21Fz/V8009c2qlVOfz3s=; b=FTqf3RpTITU7fKwBcqDATaSRX9FE9G/NTfdhq0o4hPzZgfrfPIJhr8kxFo1Ie9gbgm nwRg8Zs4uGqbCHSnVjvLuvmAFwvW1DnL+2SG19UqrGI7LWqy2L3k2wZ1M5J9VUAz1VFy zy5cKhna8Fvu/s379GmqkJCdFO9PxE/GmgIEslqhDiMGevLG6XIMcKI0FPE9mRpRNo6P 9uaj6zRsHJsh2gcFOgqqyyNDh3zSrTtSr3KHq5uCKAkpLGKSSG0hXPs2UWO6kKac4sIt 2IPVqNgENxHImL4Tgz9AOIktV079sk7FF9MgAwDLrYPPvrV20eByAwPe/nynWMoi1uYd gnSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=moXmS2N3nO+2bmIdmp/pzle21Fz/V8009c2qlVOfz3s=; b=IPpte2L+M6vvJPd2se9NrZwf5J/eYOG6H2y/KRptqq1zQwycDjr458B60sybuRre11 PeVkGE20EPP52H4ET80sslsZ8ohZlPGNIeGxwx1Jt+pcWTC95u4oSwYG7+VNsUzZoz/k 7oZTaPq+FPoDxj2pedcK6hy0rAYfFKeoyeNZkze+6drzet1/PMgGdqcZFaoF5X2qfE7L dWsbZIOuzlkVM+4Yc/OLr0X0UxOpNfwJjmn1kSMHUq44gK2SokMysSluB8yMg3LRwYkW vyNlnVjzKsFpEtGcIkQE0iQiPRzcWFFhzMi5fSct0xffMU412S+t1nGSDT3ArtowkYoz fQVA== X-Gm-Message-State: AIVw110J/6wFyE+ZEw92ZDjH73wCgkKPKigjTSGESyVNo9hxuYZDd6eG OxqyYY3qf57L1Zp5j7HLcNDJTwPiYw== X-Received: by 10.28.94.13 with SMTP id s13mr4472968wmb.33.1499599006545; Sun, 09 Jul 2017 04:16:46 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Sun, 9 Jul 2017 04:16:45 -0700 (PDT) In-Reply-To: <4219460.8ez8IeSCfv@xps> References: <3893726.oUZ9cfT8R6@xps> <4219460.8ez8IeSCfv@xps> From: Jan Blunck Date: Sun, 9 Jul 2017 07:16:45 -0400 X-Google-Sender-Auth: -O4Ynqm6zIun15B80nHC2fwpTSI Message-ID: To: Thomas Monjalon Cc: dev , Gaetan Rivet , Stephen Hemminger , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 00/17] Generic devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 11:16:47 -0000 On Sun, Jul 9, 2017 at 6:17 AM, Thomas Monjalon wrote: > 09/07/2017 10:37, Jan Blunck: >> On Sat, Jul 8, 2017 at 6:28 PM, Thomas Monjalon wrote: >> > 07/07/2017 02:04, Gaetan Rivet: >> >> In this patchset, the representation of devices in rte_devargs is made generic >> >> to remove some dependencies of the EAL on specific buses implementations. >> >> Following the device types being characterized by their bus, the DEVTYPE >> >> flags are updated not to reference virtual / PCI devices anymore. >> > [...] >> >> Gaetan Rivet (16): >> >> net/bonding: properly reference PCI header >> >> net/bnxt: properly reference PCI header >> >> net/mlx5: properly reference PCI header >> >> net/e1000: properly reference PCI header >> >> net/ixgbe: properly reference PCI header >> >> net/sfc: properly reference PCI header >> >> app/testpmd: properly reference PCI header >> >> test: properly reference PCI header >> >> dev: device kernel module is a device attribute >> >> bus: introduce bus scan policies >> >> devargs: parse bus policies >> >> devargs: generic device representation >> >> net/virtio: do not reference device type >> >> devargs: generic device types >> >> devargs: introduce cleaner parsing helper >> >> eal: change whitelist / blacklist command line doc >> >> >> >> Thomas Monjalon (1): >> >> examples/ethtool: properly reference PCI header >> > >> > Series applied, except last patch (17), as explained before. Thanks >> > >> >> I wonder why you complain about not having enough reviewers if you >> anyway ignoring their feedback! > > I am not ignoring your feedback at all. > There are 2 things in this series: > 1/ decouple devargs and PCI/vdev > 2/ couple devargs policies to rte_bus > I agree that we should not have policies in rte_bus (2). > However it is the only patches we have for now to achieve (1), > which is a required step to move PCI and vdev as real bus drivers. (1) is easy to achieve. I've explained multiple times that devargs shoudl be: - bus name - device name - device arguments Somehow I expected that giving suggestions and review comments will lead to people actively working on this picking up the ideas. I guess I was mistaken. I'll save my breath and fix it myself. > As explained in the following email, I prefer progressing on (1) > and rework (2) in 17.11: > http://dpdk.org/ml/archives/dev/2017-July/070203.html > What do you think of my proposal, adding a callback in probe? > >> I pointed out multiple times that parsing a device name to deduce the >> bus is not the right thing to do. > > Yes, so we need to change the parameter syntax to make the bus name > explicit and mandatory. We need a deprecation notice. > >> This series also tightly couples rte_devargs to rte_bus. >> It adds hidden functionality to have >> blacklist/whitelist mode for all busses and even sticks that >> functionality on the wrong object (devargs). > > Yes, as said above, we must rework it in 17.11. >