From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id E224B2E8B for ; Tue, 11 Jul 2017 21:43:47 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id x23so584055wrb.0 for ; Tue, 11 Jul 2017 12:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=QJz0cBD+Gqifq/UDovaG3QoE32CHh8n7Ls7hBPEf+yY=; b=aCUk7aPc0g1XPvQ7fIU1RxOW6qDYLnOX2qY8OtjyuSBA4nuNujBSFxTLSXSsulUwLY f27Ifr1BMKDrXi6OFcGZFOAQiNYTc5mk7QCKC70iXLObzEyUaC59td4auS2da9bNAO4F IA/0hojdcAfnWtLNcxsB3WVpCFotFUXsJYYLbdSFUQtThDXLcDL6XwqWESFGdj4+F9DX xJNp3tlgSzvZY+SRuqgsyc1wgtBbnoUEjCY6d5UP2jMxH1pCZkx6fzFuiK1mcX6UNbaA RbqJ5U44SfRi+kGmzo1JhBW/WYOLl/rni7yF5N0cpwQXaMxjqcT7tGVpZ7+KhOuUT3/8 5IzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=QJz0cBD+Gqifq/UDovaG3QoE32CHh8n7Ls7hBPEf+yY=; b=dglEljw6C1pISzOQy0a6UQrj50XNXuf0PGGbzuoNwfDPaEuzvO0M9dB8bsrZwGhr8Z C+9jEpLoW0KYKJsjCkEr4yvsz9H64rFntVuft1dV+87xEZdhvryKyL7/FoSaGLqtsrhT 0/i6rjPVZ0DkpEYAW424ZIucC+Sec+ExXVEX02f7luBJ37d3ELHRAjeses3J2oKGi7Ld wWAC1E3684fLIzgOHmqnr/j9C1rdgnjO7PbIKMxD+9dmYPB4onx9RrIGcr2aJHwFl/El 6hzfu4BSdJdJ/YGRecqyklXqrDf7LyZU8lja7ALU4ZRcxoBQFzK9Zs1AXdjpE1BY/bKr SZ6Q== X-Gm-Message-State: AIVw111I4cfD0xbu2MXaM/h6qCcVR4DEcnjAYysmBGTSbsWK/tB3Q8Ng Hxi0EdKTPKGdP1S6FupayoZg5ORkdg== X-Received: by 10.223.142.143 with SMTP id q15mr804637wrb.180.1499802227530; Tue, 11 Jul 2017 12:43:47 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Tue, 11 Jul 2017 12:43:46 -0700 (PDT) In-Reply-To: <20170711190907.GX11154@bidouze.vm.6wind.com> References: <20170711185649.43620-1-jblunck@infradead.org> <20170711185649.43620-3-jblunck@infradead.org> <20170711190907.GX11154@bidouze.vm.6wind.com> From: Jan Blunck Date: Tue, 11 Jul 2017 15:43:46 -0400 X-Google-Sender-Auth: T3m0BWRGWRDOJF-pXdmSQOWHmmw Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 19:43:48 -0000 On Tue, Jul 11, 2017 at 3:09 PM, Ga=C3=ABtan Rivet = wrote: > Hi Jan, > > On Tue, Jul 11, 2017 at 02:56:49PM -0400, Jan Blunck wrote: >> It isn't necessary to use rte_bus_find_by_name() to find a reference to >> our own bus. >> >> Signed-off-by: Jan Blunck >> --- >> lib/librte_eal/common/eal_common_vdev.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/co= mmon/eal_common_vdev.c >> index 2ca0cdb0f..db69d18c6 100644 >> --- a/lib/librte_eal/common/eal_common_vdev.c >> +++ b/lib/librte_eal/common/eal_common_vdev.c >> @@ -47,6 +47,9 @@ >> #include >> #include >> >> +/* Forward declare to access virtual bus name */ >> +static struct rte_bus rte_vdev_bus; >> + >> /** Double linked list of virtual device drivers. */ >> TAILQ_HEAD(vdev_device_list, rte_vdev_device); >> >> @@ -138,7 +141,7 @@ alloc_devargs(const char *name, const char *args) >> if (!devargs) >> return NULL; >> >> - devargs->bus =3D rte_bus_find_by_name("vdev"); >> + devargs->bus =3D rte_bus_find_by_name(rte_vdev_bus.name); > > Why not directly &rte_vdev_bus here? > Thanks, will fix. >> if (args) >> devargs->args =3D strdup(args); >> >> @@ -250,13 +253,11 @@ vdev_scan(void) >> { >> struct rte_vdev_device *dev; >> struct rte_devargs *devargs; >> - struct rte_bus *vbus; >> >> /* for virtual devices we scan the devargs_list populated via cmdl= ine */ >> - vbus =3D rte_bus_find_by_name("vdev"); >> TAILQ_FOREACH(devargs, &devargs_list, next) { >> >> - if (devargs->bus !=3D vbus) >> + if (devargs->bus !=3D &rte_vdev_bus) >> continue; >> >> dev =3D find_vdev(devargs->name); >> -- >> 2.13.2 >> > > -- > Ga=C4=97tan Rivet > 6WIND