From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jblunck@gmail.com>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
by dpdk.org (Postfix) with ESMTP id BE27E271;
Tue, 27 Jun 2017 21:19:15 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id p204so2730218wmg.1;
Tue, 27 Jun 2017 12:19:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:sender:in-reply-to:references:from:date:message-id
:subject:to:cc;
bh=uAGvvtwyBYzwXmh3luxDFzqlsTLne3FsLFxCdLELEXk=;
b=C9QcU2gsIm6T20vr2Ty4sKhrMIBJ8yo2/MPUGWefrl9oqDgnbLwuNOlD14w+FD/9x3
OFD+ZAPNH+o/tEt3d3eLAJH7qi/8WbbtweUxYxYReP1xDQ7GxqvStQdD4oc905VGLwNx
9paZVjGa0fbqGAEHYeUN0kictI4J1vE/JQCj8xw2Zr7w28pkPGposUwSS9VWShPxpn6D
v4DH4E/enjgm6xOh0LnGAWyNoAqmouoQfL+iBxA1j8h/Dm6ByK1gm14Cu6F/KRFik5jg
0AvVfszHZjveCK9Tv8BL/6SFtlcY63IRG3Bn1WMAn7eDsN+Cz/sXouY7Tvb7DrkGIAjr
0wQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
:date:message-id:subject:to:cc;
bh=uAGvvtwyBYzwXmh3luxDFzqlsTLne3FsLFxCdLELEXk=;
b=azOdcvtQm4ujvIhUwoyH+5OwZVqqFFNW94dZ5IKVOHvXzsGS5gDBEuuKmAsJ0+1gS9
qGu+lIzOAbnvbNYk37cVcC4wHST7yyVQW9ZEwqCmm93NmZvUdPGqUUaoQl6A6O4fEpcB
KNQiMKEPwPfsWCJPCekmlAxiW//1X3UgGHC2nxEmjYxGhGz9RV9PLuvYwfRuinzT6jff
8bcz3Z3N3As6qLPo9JG5X+LZqf1up8LUqqRL8EC2EuOdKvrtnkqpu1UjpBUrntYw1Tdx
Zwg4SpMxu86xYl41kWY4xjTvniozpbGtm1/pQgITti+CS52+Km2q9aHCFKTG/Y5wbgXr
MxGw==
X-Gm-Message-State: AKS2vOzUDBgTgCiGiBFMTR6C59cQ5aT+xExRireOXwiOudrmtXegLbLZ
SSLh4BSRNi5jh8+wc+g2ifOYfs0/KQ==
X-Received: by 10.28.47.79 with SMTP id v76mr4421777wmv.34.1498591155325; Tue,
27 Jun 2017 12:19:15 -0700 (PDT)
MIME-Version: 1.0
Sender: jblunck@gmail.com
Received: by 10.28.158.200 with HTTP; Tue, 27 Jun 2017 12:19:14 -0700 (PDT)
In-Reply-To: <206669e001a4561a5f5c10deebcf70742688f380.1497999826.git.gaetan.rivet@6wind.com>
References: <cover.1496876810.git.gaetan.rivet@6wind.com>
<cover.1497999826.git.gaetan.rivet@6wind.com>
<206669e001a4561a5f5c10deebcf70742688f380.1497999826.git.gaetan.rivet@6wind.com>
From: Jan Blunck <jblunck@infradead.org>
Date: Tue, 27 Jun 2017 21:19:14 +0200
X-Google-Sender-Auth: 61JKRGR0Xnr9tFaGFDybQYgJo5c
Message-ID: <CALe+Z01GL_MDMyoEvwe=bFpac_KS0uCMDs56VyREhcWESwfK2A@mail.gmail.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev <dev@dpdk.org>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v5 1/7] bus: fix bus name registration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2017 19:19:16 -0000
On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> The default bus registration function should not result in buses
> registering with double quotes within their names.
>
This is breaking expectations with users. All other registration macro
pass the names through the stringification. The problem is that you
pass in the name as a string already ("PCI" instead of PCI).
> Fixes: a97725791eec ("bus: introduce bus abstraction")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_eal/common/include/rte_bus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h
> index fcc2442..b220299 100644
> --- a/lib/librte_eal/common/include/rte_bus.h
> +++ b/lib/librte_eal/common/include/rte_bus.h
> @@ -254,7 +254,7 @@ struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev);
> #define RTE_REGISTER_BUS(nm, bus) \
> static void __attribute__((constructor(101), used)) businitfn_ ##nm(void) \
> {\
> - (bus).name = RTE_STR(nm);\
> + (bus).name = nm;\
> rte_bus_register(&bus); \
> }
>
> --
> 2.1.4
>