From: Jan Blunck <jblunck@infradead.org>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/9] Decouple ethdev from PCI device
Date: Wed, 21 Dec 2016 16:12:11 +0100 [thread overview]
Message-ID: <CALe+Z01S_Nw=pa0NieBgRdoKnWE+PeH-7F49pBPLTt53pTQYPA@mail.gmail.com> (raw)
In-Reply-To: <79676396-e867-2512-93c5-17fca4604ddf@nxp.com>
On Wed, Dec 21, 2016 at 11:00 AM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> Hi Jan,
>
>
> On Tuesday 20 December 2016 04:41 PM, Jan Blunck wrote:
>>
>> This is a repost of the series I sent in November. I've addressed
>> Shreyansh's
>> review comments about the PCI device users I've missed.
>>
>> Jan Blunck (9):
>> eal: define container_of macro
>> ethdev: Helper to convert to struct rte_pci_device
>> drivers: Use ETH_DEV_PCI_DEV() helper
>> virtio: Don't fill dev_info->driver_name
>> virtio: Add vtpci_intr_handle() helper to get rte_intr_handle
>> virtio: Don't depend on struct rte_eth_dev's pci_dev
>> ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()
>> ethdev: Decouple interrupt handling from PCI device
>> ethdev: Decouple struct rte_eth_dev from struct rte_pci_device
>>
>> app/test/virtual_pmd.c | 4 +-
>> drivers/net/bnx2x/bnx2x_ethdev.c | 13 +++---
>> drivers/net/bnxt/bnxt_ethdev.c | 21 ++++++----
>> drivers/net/bnxt/bnxt_ring.c | 11 ++---
>> drivers/net/bonding/rte_eth_bond_args.c | 12 +++++-
>> drivers/net/cxgbe/cxgbe_ethdev.c | 4 +-
>> drivers/net/cxgbe/cxgbe_main.c | 4 +-
>> drivers/net/e1000/em_ethdev.c | 21 ++++++----
>> drivers/net/e1000/igb_ethdev.c | 52 +++++++++++++----------
>> drivers/net/e1000/igb_pf.c | 3 +-
>> drivers/net/ena/ena_ethdev.c | 4 +-
>> drivers/net/enic/enic_ethdev.c | 3 +-
>> drivers/net/fm10k/fm10k_ethdev.c | 56 +++++++++++++------------
>> drivers/net/i40e/i40e_ethdev.c | 45 ++++++++++----------
>> drivers/net/i40e/i40e_ethdev.h | 4 ++
>> drivers/net/i40e/i40e_ethdev_vf.c | 39 ++++++++---------
>> drivers/net/ixgbe/ixgbe_ethdev.c | 67
>> ++++++++++++++++++------------
>> drivers/net/ixgbe/ixgbe_pf.c | 2 +-
>> drivers/net/mlx4/mlx4.c | 2 +
>> drivers/net/mlx5/mlx5_ethdev.c | 2 +
>> drivers/net/nfp/nfp_net.c | 17 ++++----
>> drivers/net/qede/qede_ethdev.c | 18 ++++----
>> drivers/net/szedata2/rte_eth_szedata2.c | 28 +++++++------
>> drivers/net/szedata2/rte_eth_szedata2.h | 34 +++++++--------
>> drivers/net/thunderx/nicvf_ethdev.c | 7 +++-
>> drivers/net/virtio/virtio_ethdev.c | 38 ++++++++---------
>> drivers/net/virtio/virtio_pci.h | 6 +++
>> drivers/net/virtio/virtio_user_ethdev.c | 1 -
>> drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++-
>> lib/librte_eal/common/include/rte_common.h | 20 +++++++++
>> lib/librte_eal/common/include/rte_pci.h | 6 +++
>> lib/librte_ether/rte_ethdev.c | 25 ++++++++---
>> lib/librte_ether/rte_ethdev.h | 9 +++-
>> 33 files changed, 355 insertions(+), 229 deletions(-)
>>
>
> Besides the MLX* and bnx2x compile errors (responses in individual patch
> email), all other changes look fine to me.
>
> Either you can directly add my series ACK to v4 or, for ML record purpose, I
> will do that once you post v4 - whichever way you prefer.
>
Shreyansh,
Thanks for the review. I've added acks for the patches that you have
review. I've broken out the changes a little bit better like Stephen
did in his series. For these patches I haven't added your acks yet.
Cheers,
Jan
prev parent reply other threads:[~2016-12-21 15:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 11:11 Jan Blunck
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 1/9] eal: define container_of macro Jan Blunck
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 2/9] ethdev: Helper to convert to struct rte_pci_device Jan Blunck
2016-12-20 15:38 ` Stephen Hemminger
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 3/9] drivers: Use ETH_DEV_PCI_DEV() helper Jan Blunck
2016-12-21 9:50 ` Shreyansh Jain
2016-12-21 9:57 ` Shreyansh Jain
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 4/9] virtio: Don't fill dev_info->driver_name Jan Blunck
2016-12-20 12:17 ` Ferruh Yigit
2016-12-20 12:40 ` Jan Blunck
2016-12-20 12:58 ` Ferruh Yigit
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 5/9] virtio: Add vtpci_intr_handle() helper to get rte_intr_handle Jan Blunck
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 6/9] virtio: Don't depend on struct rte_eth_dev's pci_dev Jan Blunck
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 7/9] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() Jan Blunck
2016-12-20 15:41 ` Stephen Hemminger
2016-12-21 15:35 ` Jan Blunck
2016-12-21 9:54 ` Shreyansh Jain
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 8/9] ethdev: Decouple interrupt handling from PCI device Jan Blunck
2016-12-20 11:11 ` [dpdk-dev] [PATCH v3 9/9] ethdev: Decouple struct rte_eth_dev from struct rte_pci_device Jan Blunck
2016-12-21 10:00 ` [dpdk-dev] [PATCH v3 0/9] Decouple ethdev from PCI device Shreyansh Jain
2016-12-21 15:12 ` Jan Blunck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALe+Z01S_Nw=pa0NieBgRdoKnWE+PeH-7F49pBPLTt53pTQYPA@mail.gmail.com' \
--to=jblunck@infradead.org \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).