From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 59AB110C83 for ; Wed, 21 Dec 2016 16:12:12 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id g23so31093720wme.1 for ; Wed, 21 Dec 2016 07:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LWIkfXlHUuvNdEXDl5STgFLueWqp43W+jSwPmvXuI5k=; b=IywTwMIP9hmMpZ1tJ60WnrZYzu8oY6Yysgz8nZ9mnQTAuCCzNN4I1TUrnP/r5HDe72 5T/ymfURgCZ1pHSLwOzElDVGd+QQzEi1V22LO9lZr1tZ4Mxf3I6YX44DIWtsRekhuTXB 1tASEQGBVtSQsKBSLoGvzQy7Vwsi7R5GNR5sWXgaaAPNnQFp3ozPCjF9BSCHCqyoGGNQ G723k/ZQlvf+lsPU+r5Q0Ntk/zxKkKcno1Vc53Tx4sbgvZ44iCc0QY8JJTCDOxo7hkFV 1wzRD0qCr00OH3x6OKI39cweilcWpQBj297/nSHHsN2jFh3BkJucMJDy5ltyDVfLSiFU bQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LWIkfXlHUuvNdEXDl5STgFLueWqp43W+jSwPmvXuI5k=; b=U+nTi83LmrLxPT2O2JZUHNAilez3pz8nFMrC6fKVrqijBuD8iIOyBkR3qMdn0RHrra Bm7grM9ngfpyVa1mOeQqlsMqCs9UV5U79OFlBZz/qZkalMniJYTSo9x42Kb+18WNx4e2 ezVSlEzeWZp3E4fB+f3MJrQIFwkJSgjbFmjZ9vGaaUPr1n4jvGamcMuGPVYhCnHzEcnn P8J3SLCeQhfmEtPPdNp6hcqASlWCX4Z6HWJxvC0/PielL+xTykKHJhqBAQIuFhPMr0tx y7+W6jp8/k7o4zJiRjEz3LffKxxUm38Df5YqdgqaDXnwEBcNza163v+uMUP5qTtg/LQo xqjA== X-Gm-Message-State: AIkVDXIT1fJDnYlaJOCoIuV28xOOEPphPE+dhYDeEyfi19FTRK19+LHkkHXro+6f4vcMA3fNJSlg5uD93lc5KQ== X-Received: by 10.28.66.194 with SMTP id k63mr7729313wmi.140.1482333131855; Wed, 21 Dec 2016 07:12:11 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Wed, 21 Dec 2016 07:12:11 -0800 (PST) In-Reply-To: <79676396-e867-2512-93c5-17fca4604ddf@nxp.com> References: <1482232315-21626-1-git-send-email-jblunck@infradead.org> <79676396-e867-2512-93c5-17fca4604ddf@nxp.com> From: Jan Blunck Date: Wed, 21 Dec 2016 16:12:11 +0100 X-Google-Sender-Auth: ai8dDtvezDGGxzbFFW-cpaH8hTE Message-ID: To: Shreyansh Jain Cc: dev@dpdk.org, David Marchand , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 0/9] Decouple ethdev from PCI device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 15:12:12 -0000 On Wed, Dec 21, 2016 at 11:00 AM, Shreyansh Jain wrote: > Hi Jan, > > > On Tuesday 20 December 2016 04:41 PM, Jan Blunck wrote: >> >> This is a repost of the series I sent in November. I've addressed >> Shreyansh's >> review comments about the PCI device users I've missed. >> >> Jan Blunck (9): >> eal: define container_of macro >> ethdev: Helper to convert to struct rte_pci_device >> drivers: Use ETH_DEV_PCI_DEV() helper >> virtio: Don't fill dev_info->driver_name >> virtio: Add vtpci_intr_handle() helper to get rte_intr_handle >> virtio: Don't depend on struct rte_eth_dev's pci_dev >> ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() >> ethdev: Decouple interrupt handling from PCI device >> ethdev: Decouple struct rte_eth_dev from struct rte_pci_device >> >> app/test/virtual_pmd.c | 4 +- >> drivers/net/bnx2x/bnx2x_ethdev.c | 13 +++--- >> drivers/net/bnxt/bnxt_ethdev.c | 21 ++++++---- >> drivers/net/bnxt/bnxt_ring.c | 11 ++--- >> drivers/net/bonding/rte_eth_bond_args.c | 12 +++++- >> drivers/net/cxgbe/cxgbe_ethdev.c | 4 +- >> drivers/net/cxgbe/cxgbe_main.c | 4 +- >> drivers/net/e1000/em_ethdev.c | 21 ++++++---- >> drivers/net/e1000/igb_ethdev.c | 52 +++++++++++++---------- >> drivers/net/e1000/igb_pf.c | 3 +- >> drivers/net/ena/ena_ethdev.c | 4 +- >> drivers/net/enic/enic_ethdev.c | 3 +- >> drivers/net/fm10k/fm10k_ethdev.c | 56 +++++++++++++------------ >> drivers/net/i40e/i40e_ethdev.c | 45 ++++++++++---------- >> drivers/net/i40e/i40e_ethdev.h | 4 ++ >> drivers/net/i40e/i40e_ethdev_vf.c | 39 ++++++++--------- >> drivers/net/ixgbe/ixgbe_ethdev.c | 67 >> ++++++++++++++++++------------ >> drivers/net/ixgbe/ixgbe_pf.c | 2 +- >> drivers/net/mlx4/mlx4.c | 2 + >> drivers/net/mlx5/mlx5_ethdev.c | 2 + >> drivers/net/nfp/nfp_net.c | 17 ++++---- >> drivers/net/qede/qede_ethdev.c | 18 ++++---- >> drivers/net/szedata2/rte_eth_szedata2.c | 28 +++++++------ >> drivers/net/szedata2/rte_eth_szedata2.h | 34 +++++++-------- >> drivers/net/thunderx/nicvf_ethdev.c | 7 +++- >> drivers/net/virtio/virtio_ethdev.c | 38 ++++++++--------- >> drivers/net/virtio/virtio_pci.h | 6 +++ >> drivers/net/virtio/virtio_user_ethdev.c | 1 - >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++- >> lib/librte_eal/common/include/rte_common.h | 20 +++++++++ >> lib/librte_eal/common/include/rte_pci.h | 6 +++ >> lib/librte_ether/rte_ethdev.c | 25 ++++++++--- >> lib/librte_ether/rte_ethdev.h | 9 +++- >> 33 files changed, 355 insertions(+), 229 deletions(-) >> > > Besides the MLX* and bnx2x compile errors (responses in individual patch > email), all other changes look fine to me. > > Either you can directly add my series ACK to v4 or, for ML record purpose, I > will do that once you post v4 - whichever way you prefer. > Shreyansh, Thanks for the review. I've added acks for the patches that you have review. I've broken out the changes a little bit better like Stephen did in his series. For these patches I haven't added your acks yet. Cheers, Jan