From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id B42522B97 for ; Tue, 18 Oct 2016 14:50:18 +0200 (CEST) Received: by mail-lf0-f44.google.com with SMTP id x79so354490580lff.0 for ; Tue, 18 Oct 2016 05:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eA+j6xiV1/Q7pkrsn4oNNkvoZ0WVXPr0luplIjKttBM=; b=vWIUd27I7eUDU7FtmUrjfz3JUaOwjtvyMKKdk4HkBHbGy+oHWutRzzS44UNAaEyP/E ZlkDy2ARna09nmM8VQGuWERBvFYluP7K2GJwbiIfQ5nLa+jJtSvprhG0j80xPnXYD42X uGUegmLFEXgMhCwqA0lhPcAu07RdWyMJka+dHhUltilPWzOiHTZylD1IXgr1/qLediT2 19iTEg/T/5tvp514Buf/WyzWlf8NSfQ3S7F+OGhi24xtz2Wq4F93nDyMxoLH/L0Bloe1 Fee2bQZfBEZw9+Ok+Ge4brGCx/SEEcGrtG1DAoMRkxmzFMy7NVOg4SbcTLruSAFBgB6e aITw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=eA+j6xiV1/Q7pkrsn4oNNkvoZ0WVXPr0luplIjKttBM=; b=fPDJ0QExoHEJB7mhHO51gKRuEWs8QYaQjQ8jIhrG3duT2zYpSZci/fwsEJcIA/SBg+ ak7ct321QgBiRA22jqeUDM8IwFTJELGYfIt60oQT+I9p9CUurhEdhZRwZ6CsDbkdW9mr nUNPec5JscikCCx0y8awh7ve5M6P1l4C8S7qQ+nh7VyjfDSxOfs4PEVI1lQKh4YXqjyi vaFa357VD1cSnimMqx5JfNoN+1RI1Q8CqyzGN7j0hYX4C0RynY2ICoOTi37n8/SFUtIe 1LU1loxXyFdk8vOdlnRmDigLRyGX0bWOOMLIKyoFAWC9NguVKQhDsuTWRFqyYqNphy1k jYNQ== X-Gm-Message-State: AA6/9RnEMg5PnKni6h8wCLjfeZpcdDn9+XuYhw0gAaFuVtwuzsRt32RA/yIl8VCyCmmKDact1WvKKMXwEe9nQg== X-Received: by 10.28.210.1 with SMTP id j1mr608457wmg.86.1476795017352; Tue, 18 Oct 2016 05:50:17 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.216.195 with HTTP; Tue, 18 Oct 2016 05:50:16 -0700 (PDT) In-Reply-To: <7677934.dvmb0F7Vh7@xps13> References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com> <7677934.dvmb0F7Vh7@xps13> From: Jan Blunck Date: Tue, 18 Oct 2016 14:50:16 +0200 X-Google-Sender-Auth: UN4xqhzoqTRhkDLqrMuwD5_z4O8 Message-ID: To: Thomas Monjalon Cc: "De Lara Guarch, Pablo" , dev@dpdk.org, "Mcnamara, John" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 12:50:19 -0000 >>From my understanding this is a massive API breakage. This forces all existing users of the virtual PMDs to change with zero benefit. Even if that isn't enough it also makes it impossible to switch between releases by recompiling. Can we please revert these changes and work on some aliasing support for the PMDs to fix it long term? Thanks, Jan On Fri, Sep 16, 2016 at 11:58 AM, Thomas Monjalon wrote: > 2016-08-24 22:37, Mcnamara, John: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara >> > >> > ... >> > >> > - $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained >> > + $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained >> >> >> I know that this is an existing issue but there shouldn't be a space in >> "/path/to/ file". Perhaps you could fix that (in a number of places) as part >> of this patch. You could probably leave out the "/path/to/" part altogether as >> it may be clearer, see below. >> >> Also, could you wrap the long code lines in the sections that you change at >> 80 chars using "\" to keep them on the page in the PDF docs, like: >> >> $RTE_TARGET/app/testpmd -c '0xf' -n 4 \ >> --vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \ >> -- --port-topology=chained >> >> Or without the path part: >> >> $RTE_TARGET/app/testpmd -c '0xf' -n 4 \ >> --vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \ >> -- --port-topology=chained > > Applied with above comments fixed and release notes updated, thanks.