From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 6350AFB6B for ; Tue, 20 Dec 2016 13:40:12 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id m203so24056070wma.3 for ; Tue, 20 Dec 2016 04:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=j88Bmt1XOuHBb+1u9gA+OOcAIRlo8lem8pkRFZee6zY=; b=LdH9g1Kth3/dcTaRASpdKQVVnuG58sTuOjpi8quGwePEOeDZs2IPW7BqsadjIqqjea P59zHbRFpBPAFHKzoo1gzXYtXC3FBxXlT1Dx3mPROWqUHAQpLhcW7p0FyeJQtetrMX6R k9rGKipG5rw/RqgwRrMW8a9Y1wA7kWv3FZMycqdQQzfpq+/8UiuBaLdEpK6lioUNfmZM di7LXpi62iztrA6R1KnL+mOwz7PkCUOaZDb6MlSx/0iGWDUES974bzNxDzqmcCQLqAHW 109jsfjftKXubvXr/PC3MlcVDENdZUhCcG1g7ur1tk2mBLwcOL5Na3ARjUYYgFzmFrvj xBWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=j88Bmt1XOuHBb+1u9gA+OOcAIRlo8lem8pkRFZee6zY=; b=gekavVVfs2JtuGJ6Vs7Fpmv7FkQt2rjDiZjLXio+GZzN3oWi5Zw0+GVA4S8z18atdH tKQUlkePH/3UwfGnLwsFeSPKgtPu4CjtuD8kuJ5Dj8b4sryvvqJLKhUcWveqVLBlFbWK OAm7kk7iAWd02MmZxxNkXqwenbaJDE0KcBJWdCkkS6FlJWsq5ULGmbZW5ASqLopMErAu 1Ncli3qgm1F8nJRXfdGiTCVltDASxj3R9f4A2P1cFCZ2ykkeO/FBCB3jFEuupe2mvIRJ RBSdtf8AubwBwoXcC1a3/Oui3SMVpTQQJWfRsNl83hn770mN4Kd7Qhm+M0IoL9oWBbb9 ipkA== X-Gm-Message-State: AIkVDXIvQWpjWga9wESSqEWjvzDVO5PX1tWoqWikew7E5dvMKE8uVMKLFgNhcv+It1FiPfGOOFMq3fT2NcK7Rw== X-Received: by 10.28.105.81 with SMTP id e78mr1845514wmc.140.1482237612124; Tue, 20 Dec 2016 04:40:12 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Tue, 20 Dec 2016 04:40:11 -0800 (PST) In-Reply-To: References: <1482232315-21626-1-git-send-email-jblunck@infradead.org> <1482232315-21626-5-git-send-email-jblunck@infradead.org> From: Jan Blunck Date: Tue, 20 Dec 2016 13:40:11 +0100 X-Google-Sender-Auth: zSdCP8-6Fi49g3r4nobtBdkB1Qs Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Shreyansh Jain , David Marchand , Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v3 4/9] virtio: Don't fill dev_info->driver_name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 12:40:12 -0000 On Tue, Dec 20, 2016 at 1:17 PM, Ferruh Yigit wrote: > On 12/20/2016 11:11 AM, Jan Blunck wrote: >> This is overwritten in rte_eth_dev_info_get(). >> >> Signed-off-by: Jan Blunck >> Reviewed-by: David Marchand >> --- >> drivers/net/virtio/virtio_ethdev.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index 079fd6c..741688e 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -1624,10 +1624,6 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) >> uint64_t tso_mask; >> struct virtio_hw *hw = dev->data->dev_private; >> >> - if (dev->pci_dev) >> - dev_info->driver_name = dev->driver->pci_drv.driver.name; >> - else >> - dev_info->driver_name = "virtio_user PMD"; >> dev_info->max_rx_queues = >> RTE_MIN(hw->max_queue_pairs, VIRTIO_MAX_RX_QUEUES); >> dev_info->max_tx_queues = >> > > > This has been already removed in next-net with following commit: > 7c6c1857358c ("net: remove dead driver names") Thanks. Do you want me to rebase against next-net and resend the series before continuing to review further?