From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jblunck@gmail.com>
Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65])
 by dpdk.org (Postfix) with ESMTP id 6F60B235
 for <dev@dpdk.org>; Fri, 30 Jun 2017 17:12:14 +0200 (CEST)
Received: by mail-wm0-f65.google.com with SMTP id j85so8509020wmj.0
 for <dev@dpdk.org>; Fri, 30 Jun 2017 08:12:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=/dQ7cvb7y8Q/AHn+ooIRvOlZVMtrA0DESCyHYFrelXE=;
 b=flof4ChjS2ZxAJ/YFcPKaoS8vDaENljpx6o1EeuXJWC9LMo3z9EVLxOxOYCqJVE+vt
 spTBZSmJBA9fngZ07+/KCvh7tvty52EhPLrRXYbgjEOMD7khihim2cz5szkoj2cJ6y6j
 GSPjCawFXA7Y9fzNnRezFNG3UgQ0G1l592K/q7EyBvcgrrsKOsU9MWnvRwykBznQT662
 KkDF7eaBrHAxcpxrkyQ+NF+HTBS+4ICV+tO94J73WoUHVn8IgLFZgN89elZuKooDhIDK
 fZ1CarKYyfvE3xq4PNiCR5PT1I6yjU2Qk2K1CS335GJrDhYLmqOaRvPoafV1Ao6gcZtK
 Rr0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=/dQ7cvb7y8Q/AHn+ooIRvOlZVMtrA0DESCyHYFrelXE=;
 b=tJ8C/spqgavcYdB/mao31X2nH+V22yTnW8lCWFYtuwrGA7YlYPJ/Xh3fpXyc5W3lEX
 pwG0P4O3uW9q81AaiIGkVv8vxSZ7RdI5q9MXLEneGY4cviMwTcifp8sn0WPKmwU5QJyi
 ELCWY8azENlYoyCnx7cN03yy+nhT9hLa2WZOMrBG11dHKATrZNZ7uAq9OeFvq/ZfbAM3
 b81UW9QVoNaOpHQGbKewB0KqkWkecs4yRQJrrvjtKfu4K6sZQIpPzZVizEbjCFfSiWtK
 h3f0O6x4ex3gwUEzeEHCXPa/mLpA7cZDJqW58K0XocJYkAAC5/L84jvi+wxBVs3KIP3x
 x9mA==
X-Gm-Message-State: AKS2vOxHZLNZz+PtPV/NkAFGFo7EU/7YGeIKELSCoqRWGnFi+j1gAsHH
 XYmbKxakeN9pW9NfmVB6BwcSmS/ZGw==
X-Received: by 10.28.213.135 with SMTP id m129mr6604882wmg.78.1498835534090;
 Fri, 30 Jun 2017 08:12:14 -0700 (PDT)
MIME-Version: 1.0
Sender: jblunck@gmail.com
Received: by 10.28.5.136 with HTTP; Fri, 30 Jun 2017 08:12:13 -0700 (PDT)
In-Reply-To: <2011189.8JlBii0GeG@xps>
References: <cover.1498577192.git.gaetan.rivet@6wind.com>
 <20170629182206.1072-1-jblunck@infradead.org>
 <20170629182206.1072-14-jblunck@infradead.org> <2011189.8JlBii0GeG@xps>
From: Jan Blunck <jblunck@infradead.org>
Date: Fri, 30 Jun 2017 17:12:13 +0200
X-Google-Sender-Auth: -HcYoFC6N9bamvAvq-kStZY-dqE
Message-ID: <CALe+Z026yU9PckW_=A+RS-HZ2Y31GSLFhWPnjJRH+tawNw6epg@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, =?UTF-8?Q?Ga=C3=ABtan_Rivet?= <gaetan.rivet@6wind.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v7 13/15] eal: add hotplug add/remove
	functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jun 2017 15:12:14 -0000

On Fri, Jun 30, 2017 at 2:54 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> It seems a function is missing in this patch:
>
> 29/06/2017 20:22, Jan Blunck:
>> +int rte_eal_hotplug_add(const char *busname, const char *devname,
>> +                     const char *devargs)
>> +{
>> +     struct rte_bus *bus;
>> +     struct rte_device *dev;
>> +     int ret;
>> +
>> +     bus = rte_bus_find_by_name(busname);
>> +     if (!bus) {
>> +             RTE_LOG(ERR, EAL, "Cannot find bus (%s)\n", busname);
>> +             return -ENOENT;
>> +     }
>> +
>> +     if (!bus->plug) {
>> +             RTE_LOG(ERR, EAL, "Function plug not supported by bus (%s)\n",
>> +                     bus->name);
>> +             return -ENOTSUP;
>> +     }
>> +
>> +     ret = bus->scan();
>> +     if (ret)
>> +             return ret;
>> +
>> +     dev = bus->find_device(NULL, cmp_detached_dev_name, devname);
>
> fatal error: use of undeclared identifier 'cmp_detached_dev_name'
>

Sorry. I'll make them bisectable with the next drop today.