From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 2BB932B9F for ; Fri, 23 Dec 2016 17:20:40 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id m203so42298719wma.3 for ; Fri, 23 Dec 2016 08:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=bXczkthxET65a1naBUrQ6+tlXTO/JwofnpQEtbCVMCs=; b=haiaQloqGWx8XxYCrtah/cx/aFPPMyaOPer08VgCcSMS1E71HdvwPUjrdt3OCJh1q2 gk5Rc8nov1qPGCaTLkDIlg4sfwtRPHACNlyK8g7pSv2p/6HanAj0VgfiyorYuzOIvLcw r+mvW5c+XHoCwLGtnMLf5JTRNwH5max7kVcrr7N0+cmSXJ7Fr2t66VrwaMK08HUuoLQQ Bc2Hc7AU4AcqBgThcpzDQvcVrsy4keSNURtXyhM1JhLEFQk2mjmGptErCuhjeX9wmblg hvpKIvAnn1foWJgk89wc4MVGS+wpnqltHOGRU42pMRgyirgwOD0Z/lqn6kpe8kQmBSkj QDCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=bXczkthxET65a1naBUrQ6+tlXTO/JwofnpQEtbCVMCs=; b=LLCz8n8FaHbQZSMjuNES7BHgRvwRTfhl9wm/P9aEFLNy22448Ym7Wlw7mskreyM5g2 YE5zOqGXai/NfuJM9ez5MdioYSFLBsvtltfJANPERdtWlqLFcpAsdxSUcwWQM35Jepu3 z4JRx8iDfAI7FK4EjSrcsL51N/N0cKWL/+gJ2o8eGHLL7mrOe0Rp6MnOxjmuYeTnF4s3 24b8nh3KplZO4rVBCuh8tYVsYCm43nGStuOGTAjr4jAx4/TcPlc2EFVuHcxo+hhJjkRy vwHPYS5i0wjpythtpK0MgqQmFAPkzQjyENYD9rvqBsTyCg6us7b6k/bYXusGkZ+TrGXj yMhQ== X-Gm-Message-State: AIkVDXJoMFDrB6kVNnwX9dtSYLQSZKb6xslpHq4C6LbnHJjzm5Ob+2mroqNpUmLZ900Ww+5voIVqnw9JxsxH9w== X-Received: by 10.28.105.81 with SMTP id e78mr15077650wmc.140.1482510039811; Fri, 23 Dec 2016 08:20:39 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Fri, 23 Dec 2016 08:20:39 -0800 (PST) In-Reply-To: <2185678.prfkkk662h@xps13> References: <1482508691-11408-1-git-send-email-jblunck@infradead.org> <1482508691-11408-21-git-send-email-jblunck@infradead.org> <2185678.prfkkk662h@xps13> From: Jan Blunck Date: Fri, 23 Dec 2016 17:20:39 +0100 X-Google-Sender-Auth: iqyKDk1Dw9rp7LkbWJTYZRfCxxk Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Shreyansh Jain , David Marchand , Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v5 20/20] ethdev: Decouple from PCI device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 16:20:40 -0000 On Fri, Dec 23, 2016 at 5:17 PM, Thomas Monjalon wrote: > 2016-12-23 16:58, Jan Blunck: >> +/** >> + * @internal >> + * Helper macro for drivers that need to convert to struct rte_pci_device. >> + */ >> +#define RTE_DEV_PCI_DEV(ptr) container_of(ptr, struct rte_pci_device, device) > > Do you prefer to rename to RTE_DEV_TO_PCI? I'm fine with that. > >> + struct rte_device *device; /**< Backing device for this device */ > > This comment looks strange. > shorten to just "Backing device"? Agreed.