From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jblunck@gmail.com> Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id F0954FB6C for <dev@dpdk.org>; Tue, 20 Dec 2016 13:48:04 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id m203so24095278wma.3 for <dev@dpdk.org>; Tue, 20 Dec 2016 04:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/BL+Dhc4XjCsaE+8IPyiMx4XSAJcZh/dFgCKH0J0hM0=; b=A0GhtGotwcpP2EBoOxdYqUrbIH8/kUrWUBfPgShbqHh+JJcusq+TE1WzA00h+FH1OB zHb22AV0bv/GSUlsg0uUd2w9rudmQeVfQDSrRwaPaVyx10ZPUKnLkckp3TVGuf4fETeV ugMawU6S+JZ1ZY9oR6ES1lfQVRKpNyjBWOyhXqfNuuZyB34LU9a5t0mwSU34WZmS4Qcn /3bH/Ind3qlhSiD7ru9B10p+yafHvwswpsJe9UYsxQop7aDid3FUU44Qmc41ItzdOkjX f+m1fZAg5LjK5Az+w2JBus0wtiV8ruq5NuwyS3ezKuLyDaTrY+ottdcFtniDCl+Qc5o9 irNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/BL+Dhc4XjCsaE+8IPyiMx4XSAJcZh/dFgCKH0J0hM0=; b=AOsG3odvkeTglCWJGblmpPFEFt8Qv7LmlkaVqGbAKUpghxS4I9WM0jwaxS/sr/Kf+9 4ZHsarXW62BzevTHr41nQlF4/hcLD2thaGJXMCwF700dQGYuPWtYosvK6yfQ4050SpRI 0CDAPCY2isaRYaFqQwcOZkUIUmArTsGEjVJo5f/eb8NYI43VRHWxHhjfiEKp8BBdP1jV mpMI3Owh6hSYM2XPkRKf1RhGYkNsUdMMCBAVsS47OLi0siLpowNNrLi4Bhmfr3Bqyshu hO6ngQo++hqLO+uKhRw86TcoQrjBJDfY269xjDU1z2ZNEBXm+jDN5pa26ik8mJsTg4mG WbQg== X-Gm-Message-State: AIkVDXI0hktkeEd2HF65MTJxpaycE9SGHqusykX9U9R5ZCxRysAJsEhzb9EwSDf6iNWsBvRd2l3avZrBY4umYg== X-Received: by 10.28.8.202 with SMTP id 193mr1709030wmi.101.1482238084625; Tue, 20 Dec 2016 04:48:04 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Tue, 20 Dec 2016 04:48:04 -0800 (PST) In-Reply-To: <20161219215944.17226-1-sthemmin@microsoft.com> References: <20161219215944.17226-1-sthemmin@microsoft.com> From: Jan Blunck <jblunck@infradead.org> Date: Tue, 20 Dec 2016 13:48:04 +0100 X-Google-Sender-Auth: 4aeFkIJTyfdmqamK-JjNq6rRNG0 Message-ID: <CALe+Z02gYZtk1cxjV20HYCb=tCnaVHsWPyrUYcK_kwsk1NKA5w@mail.gmail.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com> Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [RFC v2 00/13] Generalize rte_eth_dev model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 20 Dec 2016 12:48:05 -0000 On Mon, Dec 19, 2016 at 10:59 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > This set of patches generalize the ethernet device model sufficently > to support virtual, pci, and vmbus devices. > > All this is based on the XP principal of only building what is > necessary and no more than that. The rationale is NOT to rework the > DPDK to have same level of bus and parent information as the Linux > device model. This would be unnecessary, fragile and unnecessarily OS > dependent. > > Instead, this set of patches does the simple change of refactoring > so that the object relationship between ethernet (rte_eth_dev), > PCI (rte_pci_device) and generic (rte_device) is properly broken > apart. Yes, as I pointed out when reviewing the bus related changes the refactoring of the ethdev doesn't depend on the bus work to get merged first. I've sent a similar series in November already. I guess that is a sign that the review got stuck somewhere. Jan > It does make the simplifying assumption that the device driver knows > what type of bus it is on. For a future case where a device has to > be able to handle different bus families; then the device driver > can have multiple device drivers in one code base (like ixgbe PF/VF). > > > Jan Blunck (1): > eal: define container_of macro > > Stephen Hemminger (12): > ethdev: increase length ethernet device internal name > rte_device: make driver pointer const > eal: introduce driver type > pmd: remove useless reset of dev_info->dev_pci > ethdev: make dev_info generic (not just PCI) > e1000: localize mapping from eth_dev to pci > ixgbe: localize mapping from eth_dev to pci_device > i40e: localize mapping of eth_dev to pci > virtio: localize mapping from rte_eth to pci > broadcom: localize mapping from eth_dev to pci > ethdev: change pci_dev to generic device > hyperv: VMBUS support infrastucture > > app/test-pmd/config.c | 32 +++++++- > app/test-pmd/testpmd.c | 11 ++- > app/test-pmd/testpmd.h | 32 ++++---- > app/test/test_kni.c | 39 +++++++-- > app/test/virtual_pmd.c | 4 +- > doc/guides/rel_notes/deprecation.rst | 3 + > doc/guides/rel_notes/release_17_02.rst | 10 +-- > drivers/net/af_packet/rte_eth_af_packet.c | 1 - > drivers/net/bnxt/bnxt_ethdev.c | 24 +++--- > drivers/net/bnxt/bnxt_ring.c | 16 ++-- > drivers/net/bonding/rte_eth_bond_args.c | 12 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 1 - > drivers/net/cxgbe/cxgbe_ethdev.c | 2 +- > drivers/net/cxgbe/cxgbe_main.c | 5 +- > drivers/net/e1000/e1000_ethdev.h | 2 + > drivers/net/e1000/em_ethdev.c | 50 +++++++----- > drivers/net/e1000/igb_ethdev.c | 99 ++++++++++++----------- > drivers/net/e1000/igb_pf.c | 4 +- > drivers/net/ena/ena_ethdev.c | 2 +- > drivers/net/enic/enic_ethdev.c | 2 +- > drivers/net/enic/enic_rxtx.c | 2 - > drivers/net/fm10k/fm10k_ethdev.c | 90 +++++++++++++-------- > drivers/net/i40e/i40e_ethdev.c | 77 +++++++++++------- > drivers/net/i40e/i40e_ethdev.h | 3 + > drivers/net/i40e/i40e_ethdev_vf.c | 59 ++++++++------ > drivers/net/ixgbe/ixgbe_ethdev.c | 120 ++++++++++++++++------------ > drivers/net/ixgbe/ixgbe_ethdev.h | 3 + > drivers/net/ixgbe/ixgbe_pf.c | 4 +- > drivers/net/null/rte_eth_null.c | 1 - > drivers/net/pcap/rte_eth_pcap.c | 1 - > drivers/net/qede/qede_ethdev.c | 24 +++--- > drivers/net/qede/qede_ethdev.h | 4 + > drivers/net/ring/rte_eth_ring.c | 1 - > drivers/net/virtio/virtio_ethdev.c | 95 +++++++++++++++------- > drivers/net/virtio/virtio_user_ethdev.c | 2 +- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 +- > drivers/net/xenvirt/rte_eth_xenvirt.c | 1 - > lib/librte_eal/common/Makefile | 2 +- > lib/librte_eal/common/eal_common_devargs.c | 7 ++ > lib/librte_eal/common/eal_common_options.c | 38 +++++++++ > lib/librte_eal/common/eal_internal_cfg.h | 3 +- > lib/librte_eal/common/eal_options.h | 6 ++ > lib/librte_eal/common/eal_private.h | 5 ++ > lib/librte_eal/common/include/rte_common.h | 20 +++++ > lib/librte_eal/common/include/rte_dev.h | 17 +++- > lib/librte_eal/common/include/rte_devargs.h | 8 ++ > lib/librte_eal/common/include/rte_pci.h | 1 + > lib/librte_eal/common/include/rte_vdev.h | 1 + > lib/librte_eal/linuxapp/eal/Makefile | 6 ++ > lib/librte_eal/linuxapp/eal/eal.c | 11 +++ > lib/librte_ether/rte_ethdev.c | 114 ++++++++++++++++++++++++-- > lib/librte_ether/rte_ethdev.h | 38 +++++++-- > mk/rte.app.mk | 1 + > 53 files changed, 776 insertions(+), 343 deletions(-) > > -- > 2.11.0 >