From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jblunck@gmail.com> Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id C6EC13257 for <dev@dpdk.org>; Wed, 12 Jul 2017 11:25:34 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id k67so25137355wrc.2 for <dev@dpdk.org>; Wed, 12 Jul 2017 02:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=68NpY6rCuzhmuaJJR8vyPzbMuna56cgwIo9sghDFCLY=; b=rBEspNBKgH14kZ/63Nx1I9VdOuGXaZxRsa+ZznsueTR6NuOs91JMk3oW/xcPnxnCu+ k+IlYUtHftFuyQbFIMQPe0TsljgsyX8ZK8K1Hn1cuB5l4sKCqRLZKZ20HbNTxRLi7gNN wzIx+8Yd0O4p8/CCW4z6yoKSXKvLwJP9UKRt/w0ePDrLaKriUYcXdn+IFXMrsrDY6Cet 1BRETKMm/6/VW8XH1ue+VxoCdAIMlZ1Dv21SL/vfzBUwwBpKww07uftg7ApMzP0dpr5q bcmz+j5ZjNAK0dsbentrxrRLu1Sccp2ib7SYeL5GTePb5S5mxnSO2yLRggGXqQmar9up kzSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=68NpY6rCuzhmuaJJR8vyPzbMuna56cgwIo9sghDFCLY=; b=HZuSJSfFA8Jry8JrOdvDdejX+epq0oSH6LJiIpbcqA5pcRfTitmp8x408obGarHjlR v06saT2U/kAESvSBGPrt5SqzcORn4FCzBhsZdXuPsw2WGtX9rYH5r4H0vVHCc7SaMKVP Zd8JkhhAJUuYZ9/nwP5jW1YJfZAcYpbPzjI5tBuJieghUYZNBDbttWAlwfEmMzJpIKee 5yGL4/P9PmsemI8ukC8YqsxMNIN3xCpgKDrZ6jCOtgMDjdpekEBt7HXu7rNS29jj9XmC eNV42W/02v6JkuB1vXfuOchEiJfbJE+E4SWk5rgbKY+6hwy5UdJ9PlFeYEOizNoCpFhI TFAQ== X-Gm-Message-State: AIVw112B5CKlJq+7XA2pCrCDlMKBhYDeJCPwyfDGTb03r9FSiTGlQ8X2 d1XhjqilA2VpwYmhYif0wBEXiLxDaQ== X-Received: by 10.28.229.207 with SMTP id c198mr1828997wmh.108.1499851534364; Wed, 12 Jul 2017 02:25:34 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Wed, 12 Jul 2017 02:25:33 -0700 (PDT) In-Reply-To: <25860205.Dk19R5WIvi@xps> References: <20170711232512.54641-1-jblunck@infradead.org> <3538101.lyQKiAFUpY@xps> <CALe+Z02FKn+PnYb1kZa9pHiZ6AjttK=LHREEjez1gwueyxwevw@mail.gmail.com> <25860205.Dk19R5WIvi@xps> From: Jan Blunck <jblunck@infradead.org> Date: Wed, 12 Jul 2017 05:25:33 -0400 X-Google-Sender-Auth: 8ece537flZ-RgarLnDs83E99VZg Message-ID: <CALe+Z02sX_2J=5nBswvaMfheZkb--UWiM-Wy8BP2F_LXSSxmMA@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev <dev@dpdk.org> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 00/13] devargs fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 12 Jul 2017 09:25:35 -0000 On Wed, Jul 12, 2017 at 4:50 AM, Thomas Monjalon <thomas@monjalon.net> wrote: > 12/07/2017 10:09, Jan Blunck: >> On Wed, Jul 12, 2017 at 3:29 AM, Thomas Monjalon <thomas@monjalon.net> wrote: >> > 12/07/2017 01:24, Jan Blunck: >> >> The changes to enum rte_devtype that got merged into 17.08-rc1 are breaking >> >> API without prior notice. This series is reworking the rte_devargs changes >> >> in a way hopefully compliant to the new failover PMD and still keeping API >> >> compatible with earlier releases. >> > >> > I have not reviewed this series yet. >> > I have just seen that your are introducing "bus=" in devargs. >> > Do you keep compatibility with old scheme without "bus=" option? >> > We need to keep this compat for 17.08 and deprecate it for 17.11. >> >> The old scheme which got introduced with 17.08-rc1 is using the >> concatenation of bus name, a one character separator and the device >> name: >> >> rte_eal_devargs_parse( "busname*devname,args" ) > > No I was talking about the real old scheme without any bus name :) > Yes, the first patches of the series are fixing the API breakage introduced by renaming the enum rte_devtype enumerators in 17.08-rc1. >>From what I can tell the rte_eal_devargs_add() function should be API compatible with 17.05 again after applying this.