From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 47D002C49 for ; Fri, 10 Mar 2017 08:20:38 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id u132so820704wmg.1 for ; Thu, 09 Mar 2017 23:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=blTscY1m9Io6REKfnz+lE9D7lnYsiFILERPWbbk1hk0=; b=YwirsgmJZwcheCbPAbE4DUlvNp9nvaIznV1rpipuKHq6xVgWC4eLT5XQeg2u410X2h kxsTg84Rj2oaB3RkYQwVjtlsLj85HAakI9nUQ3ciY00Vb2z86/YAsxziV5YbpxeMfmEo poV+8cVH4NHaPklxq6hihbLzRYuGe96RFD8svsnA0jw8vRnQr0vUZJua3vB5BonW3isK 1ulm+7MK43lh/Xl09Fds6eXq2D/RZXzDQk91BZZjHkIJZS31zZnk5uPbL0r3dE199/sQ I+ehexBFj6HtWE68dXXgbdgxcE5EdbAxxzYgUTvC5ITorbAg6LORHoZfU8SCax2A0OMJ FbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=blTscY1m9Io6REKfnz+lE9D7lnYsiFILERPWbbk1hk0=; b=l9qWVdpfsipkFL1Q76XVLYG8YJx7OsOZTioywYnakSg8LqU9Biw2ELLYoP5CE9sHuy RllIsNq+iDQ4QucPWbUrPttUECV3QtCp8kV/GC4BREfF4Q7dpONrXBuzjwifNSdKG7eE o12uQrsUn/+tYB+L7VUpnKx/Jq/apUytMNn7lEgeto6htvkmQziXs8XtDU+FCJb3wUZV DXbi3lKeE8oZTE9np+/woQPHd3ZEr4NnKDDgoUOAvyMupVjB5Uwb5T2X0ZdybtHSgg60 gjBHiDovOcq7561Aa3BjofSzFquCFe7ZTgDNdb6t6Ui6HaKMOuu9csbEsZZ50WiW5bzS DOzQ== X-Gm-Message-State: AFeK/H36Qw7pK1HHBryZxtZ8Jt9vaxo48v5x64czkm1HRfRCV56eEWaMoZIoezpcDadP1RlivO8DQdSA1C7CcA== X-Received: by 10.28.135.82 with SMTP id j79mr1019003wmd.19.1489130437932; Thu, 09 Mar 2017 23:20:37 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.211.20 with HTTP; Thu, 9 Mar 2017 23:20:37 -0800 (PST) In-Reply-To: <48d78603-3ff3-cdf2-d620-dc62cb6b88b5@nxp.com> References: <1488794430-25179-1-git-send-email-jblunck@infradead.org> <1488794430-25179-4-git-send-email-jblunck@infradead.org> <48d78603-3ff3-cdf2-d620-dc62cb6b88b5@nxp.com> From: Jan Blunck Date: Fri, 10 Mar 2017 08:20:37 +0100 X-Google-Sender-Auth: pim0XcpL1SZYg81KfOndAlDCP6Q Message-ID: To: Shreyansh Jain Cc: dev Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 03/38] net/nfp: use library function for DMA zone reserve X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 07:20:38 -0000 On Fri, Mar 10, 2017 at 8:03 AM, Shreyansh Jain wrote: > On Monday 06 March 2017 03:29 PM, Jan Blunck wrote: >> >> -/* Creating memzone for hardware rings. */ >> -static const struct rte_memzone * >> -ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name, >> - uint16_t queue_id, uint32_t ring_size, int >> socket_id) >> -{ >> - char z_name[RTE_MEMZONE_NAMESIZE]; >> - const struct rte_memzone *mz; >> - >> - snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d", >> - dev->driver->pci_drv.driver.name, >> - ring_name, dev->data->port_id, queue_id); >> - >> - mz = rte_memzone_lookup(z_name); >> - if (mz) >> - return mz; >> - >> - return rte_memzone_reserve_aligned(z_name, ring_size, socket_id, >> 0, >> - NFP_MEMZONE_ALIGN); >> -} >> - >> > > This change is not part of the eth_driver removal process. Isn't it? > > I would suggest this should be a separate series all together. This is > valid for Patch 0004 as well. It is removing a dependency on eth_driver (see dev->driver->pci_drv.driver.name). Therefore even if I separate it this series would depend on it. Thanks for reviewing, Jan