From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id ADC785A6E for ; Sun, 9 Jul 2017 12:56:26 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id z45so18284555wrb.2 for ; Sun, 09 Jul 2017 03:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jNUwaj+plJAY62O9gbuXYJgqVHB3WxL/Rk9BibUxxEQ=; b=NelArWzIBPfObwm9mIel6Jz7gFDeBVEy5R/fQ6KoHxVzOOufpU4ke1iElUiItytDbf XDZNZdxbsFwTTbrjRovD45sBu/0cUFujed0d4wY75oZWGjpuz7Ags4bBSI42B5lm4DiQ zvJUB20WiBpIS63dBq6Offz178aOmUD8BefWFTIMZl6n//8lBFXHRfvZy04/A0WNZxCH 3yYkgBTOjMGcqf24p/yqqENUGHBeZGHkhxZJXI/M4G9xlPflmLaCcWpPOVYfCIUecVkV /M0v9iz83e/Lo9LzQ2f8AsMoJ1Ca+P2iQ6vsyBIkyVArRfL3VPOQYFherotyfoyHBKaN eu8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jNUwaj+plJAY62O9gbuXYJgqVHB3WxL/Rk9BibUxxEQ=; b=k9YqSoWkrMdVN+TeVi22FeScqL3nw5HXbcZCiWqqOufCLK8AS3IOUPiBVU8oZcL+jH YXAJT/h+xWPHxPyB2omIb5UZxlAvgaEHg/ulOHA6QSuYKFxzSwUCu7lyXz75wrAyrTMR dtyV0VVyB/yRFeWWZzaCo13I+vhjo2D3ysrvqX4fImSpr5VnRmiwAG59sDX0q26Vr/D5 jEtaljxmhptLsf5jDSqa/JXuP+WJr4dtZYkbFIMCMQY2PgrWd6rv6ZiRmW4M+DI5sYwm uIR/QJDMTdzoa19F7GkmymvFIAHjFQfo2n7ou0DtToR0r3G50RFjXNYM5qrh6QO5rH+1 EBJw== X-Gm-Message-State: AIVw112+1rMyISXgAMpqaGHFV4W6BaF3Khxdwwd/LUj5F/e+3K1m9aQk fM8cB4hcYLySNlHJuK9ta73sS2aRZA== X-Received: by 10.28.238.219 with SMTP id j88mr4472278wmi.33.1499597786286; Sun, 09 Jul 2017 03:56:26 -0700 (PDT) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.45.210 with HTTP; Sun, 9 Jul 2017 03:56:25 -0700 (PDT) In-Reply-To: References: <20170709092847.13339-1-jblunck@infradead.org> <20170709092847.13339-2-jblunck@infradead.org> <12210751.V8za9RMinW@xps> From: Jan Blunck Date: Sun, 9 Jul 2017 06:56:25 -0400 X-Google-Sender-Auth: _MWCfwKA0VkrOi8neKgtL69AFxY Message-ID: To: Thomas Monjalon Cc: dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 10:56:26 -0000 On Sun, Jul 9, 2017 at 6:46 AM, Jan Blunck wrote: > On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon wrote: >> 09/07/2017 11:28, Jan Blunck: >>> This is going to get cleaned up in future releases so lets not expose >>> this API unnecessarily. >>> >>> Signed-off-by: Jan Blunck >>> --- >>> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map >>> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map >>> @@ -211,7 +211,6 @@ DPDK_17.08 { >>> EXPERIMENTAL { >>> global: >>> >>> - rte_eal_devargs_parse; >>> rte_eal_hotplug_add; >>> rte_eal_hotplug_remove; >> >> We need to expose it temporarily as experimental in order to let >> the failsafe driver calling it. >> When reworked in 17.11, this function or an equivalent should allow >> failsafe (and maybe bonding) to parse slave declaration. > > There is no need for the failsafe PMD to parse it to a rte_devargs > because it can just pass the string to the hotplug API. Just in case it isn't clear enough: the failsafe PMD is using the rte_devargs structure to get the bus name. The bus name is explicitly given in the hotplug API. There is really no need to deal with rte_devargs here.