From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0DFB45650; Fri, 19 Jul 2024 05:23:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE0A5402BE; Fri, 19 Jul 2024 05:23:53 +0200 (CEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id A45D540267 for ; Fri, 19 Jul 2024 05:23:51 +0200 (CEST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-42725f8a789so12015e9.1 for ; Thu, 18 Jul 2024 20:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721359431; x=1721964231; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y67j/jy3MumBzTUPsJmZR8HjINzGa94vF5YFCTB3R94=; b=z7gVtC22dyHsV7r0y11S+weie/RQ947WbBcIzlo1BkjjI7Ww/xSCBLKsxOfZLKNRSi qAi9lm9Iz3BzNJg3M4vqmm1icGgdnH7d+u7kXr84vD1kKD0aQXlmF8eIgbQBa9EK8n4y u/ICFkjay5hDLhxgMqxuiHpWAV6MQ5Zy8t1nNmFjze+QJySJtbIY4GLEkGLay4eXsP5E QksfLmyCrmEOSQAb3LTTZbt93Qu3KAJt724+/NSiHA+fkUWk5FWjzxZrk866AXuo/frB PcpUY3Vbd8caK/UtN90ckC0AE9Yud8AeIgrIrtyIYxbDcvEPxo7JUNq5hc5HbyJ+OR6i +xoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721359431; x=1721964231; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y67j/jy3MumBzTUPsJmZR8HjINzGa94vF5YFCTB3R94=; b=tESjh2LLaOg1HyBVy7fWu3645yc2nr7zAjf4up+r29PQaCti6ZxvhOvvYRCRRhIE2o Rbk1WIs54VLhTgT0loI1qc2b6EbMH2SN6hZ+GGFG3p7+CF6CbNGWv7s8iTTwZ7ekLWzM zcmqA7/Q/u0ZGKE78BqwumsEbQz+OkIU5Vx93uDS95S8/fd3sT0WmtYi+sHirhS4LuUh JAVjR6zAtb59dG99Uaxtj+kUSjEmiqSaJGa+bQegNyvmN1gcZgkH2r3mFS8R8puUysys xoo0ULCWJvMYwIlgJ5Cy8LIR34bBe/4cgcnoxwt3fGANSV00VC6Zs3gHqVsNmBi+S1lQ KYmQ== X-Forwarded-Encrypted: i=1; AJvYcCV7RhiyIu/zGBtIigo9pCTiNkUV4JngyhAtJTCRZwUaV/uDsOrR7aAiEa4aNg6HnTBXgDCdEstrV+GN72s= X-Gm-Message-State: AOJu0YyiYKJRaAnVBV57a1pzRRVyZhx8hhJCPskznb23x1oYmixBDJia 7fsYWcJN8LPZGV8A/7eoP+1yCqIq1nkfb/Kf0Hj1CoOTkL6cwjoGPr/6lC8vuGwA8jwFaRwyg+F zp/dxIwph+fNxNCvV4Uo40nGHlMFSctIHPq5cD1q8g+V6OUhT1kbK X-Google-Smtp-Source: AGHT+IGIiH2BZ1jBJBWGroUvyps3DHDGILO924pDKNW7Xx3JlZyk7pAcbU2A/ksWhu8AlREPuxJcfjarZrx4qOWW3Lc= X-Received: by 2002:a05:600c:3b05:b0:421:7caf:eb69 with SMTP id 5b1f17b1804b1-427d5b4607cmr634815e9.4.1721359431030; Thu, 18 Jul 2024 20:23:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joshua Washington Date: Thu, 18 Jul 2024 20:23:40 -0700 Message-ID: Subject: Re: [PATCH] net/gve: Update Rx/Tx functions for RTE_PROC_SECONDARY To: Tathagat Priyadarshi Cc: jeroendb@google.com, rushilg@google.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org My ack might have been a bit premature. This patch seems to have a number of style errors, and does not seem to apply to HEAD of dpdk-next-net. See http://dpdk.org/patch/142498 for more detail. The code supplied in the patch does not seem to have any indentation. Please note that DPDK uses tabs (assumed to take up 8 spaces for the purposes of wrapping long lines) instead of spaces. The style guide can be found at https://doc.dpdk.org/guides/contributing/coding_style.html. The dpdk-next-net repository can be found at http://git.dpdk.org/next/dpdk-next-net.