From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC1D945B61; Fri, 18 Oct 2024 01:00:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6FA440268; Fri, 18 Oct 2024 01:00:05 +0200 (CEST) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id B0CA04021E for ; Fri, 18 Oct 2024 01:00:03 +0200 (CEST) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-37d6ff1cbe1so1113810f8f.3 for ; Thu, 17 Oct 2024 16:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729206003; x=1729810803; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s7hRWuTvWUOUgnNW5/SBR4OzwYYfUdT7wSZ5FXkJXAc=; b=JlzN4bDZPc8LudddP+TaFhjB0gK8cYVJXBDBaYaLNgjn91DNb1UgQCAuGdWbM75s2l 2fioW+UpV8VL6At715SBctr9Y3uaKkF7vDmRtArwzi+MhTNXyeEh2GgNWszb9ofsfUgg +qvHN2JVCFgmFeMyg4KTjJagpt8KzYfMhYm/HKOTa7FNgAt+g1nnWy2xLH7bgIX4oBZp v2LFZkaJfXmu2x44FI1uPqayQ1i05UDrfXvwDzk56aOUgPWdHQ2Gl4BB6rJAUP7Q5f5+ tfPLXxv/Lxkko46X5j1uk0lx1mu/rCO1U1DI5n80AhgZYtrny3rd7SLxnrs6Vxmn4iTI EFZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729206003; x=1729810803; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s7hRWuTvWUOUgnNW5/SBR4OzwYYfUdT7wSZ5FXkJXAc=; b=Y6CjI2khr7LhJi2pPYOeL9kiAe00eLULUxnlZAUZ2o8bWJiE8dk78/LXzi18/8tC6H LJt2+uyMVICrn/7j+sZzrHElCPx90zPq7CA4AI3rPGUpBXEfqdp7JNATAuJWz1CqYTq/ jdUZtQUHrPfZT6yrOCiIrstnogY6aBdIurHl5+0gm8J8aXcNNHQXmDcUSyVC74EZ8w8f Ti0WdG5nfu087m9B0x9AVS3bZkLtnHr1UO7Gzi1Suv+yw+G1y2NKNySyuOWoNxIulnw4 8JdyHQVUW8GYAinjVb46XosdJjpRmHCZVsz2QdDKuxOKRWjOURii7qUYJZykhoCFQZuw OKRA== X-Forwarded-Encrypted: i=1; AJvYcCVfPpskiBrhiLnEeIgV3+yw7HNCIBVWDS3N2ChvP01onH9u4tAkziJEBdYTPlm0BGNwgNs=@dpdk.org X-Gm-Message-State: AOJu0YxsY+atnNvQfRDajr8t0mWv1Iy7b1aaADWVB0awqoMObqxj1qLU 6dAysrFzjedJJY8UvQ0WSwvBDkL4gNypCDIrQvH7Ny/2Ow/1+PaHkTZUzcn8k6TDx/l+MwKjOiD Pc5KXdx3251w1l75krfvFvXKgTo63wHPbQhlD X-Google-Smtp-Source: AGHT+IEZyHUuugQpR6hG27ZWhdhjwjQBAnt0le8N1w2JZ68K/79e+vcrTazelOzJ1YhYml3vQbUhbZ/rtOms6OxnK8o= X-Received: by 2002:a5d:63d2:0:b0:37d:4c40:9ee with SMTP id ffacd0b85a97d-37eb487c25amr261403f8f.42.1729206003122; Thu, 17 Oct 2024 16:00:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joshua Washington Date: Thu, 17 Oct 2024 15:59:51 -0700 Message-ID: Subject: Re: Build issue with Fedora Rawhide To: David Marchand Cc: Jeroen de Borst , Rushil Gupta , dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, I have a fix that changes all typedefs in gve_osdep.h to #defines. It should be going out shortly. On Thu, Oct 17, 2024 at 5:12=E2=80=AFAM David Marchand wrote: > > Hello guys, > > I am not clear if this issue is new (and what caused it), but > compilation fails on Rawhide for the net/gve driver (see below for the > log). > > Afaics, Intel drivers wrapped __le16 types (and friends) using macros > (example: https://git.dpdk.org/dpdk/tree/drivers/net/i40e/base/i40e_osdep= .h#n47), > and I suspect it was to avoid such conflicts. > > Can you send a fix please? > > [ 224s] FAILED: drivers/libtmp_rte_net_gve.a.p/net_gve_base_gve_adminq.c= .o > [ 224s] cc -Idrivers/libtmp_rte_net_gve.a.p -Idrivers -I../drivers > -Idrivers/net/gve -I../drivers/net/gve -I../drivers/net/gve/base > -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config > -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include > -I../lib/eal/linux/include -Ilib/eal/x86/include > -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common > -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log > -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry > -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf > -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter > -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev > -I../drivers/bus/vdev -fdiagnostics-color=3Dalways > -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -std=3Dc11 -O3 > -include rte_config.h -Wcast-qual -Wdeprecated -Wformat > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings > -Wno-address-of-packed-member -Wno-packed-not-aligned > -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE > -fcommon -Werror -fPIC -march=3Dcorei7 -mrtm -DALLOW_EXPERIMENTAL_API > -DALLOW_INTERNAL_API -Wno-format-truncation > -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.gve -MD -MQ > drivers/libtmp_rte_net_gve.a.p/net_gve_base_gve_adminq.c.o -MF > drivers/libtmp_rte_net_gve.a.p/net_gve_base_gve_adminq.c.o.d -o > drivers/libtmp_rte_net_gve.a.p/net_gve_base_gve_adminq.c.o -c > ../drivers/net/gve/base/gve_adminq.c > [ 224s] In file included from ../drivers/net/gve/base/../base/gve_desc.h= :11, > [ 224s] from ../drivers/net/gve/base/../base/gve.h:9, > [ 224s] from ../drivers/net/gve/base/../gve_ethdev.h:13= , > [ 224s] from ../drivers/net/gve/base/gve_adminq.c:6: > [ 224s] ../drivers/net/gve/base/../base/gve_osdep.h:41:20: error: > conflicting types for =C3=A2=E2=82=AC=CB=9C__be64=C3=A2=E2=82=AC=E2=84=A2= ; have =C3=A2=E2=82=AC=CB=9Crte_be64_t=C3=A2=E2=82=AC=E2=84=A2 {aka =C3=A2= =E2=82=AC=CB=9Clong > unsigned int=C3=A2=E2=82=AC=E2=84=A2} > [ 224s] 41 | typedef rte_be64_t __be64; > [ 224s] | ^~~~~~ > [ 224s] In file included from /usr/include/linux/sched/types.h:5, > [ 224s] from /usr/include/bits/sched.h:60, > [ 224s] from /usr/include/sched.h:43, > [ 224s] from /usr/include/pthread.h:22, > [ 224s] from ../lib/ethdev/ethdev_driver.h:17, > [ 224s] from ../drivers/net/gve/base/../gve_ethdev.h:8: > [ 224s] /usr/include/linux/types.h:36:25: note: previous declaration > of =C3=A2=E2=82=AC=CB=9C__be64=C3=A2=E2=82=AC=E2=84=A2 with type =C3=A2= =E2=82=AC=CB=9C__be64=C3=A2=E2=82=AC=E2=84=A2 {aka =C3=A2=E2=82=AC=CB=9Clon= g long unsigned > int=C3=A2=E2=82=AC=E2=84=A2} > [ 224s] 36 | typedef __u64 __bitwise __be64; > [ 224s] | ^~~~~~ > [ 224s] ../drivers/net/gve/base/../base/gve_osdep.h:45:20: error: > conflicting types for =C3=A2=E2=82=AC=CB=9C__le64=C3=A2=E2=82=AC=E2=84=A2= ; have =C3=A2=E2=82=AC=CB=9Crte_le64_t=C3=A2=E2=82=AC=E2=84=A2 {aka =C3=A2= =E2=82=AC=CB=9Clong > unsigned int=C3=A2=E2=82=AC=E2=84=A2} > [ 224s] 45 | typedef rte_le64_t __le64; > [ 224s] | ^~~~~~ > [ 224s] /usr/include/linux/types.h:35:25: note: previous declaration > of =C3=A2=E2=82=AC=CB=9C__le64=C3=A2=E2=82=AC=E2=84=A2 with type =C3=A2= =E2=82=AC=CB=9C__le64=C3=A2=E2=82=AC=E2=84=A2 {aka =C3=A2=E2=82=AC=CB=9Clon= g long unsigned > int=C3=A2=E2=82=AC=E2=84=A2} > [ 224s] 35 | typedef __u64 __bitwise __le64; > [ 224s] | ^~~~~~ > > > > -- > David Marchand > --=20 Joshua Washington | Software Engineer | joshwash@google.com | (414) 366-442= 3