Re: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain

[Joshua Washington <joshwash@google.com>]

On Wed, Jul 31, 2024, 09:37 Tathagat Priyadarshi
<tathagat.dpdk@gmail.com> wrote:
>
> The EOP bit was not set for all the packets in mbuf chain
> causing packet transmission stalls for packets split across
> mbuf in chain.
>
> Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
> Signed-off-by: Varun Lakkur Ambaji Rao <varun.la@gmail.com>
>
> Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
> ---
>  drivers/net/gve/gve_tx_dqo.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
> index a65e6aa..579b8d6 100644
> --- a/drivers/net/gve/gve_tx_dqo.c
> +++ b/drivers/net/gve/gve_tx_dqo.c
> @@ -126,6 +126,7 @@
>                         txd->pkt.dtype = GVE_TX_PKT_DESC_DTYPE_DQO;
>                         txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id);
>                         txd->pkt.buf_size = RTE_MIN(tx_pkt->data_len, GVE_TX_MAX_BUF_SIZE_DQO);
> +                       txd->pkt.end_of_packet = 0;

Please also update checksum offload for each mbuf.
>
>
>                         /* size of desc_ring and sw_ring could be different */
>                         tx_id = (tx_id + 1) & mask;
> --
> 1.8.3.1
>

Thanks for all of the contributions! Let's try to get this applied to
stable release as well.