From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 442E845705; Wed, 31 Jul 2024 22:30:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3378B4067E; Wed, 31 Jul 2024 22:30:44 +0200 (CEST) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mails.dpdk.org (Postfix) with ESMTP id D7781400D5 for ; Wed, 31 Jul 2024 22:30:42 +0200 (CEST) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-427fc9834deso88495e9.0 for ; Wed, 31 Jul 2024 13:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722457842; x=1723062642; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7ASvtvDU2KVkPP+H85DsMoUeauQ40dXeVHXT8Uhk4jY=; b=388KmWjo1PAC6tK+iqmonL3fnz18EdV1FXvKgrHcZ0mxC7PFgEY+muanAzHGc+zKFe Ub8TGcf2AKiOIAD/Ac3lNHbOksz08co06ab+1t/DKdOv2eQYPyfai7Bf2nkpR/C1627N aFyre9C4qu3vhKMK3ssdRTeZM6P7347ayY6vXtOBv03hQ64eepFgx0U2w7aVJSMLL9kk tuOgqk8bgT+QybiWmNlsAWwM+qBDModYhMiOtD1kT10anHLjIa/gbnlIyXpIDIFDoZYA yS7yx7NFxRaVcXDR8YHaZUQUKkgGHGi80+76rXiC/FjGBUcOdejbNlkDAPhbb28U25bK XjWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722457842; x=1723062642; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7ASvtvDU2KVkPP+H85DsMoUeauQ40dXeVHXT8Uhk4jY=; b=eWbANXiIZ0hE9b6QjbPipip9gb/luRliBdAzCroGvIcVes1lLHlhCL/iEVtOb2du/l +2jYNWXfWvTuWFdiqxBtlUoVnYLRR5p1jZ+jsrFvK9P2hvDJnHFiuHFL8gfQju0ha191 v5Wg8uEK0fhTRrdUGyYY/T7YRwfq7XgYy3Tp19lvMivTKkPBk4XNoZwJrXA9hC1fm2aI SIsLRpAIH6SFLz+6Qxg6+0YEIKj2ap0GXtu8dYSVikGVIED9/FTucA9/z6pnuVdklYfJ JUj8d/syO3FFTBda35rxzG84JSQwh4FlUf4PWXVKBFglrmQF6f0l3bA+N/BWdHS5PNYv MSxQ== X-Forwarded-Encrypted: i=1; AJvYcCUvV/1lhhNHkrTQ5tBbndkLMwd0v+rX9Am7pfp4bqU0hUdls8jhEg5t9R3Q3rYPKdSYJXlL4WbV6d08RnY= X-Gm-Message-State: AOJu0YzSxnLjJHffP8ykxtRFhslapXgqkbaK2tgD6dnqvL2+Qi9j771s M8bfTl2SMyYl9nr4muv2IgPREkGlz/QikfYkyq2t+i2BO2yxgiaYKHYlk+sH8GfWu7EgxEndnDQ 6+fxTJpNlYBMiFtv8672KGXxILflMpRsoOM77 X-Google-Smtp-Source: AGHT+IF1LOc/0kMQPdv/AH1uE2zM7t6fSDmJLSvpIDqHD5Bk1uQUkuhexiuqmU/+Td5MsccgRH2SwwqN7129mcY75m0= X-Received: by 2002:a05:600c:3b16:b0:426:68ce:c97a with SMTP id 5b1f17b1804b1-42829f4fa8bmr1916355e9.7.1722457842076; Wed, 31 Jul 2024 13:30:42 -0700 (PDT) MIME-Version: 1.0 References: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> In-Reply-To: <1722443901-2400194-1-git-send-email-tathagat.dpdk@gmail.com> From: Joshua Washington Date: Wed, 31 Jul 2024 13:30:30 -0700 Message-ID: Subject: Re: [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain To: Tathagat Priyadarshi Cc: Rushil Gupta , dev@dpdk.org, Varun Lakkur Ambaji Rao Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 31, 2024, 09:37 Tathagat Priyadarshi wrote: > > The EOP bit was not set for all the packets in mbuf chain > causing packet transmission stalls for packets split across > mbuf in chain. > > Signed-off-by: Tathagat Priyadarshi > Signed-off-by: Varun Lakkur Ambaji Rao > > Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") > --- > drivers/net/gve/gve_tx_dqo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c > index a65e6aa..579b8d6 100644 > --- a/drivers/net/gve/gve_tx_dqo.c > +++ b/drivers/net/gve/gve_tx_dqo.c > @@ -126,6 +126,7 @@ > txd->pkt.dtype = GVE_TX_PKT_DESC_DTYPE_DQO; > txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id); > txd->pkt.buf_size = RTE_MIN(tx_pkt->data_len, GVE_TX_MAX_BUF_SIZE_DQO); > + txd->pkt.end_of_packet = 0; Please also update checksum offload for each mbuf. > > > /* size of desc_ring and sw_ring could be different */ > tx_id = (tx_id + 1) & mask; > -- > 1.8.3.1 > Thanks for all of the contributions! Let's try to get this applied to stable release as well.