DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [PATCH v4] net/gve : Update EOP & csum bit in txd rte_mbuf chain
@ 2024-08-01 22:38 Joshua Washington
  0 siblings, 0 replies; 2+ messages in thread
From: Joshua Washington @ 2024-08-01 22:38 UTC (permalink / raw)
  To: Tathagat Priyadarshi; +Cc: dev, dpdk stable, Varun Lakkur Ambaji Rao

Acked-by: Joshua Washington <joshwash@google.com>

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [PATCH] net/gve : Update EOP bit in txd rte_mbuf chain
@ 2024-07-31 16:38 Tathagat Priyadarshi
  2024-08-01 17:48 ` [PATCH v4] net/gve : Update EOP & csum " Tathagat Priyadarshi
  0 siblings, 1 reply; 2+ messages in thread
From: Tathagat Priyadarshi @ 2024-07-31 16:38 UTC (permalink / raw)
  To: rushilg, joshwash; +Cc: dev, Tathagat Priyadarshi, Varun Lakkur Ambaji Rao

The EOP bit was not set for all the packets in mbuf chain
causing packet transmission stalls for packets split across
mbuf in chain.

Signed-off-by: Tathagat Priyadarshi <tathagat.dpdk@gmail.com>
Signed-off-by: Varun Lakkur Ambaji Rao <varun.la@gmail.com>

Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO")
---
 drivers/net/gve/gve_tx_dqo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
index a65e6aa..579b8d6 100644
--- a/drivers/net/gve/gve_tx_dqo.c
+++ b/drivers/net/gve/gve_tx_dqo.c
@@ -126,6 +126,7 @@
 			txd->pkt.dtype = GVE_TX_PKT_DESC_DTYPE_DQO;
 			txd->pkt.compl_tag = rte_cpu_to_le_16(first_sw_id);
 			txd->pkt.buf_size = RTE_MIN(tx_pkt->data_len, GVE_TX_MAX_BUF_SIZE_DQO);
+			txd->pkt.end_of_packet = 0;
 
 			/* size of desc_ring and sw_ring could be different */
 			tx_id = (tx_id + 1) & mask;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-01 22:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-01 22:38 [PATCH v4] net/gve : Update EOP & csum bit in txd rte_mbuf chain Joshua Washington
  -- strict thread matches above, loose matches on Subject: below --
2024-07-31 16:38 [PATCH] net/gve : Update EOP " Tathagat Priyadarshi
2024-08-01 17:48 ` [PATCH v4] net/gve : Update EOP & csum " Tathagat Priyadarshi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).