From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7C98A0352; Mon, 31 Jan 2022 01:08:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 425E7410E6; Mon, 31 Jan 2022 01:08:35 +0100 (CET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mails.dpdk.org (Postfix) with ESMTP id 79AA040E25 for ; Mon, 31 Jan 2022 01:08:33 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id g10so9848489vss.1 for ; Sun, 30 Jan 2022 16:08:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BCOUdlwRdrz1+Sub0Tt6lEYIdY+4ewn87v37hoCs+Pw=; b=KEfnHp4gqSAEAfHPwNZuWg0/aa9D266gGq9GHNDm5P1B2tz8HBLmS+5BQPKj8DJ3rW Bm4Yv8RDg3hmRpzICq49N3Nk4b1gy/utHhkIXdA6TS4XY2sPL8P3ysuR1AJZj/hCVPef 4ROp+jy2QG1s+ToLcHMx8lKaOe76rlax8CUDVCMl0r9n3OvhK15mOL0AiCfLarawK507 46cTv8U9aKU68XDguUHUblNbD0PT8USBPv1yHailbmOHLo3QppvR3x8+enuYTNlJriwf FuH3zmCzZsF3UCY5fLlTAhk59c5X/BdSMfqbiUr4Q+pxU8XPDUTGdnsEiut333pcOliv IWxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BCOUdlwRdrz1+Sub0Tt6lEYIdY+4ewn87v37hoCs+Pw=; b=OU9EZH9vwpxyDt8wT6Ie7tSnh22pb0qw7zfKPrATIDDQI4eJpS7P85nvWDYF/TQuuB GUtXxQCRI9IxXU8LJy6uxXN4Z8O8BChg5Fdt9upe3OWqYlU2XrHyqNKpRX11R7xgPKlT SfXCCP8n/lruu+unEvqLsakvHEG5MKWFTYgKw9tkmUYOBs26Sh0y6NdliIgQ7z6uRQoD I5yeyJrNXQ/1KLBf1ZqZ/kEbzTMdM/RgjPkQuL63bENoNe8D24t10zl7fBsQmzw9ip5R Sd82VuVH46cPWQNF5w6i3xfZUlbWx7A1cKpITUYDx07REWHkM+gadwsKLcHN1zMRDcTb JU5g== X-Gm-Message-State: AOAM532EPlquMU/yy5Z3ZbEnaxEfD7l2AtZtljBcbafxLVokdXriugOn 3pwR4fBLu+TTkIHhd50ZAH9CSJuZBKP8TywPNkeonPMISZY= X-Google-Smtp-Source: ABdhPJyFkKiq16sBFzcy4uiAi6cZaFiS9zZCagTPLfokBQcA/PkW5QqSw1SQ6aDlLASW/wVJyh2VFE7FKQ/C3fOU/HE= X-Received: by 2002:a67:b741:: with SMTP id l1mr6758200vsh.50.1643587712847; Sun, 30 Jan 2022 16:08:32 -0800 (PST) MIME-Version: 1.0 References: <20220123210751.19182-1-mikeb01@gmail.com> <20220123212024.19747-1-mikeb01@gmail.com> <20220123155545.60de272f@hermes.local> In-Reply-To: <20220123155545.60de272f@hermes.local> From: Michael Barker Date: Mon, 31 Jan 2022 13:08:21 +1300 Message-ID: Subject: Re: [PATCH v4] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if. To: stephen@networkplumber.org Cc: dev@dpdk.org, Ray Kinsella Content-Type: multipart/alternative; boundary="000000000000c8130705d6d595fb" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000c8130705d6d595fb Content-Type: text/plain; charset="UTF-8" > > extension [-Werror,-Wgcc-compat] > > __rte_internal > > ^ > > Which clang version is this? > Clang 10, 11, 12 and 13. > Perhaps the allow internal API could use a different attribute that > could work in both cases? > I've realised I've made a small error. It is not -Wall that includes this particular check, but -Wpendantic. I'll update the commit message. However I can't find an attribute that is cross platform. There is the #error directive, but it does not work as an attribute. I've also tried adding `#if __clang__` around the macro as well, but the warning still gets triggered by clang. If there are any other options that I've missed, let me know and I can try them out. Mike. --000000000000c8130705d6d595fb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

> extension [-Werror,-Wgcc-compat]
> __rte_internal
> ^

Which clang version is this?

Clang 10, 11, 12 and 13.
=
=C2=A0
Perhaps the allow internal API could use a different attribute that
could work in both cases?

I've= realised I've made a small error. It is not -Wall that includes this p= articular check, but -Wpendantic.=C2=A0 I'll update the commit message.= =C2=A0

However I can't find an attribute = that is cross platform.=C2=A0 There is the #error directive, but it does no= t work as an attribute.=C2=A0 I've also tried adding `#if __clang__` around the macro as w= ell, but the warning still gets triggered by clang.

If there are any other= options that I've missed, let me know and I can try them out.

Mike.

--000000000000c8130705d6d595fb--