From: David Marchand <david.marchand@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: fix build error on old kernel doesn't support MQ
Date: Fri, 30 Oct 2015 15:40:26 +0100 [thread overview]
Message-ID: <CALwxeUs-7TORjcOu_18y8JWFp+7qgZQ1PUZa=8Gbah5Yy-H4Fg@mail.gmail.com> (raw)
In-Reply-To: <1446089865-20090-1-git-send-email-yuanhan.liu@linux.intel.com>
On Thu, Oct 29, 2015 at 4:37 AM, Yuanhan Liu <yuanhan.liu@linux.intel.com>
wrote:
> Fix build error:
>
> virtio-net.c:80:89: error: ‘VIRTIO_NET_F_MQ’ undeclared here
> rte_virtio_net.h:109: error: ‘VIRTIO_NET_CTRL_MQ_VQ_PAIRS_MAX’
> undeclared here
>
> Above two virtio-net MQ macros are introduced since kernel v3.8.
> For older kernel, we should not reference them directly, hence,
> this patch introduced two wrapper macros, with proper values
> being set depending on we support MQ or not.
>
> Fixes: 19d4d7ef2a21 ("vhost-user: enable multiple queue")
>
Not sure about this fix line as a build error first appeared for me at
b09b198bfb5c ("vhost-user: announce queue number in message")
> Reported-by: Gu YongjieX <yongjiex.gu@intel.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
Build restored on kernel 3.2 with this fixed applied.
Tested-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
next prev parent reply other threads:[~2015-10-30 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 3:37 Yuanhan Liu
2015-10-30 14:40 ` David Marchand [this message]
2015-10-30 14:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUs-7TORjcOu_18y8JWFp+7qgZQ1PUZa=8Gbah5Yy-H4Fg@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).