From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) by dpdk.org (Postfix) with ESMTP id 944166C96 for ; Mon, 29 Feb 2016 10:02:57 +0100 (CET) Received: by mail-oi0-f46.google.com with SMTP id k67so43494345oia.3 for ; Mon, 29 Feb 2016 01:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2GKAj8rjv/CVS36mNFjdFlOQzLGfTpam/V0AdaniISA=; b=Ov7cydllEuo7huH7osuuHeiHZNYwkyyAMYxsLHi9QxYzKS53A6FW7IQijYcACOIJ+R d9fUFblSlMragVCyHKmiECeGk5e2KLloj65j3UPPTIl6gpE5oWmG1m2kDbwSSayypKF/ s/sWpl+lV6af1fFqTkJiAAiX/GNBHPDUUU3MvqKyYafSPnsr+nkcYIqy8HuZqlhe9dpa Leu9cowE84e64kxKjsXEdza5qZqeudhyy0AuNSRxtRT648b+wQTplMO+tHkuEwB3Bbxt XX95Ds8LXteMbMw0npbB9H70tC1kNNwO3th6GCPaWkp6WX0H83Cjcc4BlS4ETN7c8WWi qulw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2GKAj8rjv/CVS36mNFjdFlOQzLGfTpam/V0AdaniISA=; b=WJygTya8CPHfJUoDDpqK3DI+uaAD8w9El60zQc+9dZ/khWCw266dKBRjQYbHNfvmIO JSQaAtYeWRO9VO3r48NxUkrzQ1o9gq328H3qza9cOD2y8DL0CC8IFaT62Hk3dLwtf4BE +Vz0SM+rUmBHonlN/yrh3kBBeNl5J4M/hD0JHLNxElOa4Vkpy96AvWJXggtyjeJULjJ7 EyWwZGooy1heE0xVTPYwbZYK9O/usGX+06/8EzAAwSKBaIK2VmsU9yrzulk58EoNQd7O CHZ7Io1psnUqhS10TyF6RukilVBrao/b1+j3TGlKjU3TciC8/B5EK2xMPMdsPRJjDs9o 00mQ== X-Gm-Message-State: AD7BkJIAVgM/4zsDutRiu4BCGIC+Ww/I33b9M8DMDIYRi+FBFzBF7f4lm9TVqwxNeZhXaUtUf9HCm7LEMYK8s5Dt X-Received: by 10.202.48.139 with SMTP id w133mr10596446oiw.61.1456736577086; Mon, 29 Feb 2016 01:02:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Mon, 29 Feb 2016 01:02:37 -0800 (PST) In-Reply-To: <1456451636-118476-4-git-send-email-huawei.xie@intel.com> References: <20151222035041.GA7532@pxdev.xzpeter.org> <1456451636-118476-1-git-send-email-huawei.xie@intel.com> <1456451636-118476-4-git-send-email-huawei.xie@intel.com> From: David Marchand Date: Mon, 29 Feb 2016 10:02:37 +0100 Message-ID: To: Huawei Xie Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , "Troitsky, Nikita" Subject: Re: [dpdk-dev] [PATCH v4 3/4] eal: call pci_ioport_map when kernel driver isn't managing the device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 09:02:57 -0000 On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie wrote: > Call rte_eal_pci_ioport_map only if driver type is RTE_KDRV_NONE, which > means kernel driver(including UIO/VFIO) isn't managing the device. I suppose you meant 'Call pci_ioport_map when the pci device is not bound to a kernel driver'. If you keep on with your choice of words, at least put a space before the (. > other minor changes: > * use RTE_ARCH_X86 for pci ioport map This is a trivial change, but this should not be here. > * rework rte_eal_pci_ioport_map a bit Well, not sure this comment helps the review, and anyway, why did you need to change this ? Your modification should be the smallest possible. > Signed-off-by: Huawei Xie Let aside these nits. Acked-by: David Marchand -- David Marchand