From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.marchand@6wind.com> Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id DC4012C18 for <dev@dpdk.org>; Mon, 22 May 2017 10:27:30 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id 7so55737762wmo.1 for <dev@dpdk.org>; Mon, 22 May 2017 01:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zBVG6RCC0CjPxVKfqlm2hBWLJQb49fHnd4m/zMpHK8k=; b=vNezWLFSGOf4fjxKjiv7J0mKL2V2/yjoMbKa2hZaa1VxyYz/Yl9LF9zdFpQVilWWEW 9xIy4/sMdW5tiM1oJYkE0YxGDS5tLcM38jeeDEbEAPYRW/v1K4lUsbUmnVEhM89JvH73 5j7kkgFwWEkS9z03J8DscVnWXP84U60mOd2IYnGgh4IpAGuzNZ0y6LcB9MuaDISURw/E UVjwCCMHhYlRpz4Eut9Tl0cL6gV1KOnzPpaUAw+6fb9EHOEe/T8ZO9Km21J/HqDwoaBJ koGC4s5ZUVuHkOKHpQjZbfExtRzsR7CCwBpRO/f3+QmO790IRyPB+Zh1Zdvj8fMklYju 8GtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zBVG6RCC0CjPxVKfqlm2hBWLJQb49fHnd4m/zMpHK8k=; b=AsrxaZr2P63nPdDtrC39Re9ZtkLQgBpgl5Kg3q/IbGgt6ys/uqrh/DisdNvEnyQsYl I/xXal+vrms8lOnEm96iAup/r422z8snbiz1fABrkxtckTFBgPMf/VUQ15WIYxidl6LH UncuEUPskczxQBMkK557iVlGbf6wxVcW3EZL85ijiUUBq7KhXltAv82yWXpwlpyzmg7Y bAH5qG0Ds2bOi0RtWcqeiFUT5kMcMMWAygjFa05tv8337Zc2VZKsA9wf0aYXh9sjohy+ 1MlARLVAAnTtfnIPOkjKXXwXMi4MwbswpB5AMsPkJWItrqpjmln+UTH5UuvcUxOF1Wqe acDw== X-Gm-Message-State: AODbwcD+Em8VEh/UR+Da2dZqIxqCP1XSN55V+/NaVpAKtD1NHVxwkpmv yR3v+3R61RY+IdV90jCkm7sAPFaUApHT X-Received: by 10.28.57.9 with SMTP id g9mr11866674wma.120.1495441650679; Mon, 22 May 2017 01:27:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.199 with HTTP; Mon, 22 May 2017 01:27:10 -0700 (PDT) In-Reply-To: <CALwxeUthY9RsW16Mci6QQLHaQaQ7x8oUHDZWUGAgA7xRVU-pwA@mail.gmail.com> References: <1495285957-22307-1-git-send-email-david.marchand@6wind.com> <20170522101825.7c4b99b6@platinum> <CALwxeUthY9RsW16Mci6QQLHaQaQ7x8oUHDZWUGAgA7xRVU-pwA@mail.gmail.com> From: David Marchand <david.marchand@6wind.com> Date: Mon, 22 May 2017 10:27:10 +0200 Message-ID: <CALwxeUsJ0wEpwxtEiKnrPBSxGmqVsd2jXF6FSwzpzecS7eTG2Q@mail.gmail.com> To: Olivier Matz <olivier.matz@6wind.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] drivers: fix vfio kmod dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 22 May 2017 08:27:31 -0000 On Mon, May 22, 2017 at 10:25 AM, David Marchand <david.marchand@6wind.com> wrote: > On Mon, May 22, 2017 at 10:18 AM, Olivier Matz <olivier.matz@6wind.com> wrote: >> On Sat, 20 May 2017 15:12:37 +0200, David Marchand <david.marchand@6wind.com> wrote: >>> vfio is the kernel framework used by the vfio-pci kernel driver. >>> DPDK drivers do not rely solely on vfio, but rather on vfio-pci to gain >>> access to pci resources. >>> >>> Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") >>> Signed-off-by: David Marchand <david.marchand@6wind.com> >> >> Acked-by: Olivier Matz <olivier.matz@6wind.com> >> >> What would be the impact of not having this fix? > > Mainly reporting an incomplete information on the PMD needs. > >> I think it would prevent scripts based on pmd modinfo to load the proper >> kernel module (vfio-pci). So I'd suggest to CC stable. What do you think? > > Yes, CCing stable sounds sane to me. *really* CCing stable ... -- David Marchand