From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D33EA56AB for ; Fri, 30 Sep 2016 17:27:40 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id b4so53667996wmb.0 for ; Fri, 30 Sep 2016 08:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z8QyqRAirYHotl/yE2JhaU22AAeCcAJTSQPcvkqRVj0=; b=AH6/PZbqHiN4LXJy5OP5X8jp1V8tNT+OzZf5sKh7hC+9DkA/5RvlgLcZif7MElb5tB D1RtyipDnA0lFuDnJdPvZ+UPO7RzU1IG66BAWl9HvRa81TvmKCiGoe+Qr8A1KBA6cbHO kXoI4KWN21aO1GjHbEysRAnubEoBH6/XZKiQ3ISsVpEUIig0Kj0NAd8r8W/d6dWqLixF wWF2n//FMj3ymvwHBe1fhupeTaLhaHmJoAYz924+d40FNw4hkJoqHrUUdvQ1SNzNw4Aq fZO9OYt42Lk0YgymjPvOXzdlE4C0zk4rPj8ioTtrfTUvk6+KANsvViZRq1wccpbXcCQb uk+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Z8QyqRAirYHotl/yE2JhaU22AAeCcAJTSQPcvkqRVj0=; b=OtgPMyeevtM5F3M+onrvbgmOferXo+pZkIgm9U7kRD1R0G+bHe8Brp+RHSZCsQgBbY VWmsl0RdthcPxA0f5LizkGR/0Xr3mfkB1KX1umU5AKd5FNvhMPsSkTwd8l4tHMRs2CsK 6OlUw+z2ONd50zsxbLTFe+BjcrVeg/dgD+IKA5Hmu5xu0JBMDyfg2scaZ/oTKp8tqdjG Ew4B8TPj7sjaebJcZ/cxsAJIY1E5tt3O5+ual8Vm1eTDcFvc4j3rVprTC7E3fvLf54C+ gCJgPzOSV9i1PbGQxVJSMnK2yRfjnX43JaZMTOuMZXUgMEtd9+90oLeVKtyzNL3En1Ii mhLQ== X-Gm-Message-State: AA6/9Rn9XENGhaEURvtzYLpyYdNgdFkyqrgRJ5+gPO8SnPSP4r/pevt97Pp+bpRPdFc9EyS3P/3a4cjV3807GIod X-Received: by 10.28.181.145 with SMTP id e139mr4264923wmf.114.1475249260637; Fri, 30 Sep 2016 08:27:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.95.130 with HTTP; Fri, 30 Sep 2016 08:27:20 -0700 (PDT) In-Reply-To: References: <4622854.nVE6J4R6pe@xps13> <1475113270-21983-1-git-send-email-zhouyates@gmail.com> From: David Marchand Date: Fri, 30 Sep 2016 17:27:20 +0200 Message-ID: To: Thomas Monjalon Cc: "dev@dpdk.org" , stable@dpdk.org, Yangchao Zhou Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] pci:fix missing free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 15:27:41 -0000 On Fri, Sep 30, 2016 at 5:19 PM, David Marchand wrote: > Hello, > > On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou wrote: >> Signed-off-by: Yangchao Zhou >> --- >> lib/librte_eal/common/eal_common_pci.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c >> index 7248c38..eb44998 100644 >> --- a/lib/librte_eal/common/eal_common_pci.c >> +++ b/lib/librte_eal/common/eal_common_pci.c >> @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr) >> goto err_return; >> >> TAILQ_REMOVE(&pci_device_list, dev, next); >> + free(dev); >> return 0; >> } >> return -1; >> -- >> 1.7.1 >> > > For the title, how about: > pci: fix memory leak when detaching devices > > Afaics the fixes tag would be : > > Fixes: dbe6b4b61b0e ("pci: probe or close device") > > + CC stable Thomas, can you apply this with my ack ? Thanks. -- David Marchand