From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f196.google.com (mail-io0-f196.google.com [209.85.223.196]) by dpdk.org (Postfix) with ESMTP id D6C891BAC4 for ; Thu, 26 Oct 2017 13:27:38 +0200 (CEST) Received: by mail-io0-f196.google.com with SMTP id i38so4592778iod.2 for ; Thu, 26 Oct 2017 04:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KFvVq/XOAVocgpaDEuhhKh8d53XFMIMkkHGR/AaBAr4=; b=Ggev7JM7ExjqKMMgTIXGSdydddBmGX1H7eEBL+l7YoiORs4ogLTW2bdWLjHcLo54bz vZ+TWSShPCOC4nzJY/JVmsuhST1SBER6TDvlTklJ6jrxe+2qkympH5nTQahCXpDMtJ/l F1+QRf0/xCwZmPg4Fy4SY7mcZiFLcHs3SPdC+RTcWqzowvS7rdn8kqHXUQTI29yiuXjR qUq9mH7mhE3ssoPsuTpPtByYqn79Xc+ITWyFw6QYInPu+ZY/n84k5Zh9Akt/NQm2pzKz WWtpxAyS+f9VFVsM9i2xliAEXllUBVH2anTi2yxM9gIvgUi/29dvSVZTQkDbEtfeuXCF h3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KFvVq/XOAVocgpaDEuhhKh8d53XFMIMkkHGR/AaBAr4=; b=c0KEqnsJ7/BB/0OE+1nE6tR5BzGhe4uZl1tw05tpwnDLEQ+PPW4SghR7ZUytzF7dOt vfWVRpk8ihJ/OkepbE54odv1R62LTj7U2hCpFh4oZbydbCRTR12HHJc1W3ETBncWXyim Eag0dS2kkMUEz55TSielaGwxkMfMK+GpGlus5NyobWK4mdgMhuaWbxyhd+etKKENnS7i /0y8YnrptPZzj++Tren+lAQkwj5YMJRWykdtQgTSHAY4YnOn0rctHAq4Kz+pkr+sA2/M ip4edguqNeLTxlLA4GrxiQ3LQUeaiK8Fv3pmIScLqIU/0gWlPb76xqoDFQAybFyQNcTZ vFdg== X-Gm-Message-State: AMCzsaVScUwf17Yl9l1FiGdDKArthY0p49ryzQjuwiCVOhTMawmHDGRZ DQmzRyg9wwVd4w6AuK5dm0Ywf9rIU+UqVR4pCmxWXg== X-Google-Smtp-Source: ABhQp+RdD0JFUS+3j0vEheDVsIeBy95/uHCBhZvQlh228zkCt8b2xysmAIP8mifkpne53YFEZemOlpzZ5MpJBCREnl4= X-Received: by 10.107.184.138 with SMTP id i132mr31180082iof.155.1509017258043; Thu, 26 Oct 2017 04:27:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.1.82 with HTTP; Thu, 26 Oct 2017 04:27:17 -0700 (PDT) In-Reply-To: <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com> References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <1509013365-13819-3-git-send-email-radu.nicolau@intel.com> <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com> From: David Marchand Date: Thu, 26 Oct 2017 13:27:17 +0200 Message-ID: To: Radu Nicolau Cc: "dev@dpdk.org" , Declan Doherty , Pablo de Lara , Hemant Agrawal , borisp@mellanox.com, aviadye@mellanox.com, Thomas Monjalon , sandeep.malik@nxp.com, Jerin Jacob , "Mcnamara, John" , "Ananyev, Konstantin" , shahafs@mellanox.com, Olivier Matz , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 11:27:39 -0000 On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: > On 10/26/2017 11:36 AM, David Marchand wrote: >> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau >> wrote: >>> >>> Build fails when rte_security is disabled; make rte_security mandatory >>> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") >>> >>> Signed-off-by: Radu Nicolau >>> --- >>> drivers/net/ixgbe/Makefile | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile >>> index f03c426..c879828 100644 >>> --- a/drivers/net/ixgbe/Makefile >>> +++ b/drivers/net/ixgbe/Makefile >>> @@ -31,6 +31,12 @@ >>> >>> include $(RTE_SDK)/mk/rte.vars.mk >>> >>> +ifneq ($(MAKECMDGOALS),clean) >>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) >>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") >>> +endif >>> +endif >>> + >>> # >>> # library name >>> # >> >> This is a no go for me unless you explain how it is impossible to >> disable it in the code. >> >> > It can be disabled in the code, but as far as I know there is a general push > back against having conditionally compiled code. I originally had the > security sections in ixgbe PMD isolated, but the feedback was to have them > always on. In my mind, this was to stop having features enabled per pmd (and stop the nightmare with 10 options in a pmd). Having features globally enabled for all or nothing is still acceptable, is it not ? > An alternative solution will be to remove the option altogether and always > build rte_security library. As a general rule, I prefer enabling only the things I use, but I am not against this ? Can you confirm the performance impact is negligible, always having this in the pmds ? Thanks. -- David Marchand