From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f67.google.com (mail-it0-f67.google.com [209.85.214.67]) by dpdk.org (Postfix) with ESMTP id 8CAA94C92 for ; Fri, 30 Mar 2018 08:45:18 +0200 (CEST) Received: by mail-it0-f67.google.com with SMTP id 19-v6so10487930itw.3 for ; Thu, 29 Mar 2018 23:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YRSvKMMAUi073R9lvNqls+4ayTcqoT4vGLgxj9oWsGg=; b=S4EopyBoxtsnbcYgbKoCrxChDdeUynN55b8h5RyvGQsSnxwW0MexaVQ+XYwSBOQ7Dt x3+DTpXlYuYy+E53GC2g8CXoWFR+bFJo3yVAmAn+DuBj1Kvt6mvIpJX5F1IkZqvO5zF5 5/mUOBw6BSdodBRaRPAztQE8NlzD3I/1zoMz6TICm0rMCukrFprw/8yZBVdMfen2hHyt bjoHAOAaiaECBczVTZ1/RyZ7S4uKwSic+0KDvXhLkjDZuSobXXd9PUyU1XdFQyQPMMmv hrEaUJI/EBDYsxl8NGxQzyglOzbfgRycZ19cyRLOPf5LV0XttYDYwpiOXN8nJWdoP+J4 e45A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YRSvKMMAUi073R9lvNqls+4ayTcqoT4vGLgxj9oWsGg=; b=bVw/OXObKMLGwBVB67uRobWzMruBkpNsWUGoSgcz1TCN/xxLDMV3/SF7Fgpt9rwCSr rrFH7OIONlQR6r7/yx0dwCyXyLAlGDiDRQ9EZ3ouGLdBm2Sf7Q2VL7y2WxSXz0GWCGMQ M8r8yCtpOWsmt0UPWPiyctDYbcz5/tQh0hLZfM0vXZ3AfGau0in9viv6shyTY581yoPD Ju+Avd6VXWJp9RI/JgmX7dLVmzO8+2HcKWxhfBh6hwtGq6LZX26WColi8aPnBbqcmfYB /pi8a0U/YjvYsmkt38ZOY43fDDerJGqHW7edatEHXJ4JpA8vS2i7hRx1lFRWqcbVAP/F jupA== X-Gm-Message-State: ALQs6tBQw+IC7BGycg4BpLsw9uUwCnySQq9sdT3hwbzIyy/bgFiejLqX vnbyraWHEs310JEkmmMkvk/8x83YByuiZPsKm3ZbQw== X-Google-Smtp-Source: AIpwx493f3OCIEQbSv9829Li7T51TvSTXBWb07WG7w4puVR25AH+O5tUlNCMuAdHtU73D/zH8ZIVANX5/A17RR9M9PM= X-Received: by 2002:a24:510b:: with SMTP id s11-v6mr1983382ita.6.1522392316784; Thu, 29 Mar 2018 23:45:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.154.161 with HTTP; Thu, 29 Mar 2018 23:44:56 -0700 (PDT) In-Reply-To: <20180329175206.127943-1-ferruh.yigit@intel.com> References: <20180329145048.123662-1-ferruh.yigit@intel.com> <20180329175206.127943-1-ferruh.yigit@intel.com> From: David Marchand Date: Fri, 30 Mar 2018 08:44:56 +0200 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 06:45:18 -0000 Hello Ferruh, On Thu, Mar 29, 2018 at 7:52 PM, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a way to get this information from > generic device. > > Signed-off-by: Ferruh Yigit > Acked-by: Shreyansh Jain > Acked-by: Allain Legacy > Acked-by: Tomasz Duszynski > Acked-by: Santosh Shukla The ethdev device already points to the backing device. So, can't this be done in the ethdev layer itself ? -- David Marchand