From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-io0-f193.google.com (mail-io0-f193.google.com
 [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id 586981BAA3
 for <dev@dpdk.org>; Thu, 26 Oct 2017 12:36:27 +0200 (CEST)
Received: by mail-io0-f193.google.com with SMTP id m81so4284631ioi.13
 for <dev@dpdk.org>; Thu, 26 Oct 2017 03:36:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=h6w/BUDsG+bC6jzzSu/jQZm0s+QBUQgEseQLLY4+Lr0=;
 b=nOp5Km4XMfwEOqGsSDnydiJ510LEDxsAhkqoV2MED+lEaTxrFOkb6dKXAteI7dPCzF
 3Dsc/AR14LKIrtCVVF7eUqWbkepZbMcShMRwYA6K+cSlf1pbg7k/KIduGQrn2BLT+0ei
 CQkg/hNivcPlP0kHlJuehHawjCnkA+NPXC7FGJOqtO9PhV4SjuTQVNp+B6clnlw5LIZZ
 BFULsqnUIB3kp6Z7yfgtj7gAIDMMRYy+b6owD13PydMHhFQnLsIrv5zUCibpjjSf0fwH
 LV/k1IMJA2PO9Ifv5wcpqSQPMZ8ZqxajWZ7P/mPeXeAByBHb1ijUU1puDy4twOfmgDan
 1saA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=h6w/BUDsG+bC6jzzSu/jQZm0s+QBUQgEseQLLY4+Lr0=;
 b=siGgjsLyLJuMmfJ/s3VIMvJbkCMjKlm57L+SM6fFZ+KHxgc9uSyHxpHbof5+GulFCv
 eUgV6EaojJHnBLQ7CRPjMURzKHy3RsKngOxlPOPFFR/Z5ONYIXaF6YjFBlb6AAHgRYvg
 5kUfQa59+U2CbJ/9H0jEONrlAPw1tAlR4uGNo28ZYdw0pxY0vYMmXhztv09t3evMYBLu
 WjS5OWq5pnIqJ1pXq3i5aBNfh9ZoCKrlqchBTgAsvCNpXBlmjsPI5qND8yo9rSMV87An
 ZzuBeRJWC1g99rSTr6rUWtdvE4BwrnbIzYavuohGfX1dDGIRrOuFSTqA3YkLJiQbGJzp
 /KYg==
X-Gm-Message-State: AMCzsaWBIW7CRHmcVihub/9nR//J3Rhx4o7fcWOJRzcpHBmcCfrGHl7z
 mhOYJNpnmS5TPX93KIqsjNBcM4a6+m3b12OVOs6s1g==
X-Google-Smtp-Source: ABhQp+QdVpCeKCeWx4cJoSwoLdYa96UfrC9jWqIs+vTWz8j+jbRr5y59sxqE1EmqgMSRTeR2XBDQ0YL6oBQ7CMYJDrw=
X-Received: by 10.36.69.100 with SMTP id y97mr1785627ita.50.1509014186610;
 Thu, 26 Oct 2017 03:36:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.2.1.82 with HTTP; Thu, 26 Oct 2017 03:36:06 -0700 (PDT)
In-Reply-To: <1509013365-13819-3-git-send-email-radu.nicolau@intel.com>
References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com>
 <1509013365-13819-3-git-send-email-radu.nicolau@intel.com>
From: David Marchand <david.marchand@6wind.com>
Date: Thu, 26 Oct 2017 12:36:06 +0200
Message-ID: <CALwxeUsOAA8KOtSLT0RqNNRa3UW4s=g9ddDKkFEAyRijQbVkLQ@mail.gmail.com>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Declan Doherty <declan.doherty@intel.com>, 
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, 
 borisp@mellanox.com, aviadye@mellanox.com, 
 Thomas Monjalon <thomas@monjalon.net>, sandeep.malik@nxp.com, 
 Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Mcnamara,
 John" <john.mcnamara@intel.com>, 
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, shahafs@mellanox.com, 
 Olivier Matz <olivier.matz@6wind.com>, Akhil Goyal <akhil.goyal@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Oct 2017 10:36:27 -0000

On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau <radu.nicolau@intel.com> wrote:
> Build fails when rte_security is disabled; make rte_security mandatory
> Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
>  drivers/net/ixgbe/Makefile | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index f03c426..c879828 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -31,6 +31,12 @@
>
>  include $(RTE_SDK)/mk/rte.vars.mk
>
> +ifneq ($(MAKECMDGOALS),clean)
> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y)
> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD")
> +endif
> +endif
> +
>  #
>  # library name
>  #

This is a no go for me unless you explain how it is impossible to
disable it in the code.


-- 
David Marchand