From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id CE7595A6B for ; Mon, 2 Nov 2015 16:53:55 +0100 (CET) Received: by obbwb3 with SMTP id wb3so98175615obb.0 for ; Mon, 02 Nov 2015 07:53:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ery03evPy/csQRSKfL2rHLNxWcG+q63lfESHPwS3BQY=; b=CJtG0cAntuSPFSX+TEBHedcWSQRULKCb8IjTSI2iTr/JrYbwo92Aqrc5V34ZpQFAEk XZouwoAcFa6JvTWnGEq3tC+hOULZL4PjKYaSq/vSxbnfJbzUMa29llbYFmo7/cSCJ85W iJhH2j7Cdx6c2dnOU8RcqED6k+Iis/T4ZbV+AB3rubPappuE5b4aUueaLYs6N/C2V5SV KezK1qWXni314m42G7M9v2R1CVFCsKKdiqZKASA8DoS/AZ2k7ZZqdPVYCc8cXUB/Nwny ILmdHVrNlO7eIbQ+uoWOOluk8GnL3WORGl1XpmJYK8P+UaPOtkS0FSPokP5GLhO/SseK gdCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Ery03evPy/csQRSKfL2rHLNxWcG+q63lfESHPwS3BQY=; b=b0bOO6xd/Prj/sZEqp+hjNr3Slt2no7XZny4V+omKbfT+0E0gpcKFD2XSFSHqCiMLL +qkp2CLPNgb19fK/TblD4n9eCqpbUe0LUOxkcWW5MH8DQvLMmhQaNZJ4jhxVHohlEnIF 9Mo/8OgxsGr88MLqT7KHeNOwA3P+5n/1vMV+SiIu4CQF3hTGW9qKKha+KUT/kF5fJScu qFvZenbvZnfnPfXws48haOC+6BtrahWqSf7/OWZJhGLoTTUJJmIUEgbM3c+lILnwbBBa 6VJD9ODsSVwqvrcRB9cLiZEjEKdrtjMIff7Oqw3fGTiuH201eR0fDdlvDJxF7ymzPIyN f0hA== X-Gm-Message-State: ALoCoQk9DpMulFHOI70+pTRjvEd3vqCL4kBpQwHc8vl0jZ/HGw+lJROj+hHkcPfACZ1tnD/bf8a+ MIME-Version: 1.0 X-Received: by 10.60.178.74 with SMTP id cw10mr14623893oec.6.1446479635187; Mon, 02 Nov 2015 07:53:55 -0800 (PST) Received: by 10.76.131.166 with HTTP; Mon, 2 Nov 2015 07:53:55 -0800 (PST) In-Reply-To: <1446182873-28814-2-git-send-email-cunming.liang@intel.com> References: <1443072831-19065-1-git-send-email-cunming.liang@intel.com> <1446182873-28814-1-git-send-email-cunming.liang@intel.com> <1446182873-28814-2-git-send-email-cunming.liang@intel.com> Date: Mon, 2 Nov 2015 16:53:55 +0100 Message-ID: From: David Marchand To: Cunming Liang Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal/linux: vfio map misc intr to vector zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 15:53:56 -0000 Hello, On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang wrote: [snip] > diff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h > b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h > index 45071b7..b8fd318 100644 > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h > +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h > @@ -77,6 +77,9 @@ struct rte_epoll_event { > struct rte_epoll_data epdata; > }; > > +#define MISC_VEC_ID (0) > "misc" is not really descriptive ... > +#define RX_VEC_START (MISC_VEC_ID + 1) > + > Please, prefix these macros properly. Else, when looking at the driver code, this kind of macros seems to be local to the driver. -- David Marchand