From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com
 [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id 34BB45A53
 for <dev@dpdk.org>; Tue,  7 Jul 2015 10:04:18 +0200 (CEST)
Received: by obdbs4 with SMTP id bs4so123585756obd.3
 for <dev@dpdk.org>; Tue, 07 Jul 2015 01:04:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=6oH1UiR44X5bvTViFsGYWNZBf4KaaGKzbXEb8qh0psA=;
 b=msrR1WSp9e/bGOE6SWOfO8X2oC8bVYrqLQnBwayIDmh9FsAUVfeeomK5KiWOND/XgU
 MPzP6la276F3ORiW3mSngQVgxx1oxK0LaOegCIbytKmGoxTN3JdTgfwL8ToFrssBfZ4F
 SNE0XTMH/qELvyYqd6F3BhrPaJdYYrhQKRAyBSWuOoRantnJvOD8vqW7cfXlbMavDG9w
 SnPA/fC5Fe/gJACc6jLwqQzId2avU69N5mmLk2hhk0dx6LxpFTqfn2FXHe0l8zc8tBi1
 +wWAy25O7VHXfjHpElDAZvYoNRqqob3CiE/QvXvS9GmJXKjUhj3FSFuyJjn8+ISAYQLJ
 OPLg==
X-Gm-Message-State: ALoCoQkqG/I7rwUEyAJ5+8D+cV3fdKtezr4Y0n0AkY7soPrqWN9s18TVolEP4fWGzV+7kyJwbvQn
MIME-Version: 1.0
X-Received: by 10.202.79.209 with SMTP id d200mr2715583oib.46.1436256257658;
 Tue, 07 Jul 2015 01:04:17 -0700 (PDT)
Received: by 10.76.84.233 with HTTP; Tue, 7 Jul 2015 01:04:17 -0700 (PDT)
In-Reply-To: <1436163861-3025-3-git-send-email-mukawa@igel.co.jp>
References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp>
 <1436163861-3025-1-git-send-email-mukawa@igel.co.jp>
 <1436163861-3025-3-git-send-email-mukawa@igel.co.jp>
Date: Tue, 7 Jul 2015 10:04:17 +0200
Message-ID: <CALwxeUsSAsb5_DeNtLF7g+GLztJajYPMK0cHizSghrKKXKhe8A@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v8 02/12] eal: Close file descriptor of uio
	configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jul 2015 08:04:18 -0000

On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:

> From: "Tetsuya.Mukawa" <mukawa@igel.co.jp>
>
> When pci_uio_unmap_resource() is called, a file descriptor that is used
> for uio configuration should be closed.
>
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> index 5915a84..37dc936 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> @@ -465,8 +465,12 @@ pci_uio_unmap_resource(struct rte_pci_device *dev)
>
>         /* close fd if in primary process */
>         close(dev->intr_handle.fd);
> -
>         dev->intr_handle.fd = -1;
> +
> +       /* close cfg_fd if in primary process */
> +       close(dev->intr_handle.uio_cfg_fd);
> +       dev->intr_handle.uio_cfg_fd = -1;
> +
>         dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;
>  }
>  #endif /* RTE_LIBRTE_EAL_HOTPLUG */
> --
> 2.1.4
>
>

Acked-by: David Marchand <david.marchand@6wind.com>

-- 
David Marchand