From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id C51035A51 for ; Tue, 7 Jul 2015 10:06:16 +0200 (CEST) Received: by obbgp5 with SMTP id gp5so11284453obb.0 for ; Tue, 07 Jul 2015 01:06:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=gTakmXrJV7zeNIzouTZ00RBwecdbEZ/hw5IYihPNd20=; b=hEv61CnJcEPbZZXJACR8bCuu/9Z1TPi+hH+LyedLLo/N11Ma81Sxi+X2YM63tfKpVX UT9Oz7STNRPUcV0LYW3Qy2mmgeqSqgxYhOyHEueRn06qtQoYPC8CNrg2FCEC0PEJatsW 1JrB1tNsndrrfZIud7GBq/L1FWlFC/HVWUKADymjtkhsdgBZIRQ2wbi2hs8a20JWV0n5 hh0TXJUAriOwiY8oASsBlaIbtrNIvyV5cjpHKbKTyyotJpZ24PP08ARKcYyOjdblkcU2 tU3qae12yPZSyxNswTtddrtnvMWcCSp07v21XJQHI9Y9hTgGFXhwpz9HpiL+L5+WX+bj SrdA== X-Gm-Message-State: ALoCoQmtGmpx8mdcCGwkvw/KFqotqPtJVikiTYNreERUmDpZdNv8/ZmBIr1RjWGwM+LukFbgZduk MIME-Version: 1.0 X-Received: by 10.202.202.129 with SMTP id a123mr2763182oig.118.1436256376289; Tue, 07 Jul 2015 01:06:16 -0700 (PDT) Received: by 10.76.84.233 with HTTP; Tue, 7 Jul 2015 01:06:16 -0700 (PDT) In-Reply-To: <1436163861-3025-12-git-send-email-mukawa@igel.co.jp> References: <1435652668-3380-12-git-send-email-mukawa@igel.co.jp> <1436163861-3025-1-git-send-email-mukawa@igel.co.jp> <1436163861-3025-12-git-send-email-mukawa@igel.co.jp> Date: Tue, 7 Jul 2015 10:06:16 +0200 Message-ID: From: David Marchand To: Tetsuya Mukawa Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 11/12] eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jul 2015 08:06:17 -0000 On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa wrote: > From: "Tetsuya.Mukawa" > > The patch consolidates below functions, and implemented in common > eal code. > - pci_map_device() > - pci_unmap_device() > > Signed-off-by: Tetsuya Mukawa > --- > lib/librte_eal/bsdapp/eal/eal_pci.c | 3 ++ > lib/librte_eal/common/eal_common_pci.c | 57 > +++++++++++++++++++++++++++++++++ > lib/librte_eal/common/eal_private.h | 19 +++++++++++ > lib/librte_eal/common/include/rte_pci.h | 1 + > lib/librte_eal/linuxapp/eal/eal_pci.c | 53 > ------------------------------ > lib/librte_ether/rte_ethdev.c | 2 ++ > 6 files changed, 82 insertions(+), 53 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c > b/lib/librte_eal/bsdapp/eal/eal_pci.c > index f85fc1e..a27dca3 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > @@ -240,6 +240,9 @@ pci_scan_one(int dev_pci_fd, struct pci_conf *conf) > /* FreeBSD has no NUMA support (yet) */ > dev->numa_node = 0; > > + /* FreeBSD has only one pass through driver */ > + dev->kdrv = RTE_KDRV_NIC_UIO; > + > Do we need a new define for this ? I know this is not really part of this patchset, but this kdrv should just disappear. -- David Marchand