From: David Marchand <david.marchand@6wind.com>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: Andrzej Ostruszka <amo@semihalf.com>,
dev@dpdk.org, Ilya Maximets <i.maximets@samsung.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: use bash for checkpatches.sh
Date: Mon, 10 Sep 2018 08:26:15 +0200 [thread overview]
Message-ID: <CALwxeUsjWLZk58xd2Kty2UmQr9-n1mM24hzcA6NKbY-D1J1rrw@mail.gmail.com> (raw)
In-Reply-To: <CAKy9EB1BdAnsr-0eEncX_w8yv8RRnjeRGjZQSaxVj7OTwY23sw@mail.gmail.com>
On Fri, Aug 31, 2018 at 10:00 AM, Arnon Warshavsky <arnon@qwilt.com> wrote:
> On Thu, Aug 30, 2018 at 4:00 PM, Andrzej Ostruszka <amo@semihalf.com> wrote:
>
>> On some systems /bin/sh does not support '-d' option of 'read'.
>> So instead of /bin/sh use /bin/bash.
>>
>> Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs")
>> Cc: arnon@qwilt.com
>> Signed-off-by: Andrzej Ostruszka <amo@semihalf.com>
>> ---
>> devtools/checkpatches.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
>> index ba795ad..db7afc4 100755
>> --- a/devtools/checkpatches.sh
>> +++ b/devtools/checkpatches.sh
>> @@ -1,4 +1,4 @@
>> -#! /bin/sh
>> +#! /bin/bash
>> # SPDX-License-Identifier: BSD-3-Clause
>> # Copyright 2015 6WIND S.A.
>>
>> --
>> 2.7.4
>>
>>
>
> Acked-By: Arnon Warshavsky <arnon@qwilt.com>
Tested on Ubuntu 18.04, thanks.
Tested-by: David Marchand <david.marchand@6wind.com>
--
David Marchand
prev parent reply other threads:[~2018-09-10 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 13:00 Andrzej Ostruszka
2018-08-31 8:00 ` Arnon Warshavsky
2018-09-10 6:26 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUsjWLZk58xd2Kty2UmQr9-n1mM24hzcA6NKbY-D1J1rrw@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=amo@semihalf.com \
--cc=arnon@qwilt.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).