From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 035B9CCBA for ; Fri, 17 Jun 2016 14:29:15 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id v199so228318170wmv.0 for ; Fri, 17 Jun 2016 05:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jKXEuKByRP8SS/FomxXLxEuVnQGGM5otO/+f+OnE2gs=; b=XnUoZa8xCuSo3G7tTnVN8bBsnw/mIGAI/EuRmysshZotfJ92D/28H/UnP3hHUSpC7g RKh/7r8sCyizbdfIOosDOr6gPxpnfZ8gY8LVqIgklxWJ1bCvtT/+xBHLtgpAauVTQIua fpL0XVqJY76qcGicCzksabFz+m5qv+XM7eOfhzlTODXEkv4l6ZLWWAciJUW9uvfB8nOB fk/kd4Bd4RETfTmVYQxVn10yFtP52MLvXc+owE0CrdNsF5gpS561Y/faVUrwvt5n0LTt uPKfV3nZXTWW46Q5fO2uXIr2hJ/WwG7XDGXwnxxlSI/aNRbqtWoZ+XHzIvhpN0CxralR K8ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jKXEuKByRP8SS/FomxXLxEuVnQGGM5otO/+f+OnE2gs=; b=e035JyM9AElIoL8diG4EqYpS3GCEgDPFcXdi1J0yudxcKSt66EZ3N/o1gCIchhCzqb 9U5k5DuKAXU7ANbUr0+Qyez0/NmpMVVQvZxVr57vxIRCNO4saZm/OUdqy12nn95IUJ7P 2rkHzlLp39pT47O0yuQRHr/cAyK1SN3KAXyWoWeYw5Tns4CBN0o7Ubx5GR8q8BqgROYt gaSzXH+VB5v/0hAM5C58JWaaPdi5BeK5NQzg99/FduFdES0U9w30Vl9VfZ3q3+Lv3dUr snehbTxZlG17fzc+gFXCwLYXI5LipfxGBnRyeSdCT8jigyNdnwZ8b3PBeSBDge59Fa+8 M6Nw== X-Gm-Message-State: ALyK8tLK/oIkDvqeliWSt+5BayAJk2N7JdbeRSCqZdif9LwXosncfO04TeON3Yywk5YHIKr1ZyEg5UApI8Io6yny X-Received: by 10.28.47.71 with SMTP id v68mr21104562wmv.49.1466166554719; Fri, 17 Jun 2016 05:29:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.16.13 with HTTP; Fri, 17 Jun 2016 05:28:55 -0700 (PDT) In-Reply-To: <1466044391-3210-3-git-send-email-mukawa@igel.co.jp> References: <1465961172-28253-1-git-send-email-mukawa@igel.co.jp> <1466044391-3210-1-git-send-email-mukawa@igel.co.jp> <1466044391-3210-3-git-send-email-mukawa@igel.co.jp> From: David Marchand Date: Fri, 17 Jun 2016 14:28:55 +0200 Message-ID: To: Tetsuya Mukawa , Thomas Monjalon Cc: "dev@dpdk.org" , "Mcnamara, John" , michalx.k.jastrzebski@intel.com Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2016 12:29:15 -0000 On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa wrote: > This patch fixes resource leak of pci_uio_map_secondary(). > If pci_map_resource() succeeds but mapped address is different from an > address primary process mapped, this should be error. > Then the addresses secondary process mapped should be freed. > > Signed-off-by: Tetsuya Mukawa scripts/check-git-log.sh is not happy : Wrong headline uppercase: eal: Fix resource leak while secondary process maps pci devices Wrong headline lowercase: eal: Fix resource leak while secondary process maps pci devices Headline too long: eal: Fix resource leak while secondary process maps pci devices Missing 'Fixes' tag: eal: Fix resource leak while secondary process maps pci devices checkpatch is not happy, but I think we can ignore it. WARNING:LONG_LINE: line over 80 characters #48: FILE: lib/librte_eal/common/eal_common_pci_uio.c:93: + (size_t)uio_res->maps[j].size); Anyways, looks good to me, Thomas, can you fix the commit logs of those last 3 patches on eal ? Thanks. -- David Marchand