From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 9CCB42931 for ; Mon, 8 Aug 2016 08:36:38 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id q128so99562190wma.1 for ; Sun, 07 Aug 2016 23:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A76W91hpjSHLEadLCV7UGDDYEI7ysSho3oO5IxxUOCo=; b=FSJoTOlsERRkT6IKr0lxcbAKEqXzpI0dzRrlaPCtYjoiCLdik5A56lKwy0Qvw8qDNE x64GEeTe/y6c20ojc6ISb08o56hY32VkVvE1XeaYcTN53Bp1sbKC4c1JXY+KGz8AnNEL jCTM2Y6Ezcj3tDanYxzt+ecCf/KfpXE19zAoniNC98s3LkNqbuigLrXvHO6UH9aEACKN 2MxljPWvVMmnaAC6SasxXUL+4DEGJ25iaZoJKboumNt6LJ8tsig8GqQ1tzYTgSHYShst GDrfF+BvqpPYSzukZlbWwKn0Jvj/8uQJXNc1/KOCIS7BpBGu+J4A55fPIgD2uQE0B4OL gChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A76W91hpjSHLEadLCV7UGDDYEI7ysSho3oO5IxxUOCo=; b=VpUc/oI+clsvVhfKsNUWiQsJph3Qx/tSOTVqIqLUNlt5R2TL5bPPP8flQf/Z+uwCtZ rhibWbXNh1BSGJ0PYZltiAEWScMNda7yYDgEptKtU1dnJSVXzzGBbdjpjrXQJSWh/bxl TCvt1CHHvSKcC9tvqT+Svpvbj7uDdIBXU7yRCIjDvay3uzelSpNegNLnH4zSsS5Qt+Hr qMRhCsWAUUQDawZeqTD2LBFmVmkAR5MEuC9mtxFO0df7ZNzE29pgLVg6MzuWgISVtLSD 4NSsyZfvqioQWEt9j7QnQim/ftawqVSxmMVQwJE4s2NxoncTRBn5WuTnHyR82jr3WCKW 4pgQ== X-Gm-Message-State: AEkoouu/LOfJ1fgZ5qOrw026f1S4OiKe4t8OB3faLV9idkDdksyyUGrhFbPsigkMgbjPWzGDTh9ocdsDgk4OYN9T X-Received: by 10.28.107.88 with SMTP id g85mr14434724wmc.49.1470638198410; Sun, 07 Aug 2016 23:36:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.3.138 with HTTP; Sun, 7 Aug 2016 23:36:17 -0700 (PDT) In-Reply-To: <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> References: <1470406171-24754-1-git-send-email-ferruh.yigit@intel.com> <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> From: David Marchand Date: Mon, 8 Aug 2016 08:36:17 +0200 Message-ID: To: Ferruh Yigit Cc: "dev@dpdk.org" , Helin Zhang , Konstantin Ananyev , Wenzhuo Lu , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: move PCI device ids to the driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2016 06:36:38 -0000 Hello Ferruh, On Fri, Aug 5, 2016 at 4:09 PM, Ferruh Yigit wrote: > PCI device ids moved from common header into ixgbe driver itself. > > KNI starts using pci_device_id from kni/ethtool/ixgbe driver, this is > only for KNI ethtool support, KNI data path is not effected. > > Signed-off-by: Ferruh Yigit Thanks for working on this. The only thing that bothers me using this ("unsynchronised") internal pci device list is that, if people were using the ethtool part of kni, there would now be devices that won't be recognised anymore. Is it intentional ? If so, we should explain why in the documentation. Same comment for the igb patch. -- David Marchand