From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f195.google.com (mail-io0-f195.google.com [209.85.223.195]) by dpdk.org (Postfix) with ESMTP id 319D51B40D for ; Tue, 3 Apr 2018 11:07:11 +0200 (CEST) Received: by mail-io0-f195.google.com with SMTP id l3so21123389iog.0 for ; Tue, 03 Apr 2018 02:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+l63ndO830tnOzQ5GWr8KqRUrar4kSXJFg9kGPEACFY=; b=TO3DjiIRc5k5l7CoEEdB5plVVLVF1d99Nw5GKw4fxfCUFZsDSZ6yrwg73/U7Ft7Ji+ YwqgZsVb8vvH5oVzXZuNjXEQNFDl3/qPlx6ivVEOc/A8lm4De0e723xjyG0mSP4pd6Fe zHK3Jy7FqMDc5H2HJtw3/sEvUlHmifsVnN+ON2uS7BnI+CNAFN2zUBS1WArdKe+ncs1P 8scp9RkAm7X0NEussuGdLjaKr36pCSH/pBrSMCeFcOrZBdVzSs9OH6ytrHa+9rhKQE1b xneUA2lPe9KC23Nwvdy5jEGc3hDeNwMKIJF6c4cNFo2WlsBErjEu3P9mIKyqLhV8pxUL 2rUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+l63ndO830tnOzQ5GWr8KqRUrar4kSXJFg9kGPEACFY=; b=RnejAcjKR/LjSIP1NsJdbm1OqcCxjz4Tj12T3SJav9nDBEWJc0RxN0s0Ix9CwCzUV4 7Wb0j/cUJoNMiwwGTKTO21J+qcSiTdy2WMF7v2EuIrWBRrTynJT+Tk9c5R31dHPHlz6L puCVfc8b4QzPGhV4WPnN3ipP4h50XgD6pFXVRdj9Rc9+eozi5caXNdmz30xfa5myJsw7 XHnHPCpTMzzx0gDQflGBlAH44LWvjuEyu9LvkWLkpYFWIIfKteLUPzWX0XR1hWWZTd4E nVoARIZKzJpwFrb6tHtsNWeZCIGESbZ0iWYCSTbztQRc4zUcsXVhf06TdojhDwBe20cQ s2+w== X-Gm-Message-State: ALQs6tAnQtgGWsBiFkYjKk/A2ZHJoaP+6Exs9F1h331B0Mhw9GnKh0pU d4N8PgV3+32j21818rHs9a04kQ97EX4wIma7SUIEzQ== X-Google-Smtp-Source: AIpwx49zIiGcEMkU5T3y7RAflBDNnkfi4rZla4FAMABJcrZqGq2wVQ+sbWehfMimi95JDN3i82cmRYQLL43wAeRGNKQ= X-Received: by 10.107.68.3 with SMTP id r3mr10735879ioa.8.1522746430307; Tue, 03 Apr 2018 02:07:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.165.1 with HTTP; Tue, 3 Apr 2018 02:06:49 -0700 (PDT) In-Reply-To: <08358c50-1076-21c0-cf79-25d7a25d6255@caviumnetworks.com> References: <20180329175206.127943-1-ferruh.yigit@intel.com> <20180330151704.183495-1-ferruh.yigit@intel.com> <08358c50-1076-21c0-cf79-25d7a25d6255@caviumnetworks.com> From: David Marchand Date: Tue, 3 Apr 2018 11:06:49 +0200 Message-ID: To: santosh Cc: Ferruh Yigit , dev@dpdk.org, Shreyansh Jain , Allain Legacy , Tomasz Duszynski , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 09:07:11 -0000 On Mon, Apr 2, 2018 at 6:13 PM, santosh wrote: > On Friday 30 March 2018 08:59 PM, David Marchand wrote: >> I can see we enforce the driver name by putting it after the call to >> .dev_infos_get. >> http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.c#n2399 >> >> octeontx pmd seems to try to do something about it: >> http://dpdk.org/browse/dpdk/tree/drivers/net/octeontx/octeontx_ethdev.c#n622 >> >> Not sure it does something, might be a thing to cleanup. >> >> > In case, if your referring to driver_name update then > indeed its a cleanup [1]. > > Otherwise, I don't see any issue with v4 Or > may be /I /misunderstood your comment. I agree there is no fundamental issue. dev_info->device = dev->device; RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); (*dev->dev_ops->dev_infos_get)(dev, dev_info); dev_info->driver_name = dev->device->driver->name; If somebody (I mean some pmd out there) has a usecase with dev_info->device != dev->device, why not. Thomas ? -- David Marchand