From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f195.google.com (mail-io0-f195.google.com [209.85.223.195]) by dpdk.org (Postfix) with ESMTP id 2B3731BAC0 for ; Thu, 26 Oct 2017 13:39:29 +0200 (CEST) Received: by mail-io0-f195.google.com with SMTP id p186so4633303ioe.12 for ; Thu, 26 Oct 2017 04:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EwWoHaJVf1+aEYQ8AvG2Zimh3up/gliKbFNBKcknlS0=; b=Bv6sRoUWEKMdZRN3vcu0TkQ1/d6QxfXpjmwurCl24Ve7tUXyTob2ZwvpQcCbwvcMVl SY9X2xj/TQmyliLRmj1Tl0nIVh63vUtjIp+rdurEbib4e07wn0uiwSI6VxYL/zFbweZT qqRAAFW5YnLTVuV6rFqgDeLCpClW1KtWANGOIQaxgwVT+/todY7hmys+3zH94t4MqDL9 +J2GWcN5m/0/9+aikxHNSr77vvZCeyjAYxksYpxdFr7UZC4197FCmdSO+b/+DaRF5UoE SHnGx/7SR5fMGeTCnKb4AlAhCqb9CPFiM0yCS/IKbbFvn4+PXO1YtHPujGsCQUnErCxT Frrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EwWoHaJVf1+aEYQ8AvG2Zimh3up/gliKbFNBKcknlS0=; b=OjMjHhj7EA3Tr+k3NFm/0TDTfAonC1AeY6CUwDFb4zJPXzd8FxYaHmy58LzJDvutDz Pt+35qRKn8a6H1WQdJWD/IwVxO+99dpb6r+6pDOG6fcezfUkeWcmgGvTTMCWQsVTCRLi WYKaGktXlfgQfpTjq4UFjNvXM4uGBvxdGsoPCGIFq7EPXSRQQDCoTIYt4LP11ERT6OZ/ iaayQnXrO3jKjoWqqf51lEQpnHGQbkZi7EaGgnTyQ0DgwMz80jiGEld0hfoTZqVj7ry5 4F+JCZ2Jy033eK8ARBLM41+P6nP0c8FW9UvyIEaTZ1rq1jF6CnxIdyuOwdrwkLkZaF5u wW7w== X-Gm-Message-State: AMCzsaVnmBB0BatrCD5mbohF6Hk+moB5IEw8Sv8t+2WVZ7JFuGuQp8sS IbykufzyKVBGW58P+omhxWhEtyk6wJK75Yff4MZq0Q== X-Google-Smtp-Source: ABhQp+RiWebIGEeYGPBOJtPNCTPei+Z7MUD0gWp1lWbO1DJOjAj3XWV8ViIaV4GI8P1BHRccmq71KULwBB+HWhpWAPA= X-Received: by 10.107.184.138 with SMTP id i132mr31228814iof.155.1509017968393; Thu, 26 Oct 2017 04:39:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.1.82 with HTTP; Thu, 26 Oct 2017 04:39:07 -0700 (PDT) In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAAF5A7@IRSMSX103.ger.corp.intel.com> References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <1509013365-13819-3-git-send-email-radu.nicolau@intel.com> <36c6304e-cd1b-9bd9-2c5d-c6e20eff85e8@intel.com> <2601191342CEEE43887BDE71AB9772585FAAF5A7@IRSMSX103.ger.corp.intel.com> From: David Marchand Date: Thu, 26 Oct 2017 13:39:07 +0200 Message-ID: To: "Ananyev, Konstantin" Cc: "Nicolau, Radu" , "dev@dpdk.org" , "Doherty, Declan" , "De Lara Guarch, Pablo" , Hemant Agrawal , "borisp@mellanox.com" , "aviadye@mellanox.com" , Thomas Monjalon , "sandeep.malik@nxp.com" , Jerin Jacob , "Mcnamara, John" , "shahafs@mellanox.com" , Olivier Matz , Akhil Goyal Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 11:39:29 -0000 On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin wrote: >> -----Original Message----- >> From: Nicolau, Radu >> It can be disabled in the code, but as far as I know there is a general >> push back against having conditionally compiled code. I originally had >> the security sections in ixgbe PMD isolated, but the feedback was to >> have them always on. >> An alternative solution will be to remove the option altogether and >> always build rte_security library. > > My vote would be to have it a mandatory library for ixgbe. > Add it into DEPDIRS-ixgbe inside drivers/net/Makefile or so. And then librte_security needs librte_crypto (if I am not mistaken). So if we go this way, we must ensure the same is done in librte_security. -- David Marchand