From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by dpdk.org (Postfix) with ESMTP id F00D28DA1 for ; Tue, 19 Jan 2016 09:18:01 +0100 (CET) Received: by mail-ob0-f173.google.com with SMTP id is5so181013305obc.0 for ; Tue, 19 Jan 2016 00:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=W9I2dHS9qne84ASz69OyllUXffzwworlNEEmEmevsGY=; b=c3tEAf72ix6GOhECN5pFKDaTqxgOS4+84D4ACURExezf6CgfIM3Zmqy5JX4DHIi+hc 1+AVFkthujj/QmnwyBSu2xtpNfz2JcIECttYacWk07xMQZFP1I04Qgv3r+sUuq03aZoX 968bQQ5cSJZUqiIEyul635ZtTpcjkB0LTa0S+UIp+wcjTRpUu9Vv7ncA106PgMI8VNcf QSGo7TdYWoYxvQ9Mxwhv9HTM3+RKU0oZoN38Kjr1tgpN6B0oy0zSj34+BVyC886BAOqw qlRZSOe2307+pGPNdY138lquEtJFXdlE75uuIISIt1hcm3j/uIyJ+vCzbeBPDae1MVe4 m9JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=W9I2dHS9qne84ASz69OyllUXffzwworlNEEmEmevsGY=; b=GtyEVJaGMStb+4Cygzp8/HQxD0d57XpWfja0s1vHQIneJCAzG8c/iqPanpqWgLJxUh m0sElL2fM7Cx+3VHmiL2KQK7PW7SVdtibanmHzFsAzEu85HvODA5z9AU6fn1su9NlpUp HJN7K8zaCo8X1jwuZe4TNYSE23ItKqJr0NDBWIOB3hLAUxBNNtnKsxTqv2nwDfZtgcpC Bei+ADX+7P9kTrrkK7yIhLcmjy+uupD1B6wNOC3oWfnvJjyL16Tl3ytbQJPk0HYE+Ct0 kwwYZ78LSXF9YVP4aT03kvZ3cO3oXhD4q6lRpisw85IUvo+KwEYW+8+rDLFEtAH8KpYs dxgA== X-Gm-Message-State: ALoCoQm3DSWdM2AFh71gPG79Zu98UIeQFKdQAju3JlCgS7wQETBBuiGPghQ+B6bf85kqMuv9CYB4esEDnxOAv2IH0YWdxAsQwoDkEE9gcUdG0jaIRrVclcM= X-Received: by 10.60.82.101 with SMTP id h5mr22041537oey.44.1453191481384; Tue, 19 Jan 2016 00:18:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Tue, 19 Jan 2016 00:17:41 -0800 (PST) In-Reply-To: <1453191125-26335-8-git-send-email-yuanhan.liu@linux.intel.com> References: <1452832571-6156-1-git-send-email-yuanhan.liu@linux.intel.com> <1453191125-26335-1-git-send-email-yuanhan.liu@linux.intel.com> <1453191125-26335-8-git-send-email-yuanhan.liu@linux.intel.com> From: David Marchand Date: Tue, 19 Jan 2016 09:17:41 +0100 Message-ID: To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 7/9] eal: pci: export pci_[un]map_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 08:18:02 -0000 On Tue, Jan 19, 2016 at 9:12 AM, Yuanhan Liu wrote: > Normally we could set RTE_PCI_DRV_NEED_MAPPING flag so that eal will > invoke pci_map_device internally for us. From that point view, there > is no need to export pci_map_device. > > However, for virtio pmd driver, which is designed to work without > binding UIO (or something similar first), pci_map_device() will fail, > which ends up with virtio pmd driver being skipped. Therefore, we can > not set RTE_PCI_DRV_NEED_MAPPING blindly at virtio pmd driver. > > Therefore, this patch exports pci_map_device, and let virtio pmd > call it when necessary. > > Cc: David Marchand > Signed-off-by: Yuanhan Liu > Tested-By: Santosh Shukla > Tested-by: Qian Xu > Reviewed-by: Tetsuya Mukawa > Tested-by: Tetsuya Mukawa lgtm Acked-by: David Marchand -- David Marchand