From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com
 [209.85.214.177]) by dpdk.org (Postfix) with ESMTP id 65DE03237
 for <dev@dpdk.org>; Wed, 27 May 2015 09:43:10 +0200 (CEST)
Received: by obbnx5 with SMTP id nx5so1356058obb.0
 for <dev@dpdk.org>; Wed, 27 May 2015 00:43:09 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=kVRacKh92zDiCWz2fHle+SEiFwFsOhQYhNYpVXZA4/A=;
 b=GQszeqyJJhTtONJLFBl5spljR2i5RmntrY/Bu3UDPrTfc8cycN26mbc02BxenllCk+
 rz0ajIkhAGhSGoDi4MJ9/jWKmrHC38MvtCN1P1T+ew58tQV63O6Bhni1N7uM63zejVtO
 eJrGDdxAujuLnfon7jlTVK7DWCFPeN/JxcweKvA0UiWoBKaUNI4O9QSDNbP3kia7o9aU
 k3XDDfiXA31CW1sZJy+41yS5ficHSdLj7VXmALAV6mvtHWSBtLThAnfYRHDeJyM9Y0PK
 QE2Smfj6zimKwpTDTdNSOFF+mOePWLHpmS7xS9xkMhmvLVJaKZSjoWd4mRK5YEKNqudY
 6w2w==
X-Gm-Message-State: ALoCoQmj7RZRp717KD/pjav6JIIMv41m5kmG7hpdOPSyzwX1XddzbmeoGIKGEkqcKsWtOVahaiks
MIME-Version: 1.0
X-Received: by 10.182.79.129 with SMTP id j1mr7046132obx.72.1432712589686;
 Wed, 27 May 2015 00:43:09 -0700 (PDT)
Received: by 10.76.25.69 with HTTP; Wed, 27 May 2015 00:43:09 -0700 (PDT)
In-Reply-To: <20150520142427.4b977210@miho>
References: <20150520142427.4b977210@miho>
Date: Wed, 27 May 2015 09:43:09 +0200
Message-ID: <CALwxeUtOW7o5PCpG0vXhp9JqOppw+71aEtnFXud2U1HaXnKKpQ@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and
	--no-huge
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2015 07:43:10 -0000

Hello Simon,

On Wed, May 20, 2015 at 2:24 PM, Simon Kagstrom <
simon.kagstrom@netinsight.net> wrote:

> Needed to run as non-root but with higher memory allocations.
>
> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
> Signed-off-by: Johan Faltstrom <johan.faltstrom@netinsight.net>
> ---
>  lib/librte_eal/common/eal_common_options.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> index 8fcb1ab..89b867d 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -851,8 +851,8 @@ eal_check_common_options(struct internal_config
> *internal_cfg)
>                 return -1;
>         }
>         if (internal_cfg->no_hugetlbfs &&
> -                       (mem_parsed || internal_cfg->force_sockets =3D=3D=
 1)) {
> -               RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" canno=
t
> "
> +                       (internal_cfg->force_sockets =3D=3D 1)) {
> +               RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot "
>                         "be specified together with --"OPT_NO_HUGE"\n");
>                 return -1;
>         }
>

Hum, d=C3=A9j=C3=A0 vu.
Well, I asked some question last time :
http://dpdk.org/ml/archives/dev/2015-March/015867.html

This patch looks good but since I don't use this --no-huge that often, I
would like to know how you tested this.

And please, when resending a patch, it should be marked as vX.


--=20
David Marchand