From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f67.google.com (mail-it0-f67.google.com [209.85.214.67]) by dpdk.org (Postfix) with ESMTP id D1BEAA84F for ; Mon, 2 Apr 2018 11:40:23 +0200 (CEST) Received: by mail-it0-f67.google.com with SMTP id 19-v6so17692799itw.3 for ; Mon, 02 Apr 2018 02:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8JXa1EZEVcTZUTCcqszYUtcHGqqVynhmPE+H9nKTquM=; b=m+npvTCjOxNv/4YlHbJq4+OOzayQyrxOOn5uRb1mIc7RguBCT4ouR+uJCp9YXkDr6p oTdAExG1xPUo/CxhJ/+qpm4Q6/rHKnutrfdMqDsAXFUo5DCkEAlSUrCXb2v48aTtQ0yB cXjcjPflcP2wRvYf8E6yoWRaeQsrmU5e7lXJiUQCHAs7mMmYtUUYPVFs8g+xUehrgYXt rIekciiZ6eLPBWiBrIaT7ewxkk8qGd+tZFQ3B4hLq609oHWHCzRW8ngtrlj7u4wdx03T o5AWKhH7jknXRwLeGCTfw7SCrIK2raNSKAZqVr2o7s1DVwb5QTrLTo87P/fajFKsBNXB 1Z5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8JXa1EZEVcTZUTCcqszYUtcHGqqVynhmPE+H9nKTquM=; b=J1XvntD6warpdCAGRzPo/6Kg596cax/ggQ+C6LWSUPMl2vW1jBg6C1+A7igcdIBlbb brsnxR3LnBV2k5QQ3z3CVIdswQFtmiQV1bJZ3Y5aM6sE5qx9lwiGB1zkGGX2aAO5mZyN Jpu8ECv+fMdH0iRuRLsVBoJozKiAHB2VN9zJ+zEv/Jm2+4s63agFGODklYO2SopxsVsS VgUBgl29hdekycMgzR/5wnEB4ZqjT3AM67aeAxAzi1YtYcI1UqrTzOYOYia31Z+//Mbc MeY41IAMuIkLUzg+xSwiFiZzbbAUy1QA8q3sPlTLGODkjB6X5b0e8u911qVsmMmy+Jqy l0gQ== X-Gm-Message-State: ALQs6tAyF/+FsdX1vG4qtgffNA9wszw+jpILB+KoE9kICHH6/dJFARSK qvuG+EZ1bcDj8DhhDYJ5XxJiR5D4un2eC36grYrygw== X-Google-Smtp-Source: AIpwx48g+2u0S74F8+rUZ+QDnPlecFpzl/S2kP/dOhjDAQr8e6HtlOHgmvvRV8ylbA1Vu3NWVe5pZtHOpY1F+9BUxCE= X-Received: by 2002:a24:30c:: with SMTP id e12-v6mr312031ite.50.1522662023043; Mon, 02 Apr 2018 02:40:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.165.1 with HTTP; Mon, 2 Apr 2018 02:40:02 -0700 (PDT) In-Reply-To: References: <20180329175206.127943-1-ferruh.yigit@intel.com> <20180330151704.183495-1-ferruh.yigit@intel.com> From: David Marchand Date: Mon, 2 Apr 2018 11:40:02 +0200 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Shreyansh Jain , Allain Legacy , Tomasz Duszynski , Santosh Shukla , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 09:40:24 -0000 Hello Ferruh, On Fri, Mar 30, 2018 at 5:29 PM, David Marchand wrote: > On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 209796d46..68bdc3103 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -2421,6 +2421,7 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) >> memset(dev_info, 0, sizeof(struct rte_eth_dev_info)); >> dev_info->rx_desc_lim = lim; >> dev_info->tx_desc_lim = lim; >> + dev_info->device = dev->device; >> >> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >> (*dev->dev_ops->dev_infos_get)(dev, dev_info); > > Just a little comment, do we want the pmd to be able to override this ? I still don't see when the pmd would need to override the dev_info->device. The pmd is the one that populated dev->device in the first place. Why would it want to report something different in dev_infos ? Some comments from pmd maintainers, maybe ? -- David Marchand