From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 2EBBA2E41 for ; Fri, 30 Sep 2016 17:19:28 +0200 (CEST) Received: by mail-lf0-f43.google.com with SMTP id y6so109683781lff.1 for ; Fri, 30 Sep 2016 08:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bYh62h4/paV004di+xoG87yRJppLynQ6hV+VqOVSyt4=; b=fbZeSraBGMap/OHy8xgv40FIi3FjyJv2/EV597mkVR5mUeSwzIBR0VoJQ7YZ/1R2Pp ciIPd5myz291EGXpgoYSQQnbk+GR3hpOMVD2be1+lN7S1Ta8b20tmeSreROtzDmQeSff Dg72HJbR3XN3EmXMffWQJ+zTVl5hCfEyfhlAfLBzfn+wmR9qHlRP8DfU5bxOC4TZGN9f Nxofe7vidFTG/cD640g9WCiu3l/jwX87ztpaZn9WLAdDckdD9EZ8YGeTNbveIWElxxBD fnWK83xGWThcKBefMc7YhpKJIxZzh23G9ik2KpYzFUz08Eg7kx2sK4b7qxNdvZB8nWOK 5CWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bYh62h4/paV004di+xoG87yRJppLynQ6hV+VqOVSyt4=; b=X3yuWUYpPb166Q852DuzcvUDoinXMCaBrgb0KAGPXkKeMaDgddt46oswC+6bLy0sP9 qbFhlzFiuYGw9PmXULDMwmr6dULD6THQhIcfXoZCsUP52AwRu5XnSlJbJmvBctuIp+RY 6jN9RK8ED/WcWVYnMTJw+lqXobzIOSjZiv3Sy02qSw1I54wdR3HyoxABuP4sDbg2dzEN JRaTl9TmZa4yjriPhthyG2xCgSiidvWPgup6htBJODhn8LteHvr2lrUwMxxyi1jUyuYv SBGSva3aFjIWDxJits1XoGkxSg8OBZL0R4hs0nVDW5LwrLIpVM1n3ce6dxFHahyiR/Un QdgQ== X-Gm-Message-State: AA6/9RnaniF2PEkunB3G3aYN5D1QuZMs/oROL7MmJrpICm0KL3wVKxpI927uATWyCDlJs5runXkm0P1eSaaj3S/P X-Received: by 10.194.157.164 with SMTP id wn4mr6678653wjb.142.1475248767764; Fri, 30 Sep 2016 08:19:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.95.130 with HTTP; Fri, 30 Sep 2016 08:19:07 -0700 (PDT) In-Reply-To: <1475113270-21983-1-git-send-email-zhouyates@gmail.com> References: <4622854.nVE6J4R6pe@xps13> <1475113270-21983-1-git-send-email-zhouyates@gmail.com> From: David Marchand Date: Fri, 30 Sep 2016 17:19:07 +0200 Message-ID: To: Yangchao Zhou Cc: Thomas Monjalon , "dev@dpdk.org" , stable@dpdk.org Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] pci:fix missing free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 15:19:28 -0000 Hello, On Thu, Sep 29, 2016 at 3:41 AM, Yangchao Zhou wrote: > Signed-off-by: Yangchao Zhou > --- > lib/librte_eal/common/eal_common_pci.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c > index 7248c38..eb44998 100644 > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -378,6 +378,7 @@ rte_eal_pci_detach(const struct rte_pci_addr *addr) > goto err_return; > > TAILQ_REMOVE(&pci_device_list, dev, next); > + free(dev); > return 0; > } > return -1; > -- > 1.7.1 > For the title, how about: pci: fix memory leak when detaching devices Afaics the fixes tag would be : Fixes: dbe6b4b61b0e ("pci: probe or close device") + CC stable -- David Marchand