From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 745175594 for ; Wed, 16 Nov 2016 12:24:01 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id g23so232846161wme.1 for ; Wed, 16 Nov 2016 03:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WJQROo9QC66hBfqh7MDQlNEqZsapU9kvjWUF2Tj1RwQ=; b=JahsaTIx47qN1D0kybBH7CD9OL9bTmnaVmtnyZpNTkfywrMo8laXawi1imirGF8+Bz v/H/2OdwFBcpOHTfeNj2bv5YCuvN6Mxy148aey/d0eeygwUvAipBC4GlLheYtOqJjqRt X2A/rEYYG46UxBhsYao1kH6Hu8BYbqAhN7WR5AlYvDPKAmu6AO32V+yIkQMQxPETsQJT FF3r2LQjszekjAiNcEqqpVWKJmx6wpkhxZp8ZftWLue8bgE0NpAp3L0Z1QjoKC+V2BCM Kgi9ib3ndLBhkZ5BAAL1XdQ9ipEa2JZncGNZK1UzUYjj70YTYBPczhRykn3dZICGBIBb pBkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WJQROo9QC66hBfqh7MDQlNEqZsapU9kvjWUF2Tj1RwQ=; b=EwNmGESbrNZ8hSPOvWr2FgHZHiI6ecC7tNFausSFCITn9BYBzCvF/Xu0mjFPBUgpfm 8iKAS36T3ovMYpZGBcr8/xJGDZCwcIUT7XKaN1vcMzjgp8SgqGnXe9GXzYbkLJLGadz3 hT3+UalBoR3kfIa982Ll+FabpkIilgAmK9C8tuvVh9I8EobHLJlZY6nRU7LdcgvLupZW iFCY0kIceDo0O5eyhyzVvCuXoqsZjuRlPsRfePGN7zopnvN7u1difXRjKw4kYeP+qOss tt5JXP6V6YpC5+EJU1PbMa7+iW0feSk9WasgHva6go1kF5pByMivxnwvNghITTAwj5/G me5g== X-Gm-Message-State: ABUngveJ54XyrOEo9oCwclS/LLEGVZtA9EwxWq2pKxY7sUckpOdHqPirqY277i6EZaO404yY4BpEb7trG+tSfwAd X-Received: by 10.194.115.226 with SMTP id jr2mr1515268wjb.75.1479295441105; Wed, 16 Nov 2016 03:24:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.188.6 with HTTP; Wed, 16 Nov 2016 03:23:40 -0800 (PST) In-Reply-To: <1479264047-67966-1-git-send-email-wei.dai@intel.com> References: <1479262339-63608-1-git-send-email-zhiyong.yang@intel.com> <1479264047-67966-1-git-send-email-wei.dai@intel.com> From: David Marchand Date: Wed, 16 Nov 2016 12:23:40 +0100 Message-ID: To: Wei Dai Cc: "dev@dpdk.org" , "Burakov, Anatoly" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v2] eal/linuxapp: fix return value check of mknod() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2016 11:24:01 -0000 Hello Wei, On Wed, Nov 16, 2016 at 3:40 AM, Wei Dai wrote: > In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c, > The return value of mknod() is ret, not f got by fopen(). > So the value of ret should be checked for mknod(). > > Fixes: 67c536bdad93 ("pci: move uio mapping in a dedicated file") The commit you are pointing is just moving the code. I would incriminate f7f97c16048e ("pci: add option --create-uio-dev to run without hotplug") The rest looks good to me. -- David Marchand