From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 867FD2BDB for ; Wed, 10 Aug 2016 14:07:24 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id o80so99122593wme.1 for ; Wed, 10 Aug 2016 05:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xnvBsiZzDYWsy3yrN696e1YsikX8odkdREh2vGj/YE8=; b=lEgzmc8496aS7YZmprh1Vg8xo1kRbibIpf2LdpaSwdTNEg+24/H5Eaxjda2rGAk0+9 Svlxcl6Rs+m365KmhC/mGMpPYm7/ytIM2/WBKd04bp59JnxxpWZlbh2lEx39obIhIJvJ 3spEvnvFasyZEojuutxxKR0QrSB+XvzKqm6JsUiQs/OKw+EM2JXszf+iv+6OJ91zy2cJ axwodos/zEw2BKvLfRr+wDm9Ok2qjO83nH62HVtWMF+YfOPUA1TPecebf8xvJKeVTAwD IVtNxKQpViKx4/S5g0XoGNZPattqQ/D9vOxEaOvjJLk2irdCfad53cE8URPo8Ca4Nio/ C3aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xnvBsiZzDYWsy3yrN696e1YsikX8odkdREh2vGj/YE8=; b=mJGNtxHmTDIIc6J8mk60ijmQt5g7sx0BzaUvD+dfiKlCku6dzbQfi2WzQ3vj6DmLWj P27QQlgPSuWrRQTe4grnE/RRCj9un3SVNc1+jGnjxWrweKi+iaAQWq9PZ6nyykqc6J3/ urPiJAkxgwfV7eH3IsDXcqon9NJzjkkIU4zzUkz1PeIzhfCDeaDh8AyaATVYN83PaxFT MiD6hCRIaPhPuD6o3qhzu5afY/Daz7WADcDZquugRacVxbDJw2ObQ/kKEO0qnZo6mnp9 Q3NFukFsE38M7+rus5F7Z887wqQffu1Zkc3wVKRt6u18fEkvTXR9xCcpPNOfNgG2YsOH zqgg== X-Gm-Message-State: AEkooussWLulD6un67DkJ/f/gTQ2GgbAZtDL6iH+bs6QkroF86GprZYS240eW2TOqGshLV0aPf2FzODFrmQbOhJC X-Received: by 10.194.48.39 with SMTP id i7mr4206614wjn.173.1470830844153; Wed, 10 Aug 2016 05:07:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.3.138 with HTTP; Wed, 10 Aug 2016 05:07:03 -0700 (PDT) In-Reply-To: <57A84C89.7050107@intel.com> References: <1470406171-24754-1-git-send-email-ferruh.yigit@intel.com> <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> <57A84C89.7050107@intel.com> From: David Marchand Date: Wed, 10 Aug 2016 14:07:03 +0200 Message-ID: To: Ferruh Yigit Cc: "dev@dpdk.org" , Helin Zhang , Konstantin Ananyev , Wenzhuo Lu , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: move PCI device ids to the driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 12:07:24 -0000 On Mon, Aug 8, 2016 at 11:10 AM, Ferruh Yigit wrote: > On 8/8/2016 7:36 AM, David Marchand wrote: >> The only thing that bothers me using this ("unsynchronised") internal >> pci device list is that, if people were using the ethtool part of kni, >> there would now be devices that won't be recognised anymore. >> Is it intentional ? > > I am aware that the list changed, but wasn't sure about updating the > list in drivers or not. > > If a device is not listed in driver's pci device id table, it may not be > supported, so ethtool may give wrong output, or it may just be missing, > this is hard to know without testing (although this was the case before > this patch) > > Since it is easy to add new id, and we are at the beginning of the > release, I was thinking if somebody reports KNI ethotool support is > missing for a specific device, we can add it instead of adding all by > default. Ok for me and with this we can know if this ethtool part is used :-) -- David Marchand