From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id E924A6C97 for ; Mon, 29 Feb 2016 10:06:08 +0100 (CET) Received: by mail-ob0-f178.google.com with SMTP id s6so78340755obg.3 for ; Mon, 29 Feb 2016 01:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QE5MkaT1r7EFiY7nElSVdXhxIdRXQ6JqP7F3xPHsugE=; b=0cTOh8m03Zl7KlxM68nqKVkxfAfn7mwXe7IRBPN6SEI8Piu/QKJFdSb7QZijE9rO83 O7vRKwVoIB+y2JYctUXy9kXvkn47f16zHUBTGLgSCp5gCY6jI2o6OCDZ3cMw1g3V+cAj iqhkwF7KhCuEagzVNsL/gCRtoIxxwstSl0/h9g9DrR2ky85MPuJjVcWJ9DMUslebyRys N2LdBJR/xozBkJnsMEcwKP2c1c1IPCFa9YN6uPUmGwibxIuqzHI1hoJz3teg06UgoSBN X+1MomFAKixqbL9ZrSV1FSk+3hj9+8dpDFc4ct2VVtJVtQ4tStxy+SmN1MhzdJaBFJpn 9r+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QE5MkaT1r7EFiY7nElSVdXhxIdRXQ6JqP7F3xPHsugE=; b=MdgifNnww3y1mqYG8MhwuJ+hJNyr2LjkLPthKuQFGPa46Qe8tEKss8amV5AZlCJJ65 /jalq9zRbnSDGlhHwK1OIZB6iTUghWmVxVinRgaGXDejYChHGeZpz6zEkTReUMK/IrnR SEVICkqkj+WO8t50KayjylkPk9gPCpIv6dnr2npKiv6UWW/jCzuzDyFwN+ZykbFp9tJk kGDwOvz86/OWqgANV8+Dh7I5OTHFPVBygPUmoIk0jwomE/L38QpAwVUCtAwyEyZQNL/W jSV0YlE2S777gZsPQ5kmXuq2CBLiyFz+1d1rLjBnG5FimPYDEs3K3eBw7gUHJluZ9Phc K4YQ== X-Gm-Message-State: AD7BkJJcDcP67w5rdfCJKcvdhLBASqC32xWSxI2bcKCuymKV6/9jfuV4nQguxUZ8aPzrcemyY1Er3+WNKKAyYdCQ X-Received: by 10.182.60.170 with SMTP id i10mr10610186obr.62.1456736768451; Mon, 29 Feb 2016 01:06:08 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Mon, 29 Feb 2016 01:05:49 -0800 (PST) In-Reply-To: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1456451636-118476-1-git-send-email-huawei.xie@intel.com> <1456451636-118476-3-git-send-email-huawei.xie@intel.com> From: David Marchand Date: Mon, 29 Feb 2016 10:05:49 +0100 Message-ID: To: "Xie, Huawei" Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , "Troitsky, Nikita" Subject: Re: [dpdk-dev] [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 09:06:09 -0000 On Mon, Feb 29, 2016 at 10:00 AM, Xie, Huawei wrote: > On 2/29/2016 4:47 PM, David Marchand wrote: >> On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie wrote: >>> v4 changes: >>> reword the commit message. When we mention kernel driver, emphasizes >>> that it includes UIO/VFIO. >> Annotations should not be part of the commitlog itself. > > Do you mean that "rewording the commit message" should not appear in the > commit message itself? Those version changes will not appear in the > commit log when applied, right? So i added this so that reviewers know Try to apply it. http://dpdk.org/dev : "Annotations take place after the 3 dashes and should explicit what has changed since the previous version.". -- David Marchand