From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com
 [209.85.218.44]) by dpdk.org (Postfix) with ESMTP id 3BE9EDE6
 for <dev@dpdk.org>; Wed, 16 Dec 2015 14:29:22 +0100 (CET)
Received: by mail-oi0-f44.google.com with SMTP id y66so24198438oig.0
 for <dev@dpdk.org>; Wed, 16 Dec 2015 05:29:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=BTwPWTv2DIP388P1GnzQB8L2Xh9cqkLoqdLFmXDS1yw=;
 b=Y+8a+cByap3P3iGsO9vdkjAEuqK7c4KzKt1scqJ58BLBzCmyF2AzINjbgsGEGP1Y4/
 UYfeUetLXU0xoKJywvD0WoN+0eBgVLibeKuuFQxURTOiqEZPr660Y2wjN7M9rkq17UXM
 36joFRYz1F1iZ3TTnxglYjkm0GRWI4jY1yT1csYk6BzKicmpKb3OIMctE8UAjSGzPgxt
 CEdwmfxy+NrzPdxQDvJN+u6P4uCzundTmUQ3o83IYy9olI9lEmFiEUd0ahzptPFDnjDW
 GVvGILZFZ0260pnoXW652tBIzuIWzvU/8i85sFoBc4/wrtBcJqdLzu/bXpyJOZ85LvM3
 /VuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=BTwPWTv2DIP388P1GnzQB8L2Xh9cqkLoqdLFmXDS1yw=;
 b=c/2qzU2XfU3LTaXBYkJ283XJBYMyOAv3GUBS0bB02X6RI4/FGRlGT+bACOJQ+owHhM
 3KbIrQjOAMLug1Vt4HCE1sIR5XA8bGDi3XkLZGSr5OvwUAwpEpUlGfGBOuXYbfETzYzg
 fMsGgJjL9NLGdV2fnsOmuWrM9titHmqaYt/KNz2040YBkAVbRKJI7uOWXG8bNhvhxMLi
 c6dz/3rnUORAfNXpOrBUvuKKjCZ4NbMRhnPhJJqUdVQ/oKn2hmc8KH/6kibOf+xDMUHe
 pV9ibUNaOWSKsXdX5GzB58jx6OuJSUaiv9z6X7JOqYoxRUbBwYkTjO/lqjSGVwx8mX/y
 uPjA==
X-Gm-Message-State: ALoCoQm41rTFiTDqA0ASkaXjXirLXegK73Fv+0fQOTySAkCARiCvKzcB7haa1UKOVrMI60tIut+tI4usb4J8Q4HD7CdqNGcV7nvZohPBduLkYaSdAXN2hxM=
MIME-Version: 1.0
X-Received: by 10.202.175.22 with SMTP id y22mr15277067oie.22.1450272561635;
 Wed, 16 Dec 2015 05:29:21 -0800 (PST)
Received: by 10.76.153.5 with HTTP; Wed, 16 Dec 2015 05:29:21 -0800 (PST)
In-Reply-To: <20151216131540.GD10020@bricha3-MOBL3>
References: <CAAyOgsaMO7V1K8Yxh=Zf-E4iodDevMFG+rRBPgZXBysca9JopA@mail.gmail.com>
 <1450269064-23608-1-git-send-email-david.marchand@6wind.com>
 <20151216131540.GD10020@bricha3-MOBL3>
Date: Wed, 16 Dec 2015 14:29:21 +0100
Message-ID: <CALwxeUtt3fG8wL_TwXrnyL_=Xw2U+6NzQnLhq=iRX3-aEFTyPA@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: map io resources for non x86
	architectures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Dec 2015 13:29:22 -0000

Bruce,

On Wed, Dec 16, 2015 at 2:15 PM, Bruce Richardson <
bruce.richardson@intel.com> wrote:

>
> > +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686)
> > +             /* x86 can not remap ioports, so skip it, remapping code
> will
> > +              * look at dev->mem_resource[i].phys_addr == 0 and skip it
> */
> > +             if (flags & IORESOURCE_IO)
> > +                     continue;
> > +#endif
>
> As a tangential comment: We maybe could look to make certain preprocessor
> defines available as C globals as well. There is no reason that the ifdef
> here
> could not be implemented as a runtime check in C code.
>
>
Well, instead of having the same information as the preprocessor define,
maybe some capability per arch/cpu would be better "arch supports io remap".
Maybe we can extend the cpuflags ?


-- 
David Marchand