From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.marchand@6wind.com> Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) by dpdk.org (Postfix) with ESMTP id BABBF4C95 for <dev@dpdk.org>; Mon, 10 Sep 2018 08:06:42 +0200 (CEST) Received: by mail-yw1-f67.google.com with SMTP id q129-v6so7431903ywg.8 for <dev@dpdk.org>; Sun, 09 Sep 2018 23:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5YsmRaEaZjR9fNZK4RWK+3hn5EVZMwUKlUEwTQ4X6Q0=; b=gZJGhszMAQMFd7a7vs1y549DmAPkFZah+4I30y/AwVsNhB6mkedt7k7df6wONVTKzE 9qpKZWDHdUDtd6ucn1hA8CrFkjE6uEpPLu/53rWMtFn8cyjb3KvVz+446vTkn3w93lM9 NtrgRU9xCUIFiCiJwQEuhHeov2hlyqgHkqvy5K29of53vMker+0GUlpEBtsQFCpdq1/a o0/v8v+jhBILtd55VXrDI/Bh/zg3hNjAgTY2QKb1jszf4NLO7xqS5zbRF1LhcB4NUYGG vJMmTV3gAzgtgdSZ45423LLOdBen47Fz9XHHybECtq5XATnJC44tXc9J9fYqNh53wCaQ 8Hxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5YsmRaEaZjR9fNZK4RWK+3hn5EVZMwUKlUEwTQ4X6Q0=; b=rcc+35r1YQBg+aeAYl81qHmqLsfb5qQ3DSlGvj1pKa1j81d+0Ee0SBA71gLNpWh6XG w/yukM9RJZwps9xfFXLc43X3NzT2d7fvnVPFjz3ZdoxoiW3FhoLmDyIMG9E5RgFE1DLy 1LLNKb9qIyfnJTNgGoMV0MWJczWSyEOjozkZ8/i6ez2jJGJtbqSJcsmLOaNwllkNj2JK TYBxUtkw50bEZwrU8PSzBWs86xx+zWECp+nGkF7IgK4cpnHQEsbBItE3DJvzEXK4UAff PG3gj58ZFTKYR+tJ452kX+WNvKjHqZ0u+njR9YnPQu91mc1oAE/3FoaldJ3s5qF4sLlM hetA== X-Gm-Message-State: APzg51BiSg/9CDQzoo7okYCevR+/pqxzPtrRnObZn0Lqd70JkmpqUvKx BU7h7IH9k0Z8WDKygk/VRTxaEY407FlTFb1ksSr/iA== X-Google-Smtp-Source: ANB0VdaxToFAbsO3jrbbBXqZ7rWXvK7iBj4xvEFT/yefmixVk2SamvBPL/rCE1raS0Xy8DXvca117sD7v5QQ5mroowc= X-Received: by 2002:a81:3342:: with SMTP id z63-v6mr9391723ywz.305.1536559602077; Sun, 09 Sep 2018 23:06:42 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:4bc3:0:0:0:0:0 with HTTP; Sun, 9 Sep 2018 23:06:21 -0700 (PDT) In-Reply-To: <7301022.qQQo3EDiVl@xps> References: <1531745044-19185-1-git-send-email-arnon@qwilt.com> <1532643058-21027-1-git-send-email-arnon@qwilt.com> <7301022.qQQo3EDiVl@xps> From: David Marchand <david.marchand@6wind.com> Date: Mon, 10 Sep 2018 08:06:21 +0200 Message-ID: <CALwxeUtxeBtQyx2Sz8uVxOrToMvZ4PENEUJKCZML1b5AMhxG+g@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net>, Arnon Warshavsky <arnon@qwilt.com> Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, Declan Doherty <declan.doherty@intel.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v13] devtools: alert on new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 10 Sep 2018 06:06:43 -0000 On Tue, Jul 31, 2018 at 2:38 PM, Thomas Monjalon <thomas@monjalon.net> wrote: > 27/07/2018 00:10, Arnon Warshavsky: >> This patch adds a new function that is called >> per every checked patch, >> and alerts for new instances of rte_panic/rte_exit. >> The check excludes comments, and alerts in the case >> of a positive balance between additions and removals. >> >> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com> >> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org> >> Tested-by: Kevin Traynor <ktraynor@redhat.com> > > Applied, with small adjustments, thanks I get some warning when running this on Ubuntu 18.04. marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch ./devtools/checkpatches.sh: 52: read: Illegal option -d 1/1 valid patch + false + check_forbidden_additions + read -d awk_script ./devtools/checkpatches.sh: 52: read: Illegal option -d + awk -v FOLDERS=lib drivers -v EXPRESSIONS=rte_panic\\( rte_exit\\( -v RET_ON_FAIL=1 - + report= + [ 0 -ne 0 ] -- David Marchand