From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f169.google.com (mail-ob0-f169.google.com [209.85.214.169]) by dpdk.org (Postfix) with ESMTP id 3AEF62E83 for ; Wed, 10 Feb 2016 12:43:56 +0100 (CET) Received: by mail-ob0-f169.google.com with SMTP id wb13so23188207obb.1 for ; Wed, 10 Feb 2016 03:43:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=nQ/uJjsrmmZ17z17U++a0DGcjiE3NHJes4OYD7eida8=; b=UDIv6eM5/Ibp6YwbVUzd3Qa63hGFJxHR8i7uJFnQyxiU2ba1lloRuEEMKe0tnTPVKQ /GzGLpgzIuukxgj0xqfwWcI915Mv6ccvArNFX6fAy6itWDxPzZl2B1VgFoPlLlSgCMio ARc5vG8acQAzkZC4rowJrBObo5mn18OlEY1H9cXhxclv22zA20e8/AsDNJEcJ5YSVYCy HVNgxplU0tN8kBxRe6Yiv8qMwV85djd0kkI6UBzNxLDdXA5eOMK6611jhmKNud85ikI2 K3I7lvnphcbmUeDHoBOBS5fk4wmFYR5WdojxbSe1ch+2l8ihFrg3CedqRahGdQnFZNDF P6eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=nQ/uJjsrmmZ17z17U++a0DGcjiE3NHJes4OYD7eida8=; b=M1wFGQrQ/3omljhkP+JcboKITlM4gtZS0DDZC1yv2gCP8fTNAYEvli8x6eWRTU4c0a 9bORqNpAGR3HRMnmVmEPnEZE2SGxxRWrXAk/Tcil5iaW4C0R0XAkjnGKzlH8lPf3F7UR wutnVD/wjXvoUXDLrfRBjc0DEdBFUUdrZ77iGmNFNaWoPZZMDve+PzMOlz1/IXRqbivo 1dTwdjPQFXiSX62TjXpDWI1C9rIfssHYUL3B76nxRXyU2IKeFPvDCPgKqXZADsJ7/pW8 hKpSuyFqOpB5cf7YmJAPdMGc9KkftdKIwQ5v19acJ0EXoYTgFeaycPxW/HFXISbxbPxa yOZQ== X-Gm-Message-State: AG10YOQUggXDNk02yHLOO36gzrYXciUnMlPCug4xWxJUb7UctHYhBVGwAnEifREpAwApgL7NFezqHcHCgrhSYLke X-Received: by 10.60.127.166 with SMTP id nh6mr35461278oeb.64.1455104635719; Wed, 10 Feb 2016 03:43:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Wed, 10 Feb 2016 03:43:36 -0800 (PST) In-Reply-To: <20160210120556.0e06cceb@pcviktorin.fit.vutbr.cz> References: <1454076516-21591-1-git-send-email-david.marchand@6wind.com> <1454076516-21591-7-git-send-email-david.marchand@6wind.com> <20160210120556.0e06cceb@pcviktorin.fit.vutbr.cz> From: David Marchand Date: Wed, 10 Feb 2016 12:43:36 +0100 Message-ID: To: Jan Viktorin Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 6/9] eal: initialize vdevs right next to pci devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 11:43:56 -0000 On Wed, Feb 10, 2016 at 12:05 PM, Jan Viktorin wrote: > On Fri, 29 Jan 2016 15:08:33 +0100 > David Marchand wrote: >> --- a/lib/librte_eal/common/include/rte_dev.h >> +++ b/lib/librte_eal/common/include/rte_dev.h >> @@ -156,7 +156,7 @@ void rte_eal_driver_register(struct rte_driver *driver); >> void rte_eal_driver_unregister(struct rte_driver *driver); >> >> /** >> - * Initalize all the registered drivers in this process >> + * Scan all devargs and attach to drivers if available >> */ >> int rte_eal_dev_init(void); > > Move this to a separate commit? Is it just a forgotten doc comment? Should be in previous commit, yes. >> >> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c >> index 62241ee..95313af 100644 >> --- a/lib/librte_eal/linuxapp/eal/eal.c >> +++ b/lib/librte_eal/linuxapp/eal/eal.c >> @@ -834,8 +834,10 @@ rte_eal_init(int argc, char **argv) >> rte_config.master_lcore, (int)thread_id, cpuset, >> ret == 0 ? "" : "..."); >> >> +#ifndef RTE_NEXT_ABI >> if (rte_eal_dev_init() < 0) >> rte_panic("Cannot init pmd devices\n"); >> +#endif >> >> RTE_LCORE_FOREACH_SLAVE(i) { >> >> @@ -873,6 +875,11 @@ rte_eal_init(int argc, char **argv) >> rte_eal_mp_remote_launch(sync_func, NULL, SKIP_MASTER); >> rte_eal_mp_wait_lcore(); >> >> +#ifdef RTE_NEXT_ABI >> + if (rte_eal_dev_init() < 0) >> + rte_panic("Cannot probe vdev devices\n"); >> +#endif >> + >> /* Probe & Initialize PCI devices */ >> if (rte_eal_pci_probe()) >> rte_panic("Cannot probe PCI\n"); > > I cannot see the point why it is enclosed in the RTE_NEXT_ABI. Is it > such a serious breakage? No. We can make this move unconditional. Thanks. -- David Marchand