From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.marchand@6wind.com>
Received: from mail-ob0-f176.google.com (mail-ob0-f176.google.com
 [209.85.214.176]) by dpdk.org (Postfix) with ESMTP id A11CB5A32
 for <dev@dpdk.org>; Tue, 21 Jul 2015 08:14:35 +0200 (CEST)
Received: by obre1 with SMTP id e1so113939622obr.1
 for <dev@dpdk.org>; Mon, 20 Jul 2015 23:14:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=jZm1SqAhibcDSSYD9XtLxBhFUpJJ1G4k2JDjcdnPkM0=;
 b=DAL+n5obVAfW/jERfLgzTseY+bk4jb+iEgNep8Rd+VDjqotY1rcsEXYrJUO0Prt8vY
 hmERrBtBv+II/7Fyf1upNoGVDaKKnUfXvc+8mqBAIZHE13DDL06lPokV4WacXJ3y88Gw
 B5fC/E73BBL4T8zK+2lc2j4UpBx1b8huE3vpL7wdW+qHipoDvFPlNHfdHlS77g+cnD1F
 pRsRTvtQjw1P1IaCMn1RZR5dNTYYi+h0bvCqsfi5/Xs6QWZ2HXl0PMbWi96f7svqXs38
 egb4d/Bh79P0RR0jPW/+SrJ82/WpCzLTsDOWYIL67f4p9pcMUrndq8fo7PLxF3PBS6H7
 Avlg==
X-Gm-Message-State: ALoCoQk4lpL4RxkD9ZuLXYuw4020kLH2f5IkwHyTo7Zp2cxcwAXEScSA9nymxC9hNR5X11Kah+Tf
MIME-Version: 1.0
X-Received: by 10.60.78.104 with SMTP id a8mr29046022oex.58.1437459274961;
 Mon, 20 Jul 2015 23:14:34 -0700 (PDT)
Received: by 10.76.84.233 with HTTP; Mon, 20 Jul 2015 23:14:34 -0700 (PDT)
In-Reply-To: <5e6315c050b27539d567799a5b35c8cc9395cacf.1437392218.git.rahul.lakkireddy@chelsio.com>
References: <cover.1437373175.git.rahul.lakkireddy@chelsio.com>
 <cover.1437392218.git.rahul.lakkireddy@chelsio.com>
 <5e6315c050b27539d567799a5b35c8cc9395cacf.1437392218.git.rahul.lakkireddy@chelsio.com>
Date: Tue, 21 Jul 2015 08:14:34 +0200
Message-ID: <CALwxeUu1JPwFNKgR7Rw7o_kZQm-wnBzEnqnWL9Jz-YsCg8Jg2A@mail.gmail.com>
From: David Marchand <david.marchand@6wind.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>, Felix Marti <felix@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] nic_uio: Fix to allow any device to
 be bound to nic_uio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jul 2015 06:14:36 -0000

On Mon, Jul 20, 2015 at 7:31 PM, Rahul Lakkireddy <
rahul.lakkireddy@chelsio.com> wrote:

> nic_uio requires the pci ids to be present in rte_pci_dev_ids.h in order to
> bind the devices to nic_uio.  However, it's better to remove this
> whitelist of
> pci ids, and instead rely on hw.nic_uio.bdfs kenv parameter to allow
> binding
> any device to nic_uio.
>
> Suggested-by: David Marchand <david.marchand@6wind.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
> ---
> v3:
> - Use checks for bus, slot, and function info instead of vendor and device
>   during nic_uio probe for better consistency.
>

Looks good to me.
Acked-by: David Marchand <david.marchand@6wind.com>

Thanks Rahul.

-- 
David Marchand