From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) by dpdk.org (Postfix) with ESMTP id A18D81041 for ; Wed, 19 Sep 2018 09:35:21 +0200 (CEST) Received: by mail-yb1-f193.google.com with SMTP id w80-v6so1977685ybe.10 for ; Wed, 19 Sep 2018 00:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VEymcbngjyatTR/q2TyhyHBLZqtT64RBVLWf6DX1GP8=; b=p4atSlZOsjIdh0ZpJ+B0kFm3x56ZLM0F/tw1FhvucAttdZUCO6AfszLf5DD3QtTvMA Rj85NIbEvWdYQOX1o9qot9TFZx+7aZ3G8GPzaW9cfnZKdcDJmVMnEhpPwEOtz5nXfngW HU7vR42gaLklg1GyZneMn13tMrk8Uny4u2O6Sddp7N+8na52YJrV88UBtf4vavfTPbaa B+pOboxntdXapKwICBcYTq2348BasW3+86iObBVwfmZmc5HxmGQLseS3/VjB1aiw9b1/ z4PFHItQRp6/vdFRI6xbFLojM7b1bs36IVjMd56gLwOzQW7Lom3jYAawPuA96BWVhQnw vtLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VEymcbngjyatTR/q2TyhyHBLZqtT64RBVLWf6DX1GP8=; b=U2S8YXYThCqCGommm1wJozj4KFJHC9pCOWeU4XcFDzOfbGlbmbPCQvfCUMZL99rBWc xRYgrBeay4IxelIGOERJa+PzlVssylXrvRmjN+Z6Mu/k0RNTCgqBdyignKRYTdrUpkc1 krkFDsv8VQJA0dVaEjTpHCngwFoi88ycrMqXtEnSg9mQKmVQyIDRG2X+Ojk6dGcwScCk myTGT3Jp4nsjYamayAS/Xq4LbBDRca8vRSwGyIBSV4JTAYqtUBPDpYdVloXyHbO0rlfi DbQk992kMdhaWCpPnZwBEJK43UZub/CSCZrBv9u4NpUeCE2ZcLW7aJUfw0euypJYTEg5 hRWA== X-Gm-Message-State: APzg51CtJF4DMt3C0FpwYTx8hlTXIjyKwqradIZxXWYsUdM8KlmIlgPx a1JSd0dYjjL6eecSo8sdL5m5sVEpcpNWkC3cHZLuOQ== X-Google-Smtp-Source: ANB0VdY/OZT/WNUi70NyjszI0Rv8FoPYClOEzxD3LNpL6t+lN458ei1mwhaNRymxc1e2pGemRii2eJDggxWYylbnHOM= X-Received: by 2002:a25:b305:: with SMTP id l5-v6mr363297ybj.8.1537342519338; Wed, 19 Sep 2018 00:35:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:6fc2:0:0:0:0:0 with HTTP; Wed, 19 Sep 2018 00:34:58 -0700 (PDT) In-Reply-To: References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 19 Sep 2018 09:34:58 +0200 Message-ID: To: Ferruh Yigit Cc: Shahaf Shuler , Thomas Monjalon , Andrew Rybchenko , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 07:35:21 -0000 Hello Ferruh, On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit wrote: > On 9/4/2018 11:02 AM, Shahaf Shuler wrote: >> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: >>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx >>> >>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. >>> Without any specific Rx offload flag, default behavior by PMDs is to >>> strip CRC. >>> >>> PMDs that support keeping CRC should advertise >>> DEV_RX_OFFLOAD_KEEP_CRC >>> Rx offload capability. >>> >>> Applications that require keeping CRC should check PMD capability first >>> and if it is supported can enable this feature by setting >>> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() >>> >>> Signed-off-by: Ferruh Yigit >>> Acked-by: Tomasz Duszynski >>> --- >>> v2: >>> * fix flag check >>> * add KEEP_CRC flag into "show port cap #" >>> >>> Note "show port cap #" and >>> "show port # [r/t]x_offload capabilities/configuration" >>> does same thing, in long term I suggest removing "show port cap" one >> >> >> Acked-by: Shahaf Shuler >> > > Applied to dpdk-next-net/master, thanks. Should we have a little note about this api change in 18.11 release notes ? -- David Marchand