From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 307BE2A58 for ; Mon, 12 Sep 2016 09:16:23 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id c131so41497507wmh.0 for ; Mon, 12 Sep 2016 00:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F/rwn8tmPNOJrAyQLw8MQVLhZM/zlCQ34lDvIn4ogJE=; b=PaoPbrhEaCGWXJuJpmHYO6woT5mzyGyHOW65x3GWcOG4TR8gPsS8hGNpwWYbbMa9fk BKO9QBIolltXXSOSb6jlLfBZr0RQeRJ3PTT2eg54pGzxcrGZWVo88c8ub7e4U5hAwOoG Ruog4MSzskBHaCqlL82jkdqQKAVfI0JCNLskNicVaYI4hKU+krrLhAnqkPbXxMO5izft h3fXOKr6WrelRf88bAm4uh2QuNB2tWiRDQfP23G2jSmXM3RFSBoZyRJ18mkICj4hbTI8 mG2avd3ufdGY/plBttG/nfLcjJJKo7SLNx1qNhZUSWYjYocFuYPUoXeSww5NQYxTCQRZ vXPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F/rwn8tmPNOJrAyQLw8MQVLhZM/zlCQ34lDvIn4ogJE=; b=fw1OWr8vFQDYLdG4uHBfYwT6IZVgq2RaqO+zeAC7tZumX30kIJKKq94lhMpcmZ0PMD CF7zINpw05KzIDsEk4u9MtkpR0Z1+NALog9AhOUyS8bpXbtovo/sN2+NdYeo7MibQFAO k4RCCMxBQLF/L9Svl7qBJx6P740km8lMYTrfE6DRcwXeU07bWIlQj7sgnPo6zDt7yzva ICtJ6Dl0qBmHMAvJ4IBUZYwdt61O5UjF+AD3ALA1oFVHRFMo95GoJMDPwWuoRjAnL8xj q41U1MgQrv9Ps7BqjBtQAutznAYNfSToZ+sLt9/Two7ze/e1N7BkC4RhRE1r7UT/4JAn t9DA== X-Gm-Message-State: AE9vXwMTQPnVP+7dFwnPWizJ6JjBkv0aAW8Pf7zf+oCvymwdiThL7ng/l882mPqqfGnhKn3ipRTpTK5cVmyrieC4 X-Received: by 10.194.192.35 with SMTP id hd3mr13652870wjc.27.1473664583005; Mon, 12 Sep 2016 00:16:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.97.213 with HTTP; Mon, 12 Sep 2016 00:16:02 -0700 (PDT) In-Reply-To: <1473257297-7221-8-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-8-git-send-email-shreyansh.jain@nxp.com> From: David Marchand Date: Mon, 12 Sep 2016 09:16:02 +0200 Message-ID: To: Shreyansh Jain Cc: "dev@dpdk.org" , hemant.agrawal@nxp.com Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v9 07/25] driver: init/uninit common wrappers for PCI drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 07:16:23 -0000 On Wed, Sep 7, 2016 at 4:07 PM, Shreyansh Jain wrote: > crypto and ethdev drivers aligned to PCI probe/remove. Existing handlers for > init/uninit can be easily reused for this. I would keep in the commit log a mention on the 1 - 1 association between the ethdev/crypto device and the pci device. Besides, I kind of remember a suggestion to rename init as probe and uninit as remove (Thomas ?). But this can go later in the series. -- David Marchand